From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F11DEC4338F for ; Tue, 10 Aug 2021 13:56:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7F1860F41 for ; Tue, 10 Aug 2021 13:56:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B7F1860F41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0eXrJzB1AWvAfZFp8UXE9PjKz9Xs0kfzJdIcxQvE5h4=; b=FGDwmUkDYT2nr8 IY/5orgu88cgelHbbq5cESxUkMKZ+4FbBZRnRqOjpfv7tgvALzc4skQ38kpIe1zsT0Bce0C4Eff+E 4x6f4ax1f3MDU7rM2yRWXBrMJl3HTtVhKiNK3O++Qyhj1SwWUNzcfCP75h80kmatJaoKfZxSpfUV8 U1T9o1IXdbeskKbgEoVEJYtXrsfAJDVw5ocGnjvltglY9Ot/gDLgU5XzHbIEwcFgqcJxwR7x6g2nY F8Pcak0z2KkzgAS3htzq2FjUda57MzeH2YSQDv6gtwglR10gaiRLZdvv6FbXA/7kRx2sXJpQJLxlh dJZSLpP4W+T309cROWMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDSD8-0043sn-MW; Tue, 10 Aug 2021 13:54:30 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDSD2-0043py-8c for linux-arm-kernel@lists.infradead.org; Tue, 10 Aug 2021 13:54:28 +0000 Received: by mail-lf1-x12f.google.com with SMTP id b6so25351120lff.10 for ; Tue, 10 Aug 2021 06:54:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jwWuIJqiBzpe1+2G6GtRorjiBXRmpvLNd3Ic9h54t+Q=; b=W8fomkKIUYVT177erd3QXdCb9N+w4GU7xEHCTq5V+/pLfs4vtKwHrQWVUWoJUa0WKb yROIoySSTQNgzo/gwzIxqRF0R5bfQS+nDpd4VtEzC7ELr7a7smTBhEYmnBQS7iU28eFl 6/XmILEUsrPbVSQo2USlm6N8PSX516JZiNcZJXsvUVhtLxfMxR0eLAOF6GrZr45uhpYA i7Yq+yxNWPQ9DzLISfpIM6HOHFoZYWG8HkNOCTHmLhZ4GupDBs4AmopLoCHgMdalRbIB DLdHvCypgf5HJo3jpK3W4lZxDXnfAGL3udivEZnwKrCtcdQJBxxszPhgqQXRt34MHJsX q8WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jwWuIJqiBzpe1+2G6GtRorjiBXRmpvLNd3Ic9h54t+Q=; b=QN+s7FBKAxmQnnUdfqsJhkNmX8pV5kE1HuDgyuq6d80UngO1ayBFUsdF7w9ctEXh7j SFJN5fEpEibqxrmVqZsRtAApVUJnKzG71SPOlJZUBQauqABiG1HE3qfOZq43oE6fXhMW tNs8PVSqHEU+BR7mSON0v0z47t0mKw5UUKy7IZ16io6wKSOGE35QGHftbgk0PotSxZ6g zpeVgUYSKZ30lPbLSOFOMOE5y3ee5SYuGrAQ55kJjcsthJHy9TJ7AR+eohjZKCtzbyiQ eHSXw4Vs8VrZvD4drWvop93vFiv9RAw4jNs6SIFVilL4jG7TSx+1b3C0D/MIUF9Eys5h Kpdg== X-Gm-Message-State: AOAM530PA+7A5UGu1Bm3OVIPTPGnw3F9bINcC9RRC/4SVDAiKGKqmvxn IsPArGciT1IQhxsDeSVw43Q1cr6ras8kkxJlzQu+3Q== X-Google-Smtp-Source: ABdhPJydL53OBU+42r6QKcJIZe4IlQ/SoqsP/bpkjgaMcCdQZB8nlKWRZ68tmLNyMtyFuqJpiUzbjuD8656QAXWk9KU= X-Received: by 2002:ac2:4d0f:: with SMTP id r15mr21366821lfi.649.1628603662266; Tue, 10 Aug 2021 06:54:22 -0700 (PDT) MIME-Version: 1.0 References: <20210723075858.376378-1-andrew@aj.id.au> <20210723075858.376378-5-andrew@aj.id.au> In-Reply-To: <20210723075858.376378-5-andrew@aj.id.au> From: Linus Walleij Date: Tue, 10 Aug 2021 15:54:11 +0200 Message-ID: Subject: Re: [RFC PATCH 4/6] leds: pca955x: Use pinctrl to map GPIOs to pins To: Andrew Jeffery Cc: Linux LED Subsystem , "open list:GPIO SUBSYSTEM" , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Rob Herring , Joel Stanley , Pavel Machek , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , linux-aspeed , linux-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210810_065424_354065_9DB27081 X-CRM114-Status: GOOD ( 13.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 23, 2021 at 9:59 AM Andrew Jeffery wrote: > The leds-pca955x driver currently assumes that the GPIO numberspace and > the pin numberspace are the same. This quickly falls apart with a > devicetree binding such as the following: (...) Honestly I do not understand this patch. It seems to implement a pin controller and using it in nonstandard ways. If something implements the pin controller driver API it should be used as such IMO, externally. This seems to be using it do relay calls to itself which seems complicated, just invent something locally in the driver in that case? No need to use pin control? Can you explain why this LED driver needs to implement a pin controller? Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel