Re: [PATCH v6] drm/msm/a6xx: Add support for an interconnect path

From: Doug Anderson <dianders@chromium.org>
To: Jordan Crouse <jcrouse@codeaurora.org>,
	Georgi Djakov <georgi.djakov@linaro.org>,
	Rob Clark <robdclark@gmail.com>
Cc: Evan Green <evgreen@chromium.org>,
	Kees Cook <keescook@chromium.org>,
	Jonathan Marek <jonathan@marek.ca>,
	David Airlie <airlied@linux.ie>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	Sharat Masetty <smasetty@codeaurora.org>,
	LKML <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Mamta Shukla <mamtashukla555@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	Andy Gross <andy.gross@linaro.org>,
	Colin Ian King <colin.king@canonical.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	freedreno <freedreno@lists.freedesktop.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6] drm/msm/a6xx: Add support for an interconnect path
Date: Fri, 18 Jan 2019 13:52:20 -0800	[thread overview]
Message-ID: <CAD=FV=XBBk31zqgJMqcTeNLoEWxLzow=LxQ=2geJAaf6Cpui_Q@mail.gmail.com> (raw)
In-Reply-To: <1547843058-27933-1-git-send-email-jcrouse@codeaurora.org>

Hi,

On Fri, Jan 18, 2019 at 12:24 PM Jordan Crouse <jcrouse@codeaurora.org> wrote:
>
> Try to get the interconnect path for the GPU and vote for the maximum
> bandwidth to support all frequencies. This is needed for performance.
> Later we will want to scale the bandwidth based on the frequency to
> also optimize for power but that will require some device tree
> infrastructure that does not yet exist.
>
> v6: use icc_set_bw() instead of icc_set()
> v5: Remove hardcoded interconnect name and just use the default
> v4: Don't use a port string at all to skip the need for names in the DT
> v3: Use macros and change port string per Georgi Djakov
>
> Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
> ---
>
>  drivers/gpu/drm/msm/Kconfig             |  1 +
>  drivers/gpu/drm/msm/adreno/a6xx_gmu.c   | 20 ++++++++++++++++++++
>  drivers/gpu/drm/msm/adreno/adreno_gpu.c |  9 +++++++++
>  drivers/gpu/drm/msm/msm_gpu.h           |  3 +++
>  4 files changed, 33 insertions(+)

Presumably this should go in together with the bindings:

- https://patchwork.kernel.org/patch/10739233/
- https://lkml.kernel.org/r/20181220173026.3857-3-jcrouse@codeaurora.org

...since bindings and code usually go in the same tree together.

As per discussion in v3 AKA v5
<https://patchwork.kernel.org/patch/10739231/>, we're trying to figure
out where to land this.  ;-)

-Doug

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel