From: dianders@chromium.org (Doug Anderson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM: dts: rockchip: pull up cts lines on rk3288
Date: Wed, 2 Sep 2015 16:34:38 -0700 [thread overview]
Message-ID: <CAD=FV=XRLnz3FTbwg1u2Jwg=a3dim6vwLk0yGc9kK=RGYDvxXw@mail.gmail.com> (raw)
In-Reply-To: <1441236479-4941-2-git-send-email-amstan@chromium.org>
Alex,
On Wed, Sep 2, 2015 at 4:27 PM, Alexandru M Stan <amstan@chromium.org> wrote:
> The flow control lines from a user accessible UART are optional,
> the user might not have anything connected to those pins.
> In order to prevent random interrupts happening and noise affecting
> the cts pin should be pulled up.
>
> Note that the default state for that pin on the rk3288 is pulled up,
> so this patch merely restores them.
>
> This is similar to what we're already doing with the RX pin,
> so it should be safe. At worst it might be a slightly higher power usage
> (through ~50 kohms) when the cts is low.
>
> Suggested-by: Neil Hendin <nhendin@chromium.org>
> Signed-off-by: Alexandru M Stan <amstan@chromium.org>
> ---
> Changes in v2: None
Probably not entirely true. ;)
> arch/arm/boot/dts/rk3288.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Looks good to me.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
next prev parent reply other threads:[~2015-09-02 23:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 23:27 [PATCH v2 0/2] ARM: dts: rockchip: pull up cts lines Alexandru M Stan
2015-09-02 23:27 ` [PATCH v2 1/2] ARM: dts: rockchip: pull up cts lines on rk3288 Alexandru M Stan
2015-09-02 23:34 ` Doug Anderson [this message]
2015-09-02 23:27 ` [PATCH v2 2/2] ARM: dts: rockchip: Remove specific cts pullup from veyron Alexandru M Stan
2015-09-02 23:35 ` Doug Anderson
2015-09-03 19:03 ` [PATCH v2 0/2] ARM: dts: rockchip: pull up cts lines Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=XRLnz3FTbwg1u2Jwg=a3dim6vwLk0yGc9kK=RGYDvxXw@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).