From: Austin Kim <austindh.kim@gmail.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: matthias.schiffer@ew.tq-group.com, info@metux.net,
linux-arm-kernel@lists.infradead.org, allison@lohutok.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: module: Drop 'rel->r_offset < 0' always false statement
Date: Wed, 11 Sep 2019 20:42:47 +0900 [thread overview]
Message-ID: <CADLLry7XKojSy5gaWBd0pkp5OVNrt-xysiHf69tEUPjHOS8kxA@mail.gmail.com> (raw)
In-Reply-To: <20190911094031.GU13294@shell.armlinux.org.uk>
2019년 9월 11일 (수) 오후 6:40, Russell King - ARM Linux admin
<linux@armlinux.org.uk>님이 작성:
>
> On Wed, Sep 11, 2019 at 01:54:08PM +0900, Austin Kim wrote:
> > Since rel->r_offset is declared as Elf32_Addr,
> > this value is always non-negative.
> > typedef struct elf32_rel {
> > Elf32_Addr r_offset;
> > Elf32_Word r_info;
> > } Elf32_Rel;
> >
> > typedef __u32 Elf32_Addr;
> > typedef unsigned int __u32;
> >
> > Drop 'rel->r_offset < 0' statement which is always false.
> >
> > Signed-off-by: Austin Kim <austindh.kim@gmail.com>
> > ---
> > arch/arm/kernel/module.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/kernel/module.c b/arch/arm/kernel/module.c
> > index deef17f..0921ce7 100644
> > --- a/arch/arm/kernel/module.c
> > +++ b/arch/arm/kernel/module.c
> > @@ -92,7 +92,7 @@ apply_relocate(Elf32_Shdr *sechdrs, const char *strtab, unsigned int symindex,
> > sym = ((Elf32_Sym *)symsec->sh_addr) + offset;
> > symname = strtab + sym->st_name;
> >
> > - if (rel->r_offset < 0 || rel->r_offset > dstsec->sh_size - sizeof(u32)) {
> > + if (rel->r_offset > dstsec->sh_size - sizeof(u32)) {
> > pr_err("%s: section %u reloc %u sym '%s': out of bounds relocation, offset %d size %u\n",
>
> Also change %d to %u here.
Let me resend the patch with the change(%d to %u).
Thanks,
Austin Kim
>
> > module->name, relindex, i, symname,
> > rel->r_offset, dstsec->sh_size);
> > --
> > 2.6.2
> >
> >
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
> According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-09-11 11:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 4:54 [PATCH] ARM: module: Drop 'rel->r_offset < 0' always false statement Austin Kim
2019-09-11 9:40 ` Russell King - ARM Linux admin
2019-09-11 11:42 ` Austin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADLLry7XKojSy5gaWBd0pkp5OVNrt-xysiHf69tEUPjHOS8kxA@mail.gmail.com \
--to=austindh.kim@gmail.com \
--cc=allison@lohutok.net \
--cc=info@metux.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.schiffer@ew.tq-group.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).