From: Gene Chen <gene.chen.richtek@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Gene Chen <gene_chen@richtek.com>,
devicetree <devicetree@vger.kernel.org>,
linux-pm@vger.kernel.org, sre@kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] dt-bindings: power: Add bindings document for Charger support on MT6360 PMIC
Date: Tue, 20 Oct 2020 17:03:00 +0800 [thread overview]
Message-ID: <CAE+NS35gb_KWq3s-M9apxgr7wnNRyn7iPto8J8ZwA-jsgT=paw@mail.gmail.com> (raw)
In-Reply-To: <20201016153823.GA9890@kozik-lap>
Krzysztof Kozlowski <krzk@kernel.org> 於 2020年10月16日 週五 下午11:38寫道:
>
> On Wed, Sep 23, 2020 at 07:18:29PM +0800, Gene Chen wrote:
> > From: Gene Chen <gene_chen@richtek.com>
> >
> > Add bindings document for Charger support on MT6360 PMIC
> >
> > Signed-off-by: Gene Chen <gene_chen@richtek.com>
> > ---
> > .../bindings/power/supply/mt6360_charger.yaml | 44 ++++++++++++++++++++++
> > 1 file changed, 44 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/power/supply/mt6360_charger.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/power/supply/mt6360_charger.yaml b/Documentation/devicetree/bindings/power/supply/mt6360_charger.yaml
> > new file mode 100644
> > index 0000000..711fc19
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/supply/mt6360_charger.yaml
> > @@ -0,0 +1,44 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/power/supply/mt6360_charger.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Battery charger driver for MT6360 PMIC from MediaTek Integrated.
> > +
> > +maintainers:
> > + - Gene Chen <gene_chen@richtek.com>
> > +
> > +description: |
> > + This module is part of the MT6360 MFD device.
> > + Provides Battery Charger, Boost for OTG devices and BC1.2 detection.
> > +
> > +properties:
> > + compatible:
> > + const: mediatek,mt6360-chg
> > +
> > + vinovp:
> > + description:
> > + Maximum CHGIN regulation voltage.
>
> 1. You need to describe the type.
> 2. Use proper unit suffix (see property-units.txt).
> 3. Is this a custom property? If yes, it misses vendor prefix. If not,
> most likely there is already such property. Reuse.
>
ACK
> > +
> > + usb-otg-vbus:
> > + $ref: /schemas/regulator/regulator.yaml#
>
> 1. Wrong indentation.
> 2. Name should be more or less generic, so maybe
> "usb-otg-vbus-regulator".
>
ACK
> > +
> > +required:
> > + - compatible
>
> No address/reg? How does it bind?
>
This module is part of the MT6360 MFD device.
see Documentation/devicetree/bindings/mfd/mt6360.yaml, which is
reviewing by MFD reviewer.
Should I add this to description?
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + mt6360_chg: chg {
>
> s/chg/charger/
>
ACK
> > + compatible = "mediatek,mt6360-chg";
> > + vinovp = <14500000>;
>
> Empty line break
>
ACK
> Best regards,
> Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-10-20 9:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 11:18 [PATCH 1/2] dt-bindings: power: Add bindings document for Charger support on MT6360 PMIC Gene Chen
2020-09-23 11:18 ` [PATCH 2/2] power: supply: mt6360_charger: add MT6360 charger support Gene Chen
2020-10-14 2:34 ` Gene Chen
2020-10-16 15:52 ` Krzysztof Kozlowski
2020-10-26 6:45 ` Gene Chen
2020-10-27 20:13 ` Krzysztof Kozlowski
2020-10-16 15:38 ` [PATCH 1/2] dt-bindings: power: Add bindings document for Charger support on MT6360 PMIC Krzysztof Kozlowski
2020-10-20 9:03 ` Gene Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE+NS35gb_KWq3s-M9apxgr7wnNRyn7iPto8J8ZwA-jsgT=paw@mail.gmail.com' \
--to=gene.chen.richtek@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gene_chen@richtek.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).