linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Andre Renaud <arenaud@designa-electronics.com>
To: Andy Duan <fugang.duan@nxp.com>
Cc: Fabio Estevam <festevam@gmail.com>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [EXT] Re: iMX6/UART imprecise external abort
Date: Wed, 11 Dec 2019 11:07:20 +1300	[thread overview]
Message-ID: <CAEj2-1PCDWSiP98ZN9ufa-Nws_4KSgX7Jf8gK1+TM1zEuU3SKw@mail.gmail.com> (raw)
In-Reply-To: <VI1PR0402MB3600DD7A4C9BFFE8E2805378FF5B0@VI1PR0402MB3600.eurprd04.prod.outlook.com>

Hi Andry

On Tue, Dec 10, 2019 at 6:46 PM Andy Duan <fugang.duan@nxp.com> wrote:
> > We have confirmed that this happens on the standard 5.4.1 board, but only
> > when the RS485 ioctls and corresponding device tree entries are enabled.
> > We have tried it on different hardware (the Wandboard iMX6Q), with just a
> > minor change to the device tree - the addition of uart-has-rtscts, and rts-gpio.
> Documentation/devicetree/bindings/serial/fsl-imx-uart.txt
> Note that for RS485 you must enable either the "uart-has-rtscts" or the "rts-gpios" properties.
>
> And please note rts-gpio should be the pin for CTS_B.

Thanks - we did have this wrong. However even after correcting this it
still fails in the same way. This is what we're trying:
diff --git a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
index 2cfb4112a467..5f2d3dfafcec 100644
--- a/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-wandboard.dtsi
@@ -219,6 +219,14 @@
  >;
  };
+ pinctrl_uart2: uart2grp {
+ fsl,pins = <
+        MX6QDL_PAD_SD4_DAT7__UART2_TX_DATA 0x1b0b1
+        MX6QDL_PAD_SD4_DAT4__UART2_RX_DATA 0x1b0b1
+        MX6QDL_PAD_SD4_DAT5__UART2_CTS_B    0x1b0b1
+ >;
+ };
+
  pinctrl_uart3: uart3grp {
  fsl,pins = <
  MX6QDL_PAD_EIM_D24__UART3_TX_DATA 0x1b0b1
@@ -313,13 +321,18 @@
  status = "okay";
 };
-&uart3 {
+&uart2 {
  pinctrl-names = "default";
- pinctrl-0 = <&pinctrl_uart3>;
+ pinctrl-0 = <&pinctrl_uart2>;
  uart-has-rtscts;
+  linux,rs485-enabled-at-boot-time;
  status = "okay";
 };
+&uart3 {
+ status = "disabled";
+};
+
 &usbh1 {
  status = "okay";
 };

Regards,
Andre

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-12-10 22:07 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 20:40 iMX6/UART imprecise external abort Andre Renaud
2019-12-02 20:56 ` Fabio Estevam
2019-12-03  1:53   ` [EXT] " Andy Duan
2019-12-03  2:01     ` Andre Renaud
2019-12-03  2:06       ` Andy Duan
2019-12-03  2:28       ` Fabio Estevam
2019-12-03  6:24   ` Andre Renaud
2019-12-10  4:03   ` Andre Renaud
2019-12-10  5:46     ` [EXT] " Andy Duan
2019-12-10 22:07       ` Andre Renaud [this message]
2019-12-11  0:27         ` Fabio Estevam
2019-12-11  1:35           ` [EXT] " Andre Renaud
2019-12-11  1:59             ` Andre Renaud
2019-12-12  1:35             ` Fabio Estevam
2019-12-15 23:41               ` Andre Renaud
2019-12-02 21:29 ` Uwe Kleine-König
2019-12-05 19:29   ` Andre Renaud
2019-12-21  3:33 ` Andre Renaud
2019-12-21  7:31   ` [EXT] " Andy Duan
2019-12-21 12:03     ` Fabio Estevam
2019-12-23  1:53       ` Andy Duan
2019-12-23 10:16         ` Uwe Kleine-König
2020-01-07 22:24           ` Uwe Kleine-König
2020-01-08  1:43             ` Andy Duan
2020-01-08  4:03               ` Andre Renaud
2020-01-08  5:11                 ` Andy Duan
2020-01-08  6:43                 ` Uwe Kleine-König
2020-01-08  6:40               ` Uwe Kleine-König
2020-01-08 11:23             ` Uwe Kleine-König
2020-01-09  1:33               ` Andy Duan
2020-01-19 23:29                 ` Andre Renaud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEj2-1PCDWSiP98ZN9ufa-Nws_4KSgX7Jf8gK1+TM1zEuU3SKw@mail.gmail.com \
    --to=arenaud@designa-electronics.com \
    --cc=festevam@gmail.com \
    --cc=fugang.duan@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).