From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37E4EC4338F for ; Sat, 7 Aug 2021 17:06:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C119260243 for ; Sat, 7 Aug 2021 17:06:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C119260243 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OSEri2OCeJPv3SYvvhgXcunL5OXGTXec22/AYu99g8Q=; b=sO58AZEBQXGCb5 U8vYkWAPNIMpcgiVTgcVS22MhHk0bXshfZPcjeTC3PeeRifjDfiKvo1+1ReEutFkM+v2zSImbNZYO l9KRj3MuTyOEArOPcFw97THDBHm+ELjQcvGQde0Rlxk3xcs1dQvYLO8nU63or06y3OMOzBzKNNFGX M0J9UTkIwcpkaXdLYyHr33eHqJ13XMB+RFQ7LRagr5PUfBuwoGldjyEPmZYyWS2w/zbEpXsev0WrK krZc+SLjFxgEn+8aCLLiracOxHGOwpY6n4o8Il3qXzl9GGrCvDhqVP16dGKhXkJIIaVr8FgeoElkd 7OraN8V3G6xrDRHN3iNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mCPjn-00EzRg-82; Sat, 07 Aug 2021 17:03:55 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mCPji-00EzQx-LX for linux-arm-kernel@lists.infradead.org; Sat, 07 Aug 2021 17:03:52 +0000 Received: by mail-wm1-x334.google.com with SMTP id o7-20020a05600c5107b0290257f956e02dso11234372wms.1 for ; Sat, 07 Aug 2021 10:03:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EY9y4ON0juXKYfLznttxYDzTld1gp3deUpzOVk7N+oU=; b=glpbTCGOyPbkGlJ5keLSaT+80VA+kIklrOEcnd7C4HX2im1CZRCKnLnnmO4eO93/2I 51oEkZx5ZQrbH9tHDCvtKsSvBiGweOZn5I0r5NpPzDlQc1KhM2t9p0VAVk92CR02pJ1+ ekeCHRpIIEkato3O5j+8EOQaMv1ngJGMu1KV9A9Pa0Q34gGlcLPyTsu1Fylt85rQEXGp nzZSyrNmNGtaPLIvoZuuhjjsTm3sswDuhxPP3ekSXbtq8M/D21XNozGbgvdMVHe4ZScS ADlqmpBYMytkW9gZ1K/+yZlO6A+v0QKL5HqLaVc3rDKXf9kp8+WX3XxMqMkumHSMl8SS HqYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EY9y4ON0juXKYfLznttxYDzTld1gp3deUpzOVk7N+oU=; b=nie7X+k4UV9zM6nC6ZDEQCCCjPbI5uvdMTrnIW7pkv83sZzkGvM8aLAXNF8xDvilBi 3GoIWSwmc31sajCwIh3r/6psoh7u6EY5THaV8rqOkK48AdsSt48MBglVTRT1u36ZtVkc CadWAMrGdlMVFzrudolAQHYOHZWPnf6zJqMh9+GvpQONv0W+Ms05ObJqTLcv/1k23Xlr gT/IVGBSoZ6X2+Cw7svoQIJ7EWgY1NgONcnv+ZpyMNX3tk1kNh0wYWg0Mbckhcw0lZb1 BCTiTzeNiPQAcZLfMoaQF424ubES0TstGR/buqYN9ALSAx68DV3axf5lDWhR6b9LRtjs w9mA== X-Gm-Message-State: AOAM53169286ll+F4xUXXRRvJ2hdq0y2DQWJZqnGLjwMQjSa4iM78P0t gPR5WvFIe3mTpkgjkyanDJruh2MXnNE1TVQXxBA= X-Google-Smtp-Source: ABdhPJzxUQgXEhZKiVPSljDBCuN8hvEk14E1C9HBZE8++O0L0mZVtCGLPLKhOz6j6UVg+bmnp4jG1hHHA5nPQPsChQU= X-Received: by 2002:a7b:cc8b:: with SMTP id p11mr25606015wma.164.1628355827296; Sat, 07 Aug 2021 10:03:47 -0700 (PDT) MIME-Version: 1.0 References: <20210803090704.32152-1-tzimmermann@suse.de> <20210803090704.32152-8-tzimmermann@suse.de> <1f5f285a-b923-16ff-2ca1-6f92e22ffcab@linaro.org> In-Reply-To: <1f5f285a-b923-16ff-2ca1-6f92e22ffcab@linaro.org> From: Rob Clark Date: Sat, 7 Aug 2021 10:08:02 -0700 Message-ID: Subject: Re: [PATCH v2 07/14] drm/msm: Convert to Linux IRQ interfaces To: Dmitry Baryshkov , Thomas Zimmermann X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210807_100350_760004_87F15532 X-CRM114-Status: GOOD ( 30.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , tomi.valkeinen@ideasonboard.com, Liviu Dudau , Stefan Agner , amd-gfx list , anitha.chrisanthus@intel.com, Sam Ravnborg , Dan.Sneddon@microchip.com, Patrik Jakobsson , linux-arm-msm , freedreno , Daniel Vetter , edmund.j.dea@intel.com, Sascha Hauer , alison.wang@nxp.com, Maarten Lankhorst , Maxime Ripard , dri-devel , Sean Paul , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , tomba@kernel.org, Boris Brezillon , jyri.sarha@iki.fi, =?UTF-8?Q?Christian_K=C3=B6nig?= , Sascha Hauer , Alexander Deucher , Shawn Guo , Brian Starkey Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 3, 2021 at 2:37 AM Dmitry Baryshkov wrote: > > On 03/08/2021 12:06, Thomas Zimmermann wrote: > > Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's > > IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers > > don't benefit from using it. > > > > DRM IRQ callbacks are now being called directly or inlined. > > > > Signed-off-by: Thomas Zimmermann > > Reviewed-by: Dmitry Baryshkov > > Rob should probably also give his blessing on this patch though. > I've pushed this to msm-next-staging, but if Thomas would prefer to merge the series together then I can drop it (in which case a-b for this patch) BR, -R > > --- > > drivers/gpu/drm/msm/msm_drv.c | 113 ++++++++++++++++++++-------------- > > drivers/gpu/drm/msm/msm_kms.h | 2 +- > > 2 files changed, 69 insertions(+), 46 deletions(-) > > > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > > index 1594ae39d54f..a332b09a5a11 100644 > > --- a/drivers/gpu/drm/msm/msm_drv.c > > +++ b/drivers/gpu/drm/msm/msm_drv.c > > @@ -14,7 +14,6 @@ > > #include > > #include > > #include > > -#include > > #include > > #include > > #include > > @@ -201,6 +200,71 @@ void msm_rmw(void __iomem *addr, u32 mask, u32 or) > > msm_writel(val | or, addr); > > } > > > > +static irqreturn_t msm_irq(int irq, void *arg) > > +{ > > + struct drm_device *dev = arg; > > + struct msm_drm_private *priv = dev->dev_private; > > + struct msm_kms *kms = priv->kms; > > + > > + BUG_ON(!kms); > > + > > + return kms->funcs->irq(kms); > > +} > > + > > +static void msm_irq_preinstall(struct drm_device *dev) > > +{ > > + struct msm_drm_private *priv = dev->dev_private; > > + struct msm_kms *kms = priv->kms; > > + > > + BUG_ON(!kms); > > + > > + kms->funcs->irq_preinstall(kms); > > +} > > + > > +static int msm_irq_postinstall(struct drm_device *dev) > > +{ > > + struct msm_drm_private *priv = dev->dev_private; > > + struct msm_kms *kms = priv->kms; > > + > > + BUG_ON(!kms); > > + > > + if (kms->funcs->irq_postinstall) > > + return kms->funcs->irq_postinstall(kms); > > + > > + return 0; > > +} > > + > > +static int msm_irq_install(struct drm_device *dev, unsigned int irq) > > +{ > > + int ret; > > + > > + if (irq == IRQ_NOTCONNECTED) > > + return -ENOTCONN; > > + > > + msm_irq_preinstall(dev); > > + > > + ret = request_irq(irq, msm_irq, 0, dev->driver->name, dev); > > + if (ret) > > + return ret; > > + > > + ret = msm_irq_postinstall(dev); > > + if (ret) { > > + free_irq(irq, dev); > > + return ret; > > + } > > + > > + return 0; > > +} > > + > > +static void msm_irq_uninstall(struct drm_device *dev) > > +{ > > + struct msm_drm_private *priv = dev->dev_private; > > + struct msm_kms *kms = priv->kms; > > + > > + kms->funcs->irq_uninstall(kms); > > + free_irq(kms->irq, dev); > > +} > > + > > struct msm_vblank_work { > > struct work_struct work; > > int crtc_id; > > @@ -265,7 +329,7 @@ static int msm_drm_uninit(struct device *dev) > > } > > > > /* We must cancel and cleanup any pending vblank enable/disable > > - * work before drm_irq_uninstall() to avoid work re-enabling an > > + * work before msm_irq_uninstall() to avoid work re-enabling an > > * irq after uninstall has disabled it. > > */ > > > > @@ -294,7 +358,7 @@ static int msm_drm_uninit(struct device *dev) > > drm_mode_config_cleanup(ddev); > > > > pm_runtime_get_sync(dev); > > - drm_irq_uninstall(ddev); > > + msm_irq_uninstall(ddev); > > pm_runtime_put_sync(dev); > > > > if (kms && kms->funcs) > > @@ -553,7 +617,7 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv) > > > > if (kms) { > > pm_runtime_get_sync(dev); > > - ret = drm_irq_install(ddev, kms->irq); > > + ret = msm_irq_install(ddev, kms->irq); > > pm_runtime_put_sync(dev); > > if (ret < 0) { > > DRM_DEV_ERROR(dev, "failed to install IRQ handler\n"); > > @@ -662,43 +726,6 @@ static void msm_postclose(struct drm_device *dev, struct drm_file *file) > > context_close(ctx); > > } > > > > -static irqreturn_t msm_irq(int irq, void *arg) > > -{ > > - struct drm_device *dev = arg; > > - struct msm_drm_private *priv = dev->dev_private; > > - struct msm_kms *kms = priv->kms; > > - BUG_ON(!kms); > > - return kms->funcs->irq(kms); > > -} > > - > > -static void msm_irq_preinstall(struct drm_device *dev) > > -{ > > - struct msm_drm_private *priv = dev->dev_private; > > - struct msm_kms *kms = priv->kms; > > - BUG_ON(!kms); > > - kms->funcs->irq_preinstall(kms); > > -} > > - > > -static int msm_irq_postinstall(struct drm_device *dev) > > -{ > > - struct msm_drm_private *priv = dev->dev_private; > > - struct msm_kms *kms = priv->kms; > > - BUG_ON(!kms); > > - > > - if (kms->funcs->irq_postinstall) > > - return kms->funcs->irq_postinstall(kms); > > - > > - return 0; > > -} > > - > > -static void msm_irq_uninstall(struct drm_device *dev) > > -{ > > - struct msm_drm_private *priv = dev->dev_private; > > - struct msm_kms *kms = priv->kms; > > - BUG_ON(!kms); > > - kms->funcs->irq_uninstall(kms); > > -} > > - > > int msm_crtc_enable_vblank(struct drm_crtc *crtc) > > { > > struct drm_device *dev = crtc->dev; > > @@ -1051,10 +1078,6 @@ static const struct drm_driver msm_driver = { > > .open = msm_open, > > .postclose = msm_postclose, > > .lastclose = drm_fb_helper_lastclose, > > - .irq_handler = msm_irq, > > - .irq_preinstall = msm_irq_preinstall, > > - .irq_postinstall = msm_irq_postinstall, > > - .irq_uninstall = msm_irq_uninstall, > > .dumb_create = msm_gem_dumb_create, > > .dumb_map_offset = msm_gem_dumb_map_offset, > > .prime_handle_to_fd = drm_gem_prime_handle_to_fd, > > diff --git a/drivers/gpu/drm/msm/msm_kms.h b/drivers/gpu/drm/msm/msm_kms.h > > index 086a2d59b8c8..9de7c42e1071 100644 > > --- a/drivers/gpu/drm/msm/msm_kms.h > > +++ b/drivers/gpu/drm/msm/msm_kms.h > > @@ -150,7 +150,7 @@ struct msm_kms { > > const struct msm_kms_funcs *funcs; > > struct drm_device *dev; > > > > - /* irq number to be passed on to drm_irq_install */ > > + /* irq number to be passed on to msm_irq_install */ > > int irq; > > > > /* mapper-id used to request GEM buffer mapped for scanout: */ > > > > > -- > With best wishes > Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel