From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21B0FC4338F for ; Tue, 3 Aug 2021 17:54:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6D8A60EE9 for ; Tue, 3 Aug 2021 17:54:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C6D8A60EE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NSSQbkZUmT+9dsMPwjWfYK9nRQEf3bP+a61UnbfiLno=; b=PulLF05q4qiC6g zXArQfloy17M4uGsw8lA+0BaoJZHm8OxTg7ciDxV9NTDCq3pKXBjSP7XRaxWuzzAIZ6bYlpKHT+mC 1F+bokTkMdu2BmgjUXkH7mBNB6rJLk9QcTWm1Azl9++T0ucsZbxR+JrUSVbTUnb75BY9Mhg8GCP0J mFWOK2AfUJgwlMWzd9MFdLq7SNdLtoy+xrMfp+cEaythaV95Bqm3IDQlAfJxgJAP6uOtpRqJwJHHS fSRQ94jP/O90j3NoxEm4wZNl1897ziw1uWvWz/msbLP2GE8p1/FFrDsrkV+sHvFW/rMnUZMZZ6WC3 RCq/BIXNPufozIr4izWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAyaN-003qW9-3A; Tue, 03 Aug 2021 17:52:15 +0000 Received: from mail-yb1-xb36.google.com ([2607:f8b0:4864:20::b36]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAyaI-003qVm-FQ for linux-arm-kernel@lists.infradead.org; Tue, 03 Aug 2021 17:52:12 +0000 Received: by mail-yb1-xb36.google.com with SMTP id s48so12067748ybi.7 for ; Tue, 03 Aug 2021 10:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PBgZljFVrSeLABLK0pp/2Hz7HIGjCIFA/IERb9MuqE0=; b=GYI09HQT4+g4j0DHoO2j2OmuszyEtutHTYFs/7ctFeCVDvuZAczx/kGe8dBIUNd/rr Cm9Mu4jUrpyXlqkS0gCPtckFJ/FEMCmxYqU3ohAHB471UCp7R6FvWk6D55zklnDEDvDd V9bV/fHm7RPfVlWB06Lc0GOtkdEi3ONl874d+56nq3kEw7Vv8Mr6SF3el9VeYJgHVLfj ylr4kfYaYDQWGpk62Zex/ZyAGA9e6tlwmIRJQlpOb9EAzLLvkD6LHg45i1ZGJ6ZN3A6f 8uQPI0dC4aJ2TBNCnpDl3nf/Jns9a3jRuHW3u/+Z8GccGq2H92PXvM2AJxzusQBOsuBq s4wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PBgZljFVrSeLABLK0pp/2Hz7HIGjCIFA/IERb9MuqE0=; b=Xa1qMpDq4Wj8j+wZLNWXvuN97f3EMyFEKEgRFP1NHvMedICxLaqqzAhg+dgno4Mnlh NMTwtMXMSBn2n+5288DDUgbOaTIWi92z1rH3DJ29jdtA2WE9Gi7OOYNzZ3gmGfOs5a8Q 0y/3mjUeuxP37voYFAodsrOBlmtbPc+dXecz0HK78m2+q8vZ2xcT8v0BBOe7ad1IqREN jcF6ECmOvVMg2cFcieexMk14uMCRmaXacZed2MEaIKtAw9MjDDA0i7vnYvV8bLfu8oUn BjBg1hIsoHbyiaJRZr7E0GEB9j22GZeipCCD4t/XeRuxMiap6i2DjO9Ef9KLkN3FQ+c4 /LVw== X-Gm-Message-State: AOAM533hSolyVAkKuf7CM/bhixJDp35cc2U9yMDIzGhb76jBmiKDsJbT SAfUwUx6ByR8YQxzb7jao6R3MjM1IBSSIFArjeNVYA== X-Google-Smtp-Source: ABdhPJzjgKwOlw/JSZYeLJKFxQJU1P1kFOhTXCVfn2HkPxUGntC/t/KCQXvtOgO+s2Z+ENrSk1g7mWqYdSF9VroZLJ4= X-Received: by 2002:a25:d450:: with SMTP id m77mr30661363ybf.412.1628013128847; Tue, 03 Aug 2021 10:52:08 -0700 (PDT) MIME-Version: 1.0 References: <20210803113538.560277-1-fido_max@inbox.ru> In-Reply-To: <20210803113538.560277-1-fido_max@inbox.ru> From: Saravana Kannan Date: Tue, 3 Aug 2021 10:51:32 -0700 Message-ID: Subject: Re: [PATCH v4] soc: fsl: qe: convert QE interrupt controller to platform_device To: Maxim Kochetkov Cc: linuxppc-dev@lists.ozlabs.org, qiang.zhao@nxp.com, leoyang.li@nxp.com, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel test robot , Dan Carpenter X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210803_105210_582099_6BE3EED0 X-CRM114-Status: GOOD ( 28.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 3, 2021 at 4:33 AM Maxim Kochetkov wrote: > > Since 5.13 QE's ucc nodes can't get interrupts from devicetree: > > ucc@2000 { > cell-index = <1>; > reg = <0x2000 0x200>; > interrupts = <32>; > interrupt-parent = <&qeic>; > }; > > Now fw_devlink expects driver to create and probe a struct device > for interrupt controller. > > So lets convert this driver to simple platform_device with probe(). > Also use platform_get_ and devm_ family function to get/allocate > resources and drop unused .compatible = "qeic". Yes, please! Acked-by: Saravana Kannan -Saravana > > [1] - https://lore.kernel.org/lkml/CAGETcx9PiX==mLxB9PO8Myyk6u2vhPVwTMsA5NkD-ywH5xhusw@mail.gmail.com > Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") > Fixes: ea718c699055 ("Revert "Revert "driver core: Set fw_devlink=on by default""") > Signed-off-by: Maxim Kochetkov > Reported-by: kernel test robot > Reported-by: Dan Carpenter > --- > drivers/soc/fsl/qe/qe_ic.c | 75 ++++++++++++++++++++++---------------- > 1 file changed, 44 insertions(+), 31 deletions(-) > > diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c > index 3f711c1a0996..e710d554425d 100644 > --- a/drivers/soc/fsl/qe/qe_ic.c > +++ b/drivers/soc/fsl/qe/qe_ic.c > @@ -23,6 +23,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -404,41 +405,40 @@ static void qe_ic_cascade_muxed_mpic(struct irq_desc *desc) > chip->irq_eoi(&desc->irq_data); > } > > -static void __init qe_ic_init(struct device_node *node) > +static int qe_ic_init(struct platform_device *pdev) > { > + struct device *dev = &pdev->dev; > void (*low_handler)(struct irq_desc *desc); > void (*high_handler)(struct irq_desc *desc); > struct qe_ic *qe_ic; > - struct resource res; > - u32 ret; > + struct resource *res; > + struct device_node *node = pdev->dev.of_node; > > - ret = of_address_to_resource(node, 0, &res); > - if (ret) > - return; > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (res == NULL) { > + dev_err(dev, "no memory resource defined\n"); > + return -ENODEV; > + } > > - qe_ic = kzalloc(sizeof(*qe_ic), GFP_KERNEL); > + qe_ic = devm_kzalloc(dev, sizeof(*qe_ic), GFP_KERNEL); > if (qe_ic == NULL) > - return; > + return -ENOMEM; > > - qe_ic->irqhost = irq_domain_add_linear(node, NR_QE_IC_INTS, > - &qe_ic_host_ops, qe_ic); > - if (qe_ic->irqhost == NULL) { > - kfree(qe_ic); > - return; > + qe_ic->regs = devm_ioremap(dev, res->start, resource_size(res)); > + if (qe_ic->regs == NULL) { > + dev_err(dev, "failed to ioremap() registers\n"); > + return -ENODEV; > } > > - qe_ic->regs = ioremap(res.start, resource_size(&res)); > - > qe_ic->hc_irq = qe_ic_irq_chip; > > - qe_ic->virq_high = irq_of_parse_and_map(node, 0); > - qe_ic->virq_low = irq_of_parse_and_map(node, 1); > + qe_ic->virq_high = platform_get_irq(pdev, 0); > + qe_ic->virq_low = platform_get_irq(pdev, 1); > > - if (!qe_ic->virq_low) { > - printk(KERN_ERR "Failed to map QE_IC low IRQ\n"); > - kfree(qe_ic); > - return; > + if (qe_ic->virq_low < 0) { > + return -ENODEV; > } > + > if (qe_ic->virq_high != qe_ic->virq_low) { > low_handler = qe_ic_cascade_low; > high_handler = qe_ic_cascade_high; > @@ -447,6 +447,13 @@ static void __init qe_ic_init(struct device_node *node) > high_handler = NULL; > } > > + qe_ic->irqhost = irq_domain_add_linear(node, NR_QE_IC_INTS, > + &qe_ic_host_ops, qe_ic); > + if (qe_ic->irqhost == NULL) { > + dev_err(dev, "failed to add irq domain\n"); > + return -ENODEV; > + } > + > qe_ic_write(qe_ic->regs, QEIC_CICR, 0); > > irq_set_handler_data(qe_ic->virq_low, qe_ic); > @@ -456,20 +463,26 @@ static void __init qe_ic_init(struct device_node *node) > irq_set_handler_data(qe_ic->virq_high, qe_ic); > irq_set_chained_handler(qe_ic->virq_high, high_handler); > } > + return 0; > } > +static const struct of_device_id qe_ic_ids[] = { > + { .compatible = "fsl,qe-ic"}, > + { .type = "qeic"}, > + {}, > +}; > > -static int __init qe_ic_of_init(void) > +static struct platform_driver qe_ic_driver = > { > - struct device_node *np; > + .driver = { > + .name = "qe-ic", > + .of_match_table = qe_ic_ids, > + }, > + .probe = qe_ic_init, > +}; > > - np = of_find_compatible_node(NULL, NULL, "fsl,qe-ic"); > - if (!np) { > - np = of_find_node_by_type(NULL, "qeic"); > - if (!np) > - return -ENODEV; > - } > - qe_ic_init(np); > - of_node_put(np); > +static int __init qe_ic_of_init(void) > +{ > + platform_driver_register(&qe_ic_driver); > return 0; > } > subsys_initcall(qe_ic_of_init); > -- > 2.31.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel