From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D95EDC433E0 for ; Mon, 29 Jun 2020 13:42:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A937F23B06 for ; Mon, 29 Jun 2020 13:42:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1EvpgdlA"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qJOEMzB7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A937F23B06 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QM0+ZzcBc4Puy6EIeR2SLGJtGs9LdXQdHXi1/RPDwJU=; b=1EvpgdlABwhaAPl6cWOM88HIY sq6KiPFAjrK12IqA3BclSGaXcTl2SHS5TlIcE0aPz2BVCimEnYyR9BogmnFVxpmNuJd6+ZIvmNKlp hPlO58lSsSPHbvyp49nuLWNZv25q28o1hqxUxkYUSe9PnV8XHQ3HJcslSko+HwUvJUoDuV6Thu0wF ugLaCOg/Ic6lpkggMTogZB+1OpL2Po/0Fy4gMwG2KMu8e2aKY4XGM2jZByE8V4x9PjAese2WK6zpR 3cWMlpCO5EbzvMMkt2DhVNtxh8FTIEBVy1b/ShSEOKJZ0DZTzU9i3n6rYiTpzzvEqMgNk9sbNeTcC 5zL6MycWg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpu1p-0000xv-Lg; Mon, 29 Jun 2020 13:40:57 +0000 Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpu1m-0000xe-Io for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 13:40:55 +0000 Received: by mail-ot1-x343.google.com with SMTP id 76so1086894otu.9 for ; Mon, 29 Jun 2020 06:40:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e2yPHKowUi96Vn2b3DOoicWlqu6R072c9j8HQHzbwdU=; b=qJOEMzB7xbxdQjpO+XL5H0gKfxvjsVXEi6ZaHyfxCFOI5uO9ZlyJzc3O6PJoV2fkmv loacqs6nDBuoGABmSYSH7aZL4osJDtZbvQzHSUGu1mmO/EEXyyV3RGKTlb+LYOiNz6eK qjEkdk1p9Z2GTjVS7xRdj1ocEXJL9XX/jBQ03tgMrwLsf1aDakKhjRRtrqfRSryeO0K+ o+Hv92Tx+nGSK1WzW7EvZjrBFhJc8infvGvOVcLjEJ3Q9BgyTayq9rWYD5nsP2BYmsiw 55XmrnGd/w3ufr6QwTCIFKgnkXF+y94EJDQL1UEM8MxNA17C2VJYFjNrmrx5QdB7q/6q zWgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e2yPHKowUi96Vn2b3DOoicWlqu6R072c9j8HQHzbwdU=; b=dVO2N8QzRRo1RZodGFPpPhbj988zocmsvCWtf3ao98/tXbp7mXuj4QUoAvj8dT7KXu 52I9bXxMoXT+yQe3mr/C4AgS76tvhN2zZqgBGzlQc8KDVgkvVz0fT3puwFzLLVu4TVJQ kDNhf8UdRInQ6O9hGqDJzjXztGkUg2UO/WF59l78CFZpq7g7wk71x0NARz9hex94Kpbj 5Oj2HgZDyWQQGFa2QMZKNd+lsLiQnWlPB4B1GIO+ZtTGKN245IfqOqs3VGM/Y++J+S4H 4yvRAP1sEL5svr0xyzzYCaXJSxILSpEJrMEPGcvcpARmd/30sZ/4Cyk7+jxjhL9k/7hH dFOw== X-Gm-Message-State: AOAM533z9hebMYk7BJhx4w2nY3wGBtwvep5Powdq1fYKvG4ZaeYoh2KJ Zo7lo+a1J3KpqbZsOhqNRxBg0YpcQbOmiEK4q30= X-Google-Smtp-Source: ABdhPJw7kEzXBxJJnUuNUUoU45XMZoYtBPe0snAmYN8gjM/GZ/pcyzUWVZ8CWfI2On4ChM+3h/EaYLLVeEcrx/mUa+o= X-Received: by 2002:a9d:2c26:: with SMTP id f35mr13978875otb.232.1593438050647; Mon, 29 Jun 2020 06:40:50 -0700 (PDT) MIME-Version: 1.0 References: <20200625140105.14999-1-TheSven73@gmail.com> <20200625140105.14999-2-TheSven73@gmail.com> In-Reply-To: From: Sven Van Asbroeck Date: Mon, 29 Jun 2020 09:40:38 -0400 Message-ID: Subject: Re: [PATCH v4 2/2] ARM: imx6plus: enable internal routing of clk_enet_ref where possible To: Fabio Estevam X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fugang Duan , Sascha Hauer , linux-kernel , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Fabio, On Mon, Jun 29, 2020 at 9:10 AM Fabio Estevam wrote: > > I have tested this series on an imx6qp sabresd and unfortunately, it > breaks Ethernet as I can no longer get an IP address from the DHCP > server. Thank you for testing this out on a different platform ! I had a look at how things are done in the Freescale fork of the kernel (5.4.24_2.1.0) and I noticed that this kernel has almost the same behaviour as this proposed patch: the GPR5 bit is _always_ set on a plus. The code does not check how the enet clock is generated. https://source.codeaurora.org/external/imx/linux-imx/tree/arch/arm/mach-imx/mach-imx6q.c?h=rel_imx_5.4.24_2.1.0&id=babac008e5cf168abca1a85bda2e8071ca27a5c0#n269 Now, I'm assuming that the sabresd-plus can run on the Freescale kernel fork. The GPR5 bit will always be set there. So why won't mainline work with this patch? What have I overlooked? I'm sure you've checked that sabresd ethernet works ok on mainline even without this patch? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel