From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C07AC4338F for ; Tue, 3 Aug 2021 18:22:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A826960BD3 for ; Tue, 3 Aug 2021 18:22:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A826960BD3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vRntaWSkbYJBucNAM8szm+2NUDKrCCYM3qGgb7CvYp8=; b=Z6uIGXBJTqTyY3 CfpjZZycWEWVPJ4IXFAKr5TF9RTVvHlGpV1QlPB1awAzBg71zsI09ACl65Qk5EY5LD1Vi78nuVWE3 J1BCFQUayaLmSF+jnCmj9GQMCKMmXOS+QNZf6Jn1YQzCFj11NZrozaEIaq5IPgRxrUn7oomPg8JI6 TUGCs9+WTKlC5FYEQkiZlsZIL+JNjKQqGicTW0RlyGrRW1eEPJxyZwvgTDVUfLTf/F56vV1OyJWDU tmwTrB++ic7yVwITNBo5WH2QqeC2wocJqp//hazqdadfrgcV2Xf6pC11Hlb7hVEIZo44qEvms2ZLt XFxanyj4+s3q1C+Fe73g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAz2H-003tVs-22; Tue, 03 Aug 2021 18:21:05 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAz2C-003tUb-Kd; Tue, 03 Aug 2021 18:21:02 +0000 Received: by mail-pj1-x102b.google.com with SMTP id s22-20020a17090a1c16b0290177caeba067so5164283pjs.0; Tue, 03 Aug 2021 11:20:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7wjJjxr5NY0mlwpeyO/0mlW4pSwnhPT8csogJcd6W20=; b=oTWlF+ytCtIPrUcUvp8jE0sc3VSofJeRtWtO50ijRo8f4zlLr1u+0xzEwZr5wKCb3S kafEZY+V7A1q1MGb7sfDAAg9/QhwYKV2pK0upfGL3mTUpGB/TEo+ymwfJd9bsRt18yoY 57JKveqpiuCBW7pDdTBcPeGR3cioqGdDn7F/I9DvN283Sm6U8H5ar9nLcYP3JNeopFVx /Amsh+qQ6e5PC2cDVkSDGuak4hOLwgmk2n0d9L/gzCKK7l2MTSNLFcXskIvxqTCHY/bJ r2VLi3663hCYx2AtShEcDY3J0kbhIiiuNiiLUJj6Z/POYZNte3GmzrOWeDdWywb6rhRG 4kwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7wjJjxr5NY0mlwpeyO/0mlW4pSwnhPT8csogJcd6W20=; b=GxypZlXabnFR4ueVcp5p1Ujh3lfrSrlK+Nsn3GpwolVh6YWC7hJ+Z+Psahw/rGEOrm HOEb/RALc6P0G/UvAkwfkm3wmAppM9m7eTkmam83YF6rWE6Ae4DV9zkiFe9JBWl18aCd e/tbcRP+UMfTG4jmUGJtqTQkpJrF5AXH7mcZ6YXiXc6GrSnU9u2XQ5hMZN+UyeOfnecU 4w+6DbEg97mywi+OlqO2e1TILjW6jSxRGM0xW6XIzOIzXyhalEwaRi74w2vL86vDP4KK 6s9pAWJhuaczvBs3RY6AZ4Fg0iSsL/pdotir8sDoaHH/QP7jhG8Yusgppq46AREPqhx9 yZ2Q== X-Gm-Message-State: AOAM530wfwwLBDdXTRt97uGHkqYfZneSS/lq7vhICPMRB2fZ/7p2Oalt VUOV6dAEcmcxqXZ7ZSWRkHxapVVTfUTViCK6V70= X-Google-Smtp-Source: ABdhPJzZT0+vtNBMGVaB8Nb80jJILp9VjVeN4ZHUp/Ifl25xewd/m4FajCdsFVO6zIQQgTLr+fZlDuaC9zZgdT9ply8= X-Received: by 2002:a17:90a:b10b:: with SMTP id z11mr5690793pjq.181.1628014858846; Tue, 03 Aug 2021 11:20:58 -0700 (PDT) MIME-Version: 1.0 References: <20210803102428.6476-1-Mason.Zhang@mediatek.com> In-Reply-To: <20210803102428.6476-1-Mason.Zhang@mediatek.com> From: Andy Shevchenko Date: Tue, 3 Aug 2021 21:20:19 +0300 Message-ID: Subject: Re: [PATCH v2 3/4] spi: mediatek: modify set_cs_timing callback To: Mason Zhang Cc: Mark Brown , Matthias Brugger , Laxman Dewangan , linux-spi , Linux Kernel Mailing List , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Mediatek WSD Upstream X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210803_112100_747925_29F1B653 X-CRM114-Status: GOOD ( 16.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 3, 2021 at 1:42 PM Mason Zhang wrote: > > This patch modified set_cs_timing callback: > 1 support spi_device set cs_timing in their driver; > 2 support set absolute time but no clk count, because; > clk src will change in different platform; > 3 call this function in prepare_message but not in other API. Perhaps it should be 3 patches? ... > +static int mtk_spi_set_hw_cs_timing(struct spi_device *spi) > +{ > + struct mtk_spi *mdata = spi_master_get_devdata(spi->master); > + struct spi_delay *cs_setup = &spi->cs_setup; > + struct spi_delay *cs_hold = &spi->cs_hold; > + struct spi_delay *cs_inactive = &spi->cs_inactive; > + u16 setup, hold, inactive; > + u32 reg_val; > + int delay; > + > + delay = spi_delay_to_ns(cs_setup, NULL); > + if (delay < 0) > + return delay; > + setup = (delay / 1000) * DIV_ROUND_UP(mdata->spi_clk_hz, 1000000); 1000 is NSEC_PER_USEC (here and below)? > + delay = spi_delay_to_ns(cs_hold, NULL); > + if (delay < 0) > + return delay; > + hold = (delay / 1000) * DIV_ROUND_UP(mdata->spi_clk_hz, 1000000); > + > + delay = spi_delay_to_ns(cs_inactive, NULL); > + if (delay < 0) > + return delay; > + inactive = (delay / 1000) * DIV_ROUND_UP(mdata->spi_clk_hz, 1000000); > + setup = setup ? setup : 1; > + hold = hold ? hold : 1; > + inactive = inactive ? inactive : 1; All of these can be simplified by using ?: (short ternary) form. > + reg_val = readl(mdata->base + SPI_CFG0_REG); > + if (mdata->dev_comp->enhance_timing) { > + reg_val &= ~(0xffff << SPI_ADJUST_CFG0_CS_HOLD_OFFSET); > + reg_val |= (((hold - 1) & 0xffff) > + << SPI_ADJUST_CFG0_CS_HOLD_OFFSET); > + reg_val &= ~(0xffff << SPI_ADJUST_CFG0_CS_SETUP_OFFSET); > + reg_val |= (((setup - 1) & 0xffff) > + << SPI_ADJUST_CFG0_CS_SETUP_OFFSET); > + } else { > + reg_val &= ~(0xff << SPI_CFG0_CS_HOLD_OFFSET); > + reg_val |= (((hold - 1) & 0xff) << SPI_CFG0_CS_HOLD_OFFSET); > + reg_val &= ~(0xff << SPI_CFG0_CS_SETUP_OFFSET); > + reg_val |= (((setup - 1) & 0xff) > + << SPI_CFG0_CS_SETUP_OFFSET); > + } > + writel(reg_val, mdata->base + SPI_CFG0_REG); > + > + reg_val = readl(mdata->base + SPI_CFG1_REG); > + reg_val &= ~SPI_CFG1_CS_IDLE_MASK; > + reg_val |= (((inactive - 1) & 0xff) << SPI_CFG1_CS_IDLE_OFFSET); > + writel(reg_val, mdata->base + SPI_CFG1_REG); > + > + return 0; > +} -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel