From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ye Weihua <yeweihua4@huawei.com>
Cc: l.stelmach@samsung.com, mpm@selenic.com,
herbert@gondor.apana.org.au,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
yangjihong1@huawei.com, zhangjinhao2@huawei.com
Subject: Re: [PATCH -next] hwrng: exynos - fix PM reference leak in exynos_trng_probe()
Date: Fri, 9 Apr 2021 08:17:06 +0200 [thread overview]
Message-ID: <CAJKOXPfvg1o1kTqm7=E6BmXe06=SwE413fqz=VDHnAGcfMW0ow@mail.gmail.com> (raw)
In-Reply-To: <20210409061125.214255-1-yeweihua4@huawei.com>
On Fri, 9 Apr 2021 at 08:11, Ye Weihua <yeweihua4@huawei.com> wrote:
>
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here.
> Fix it by replacing it with pm_runtime_resume_and_get to keep usage
> counter balanced.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ye Weihua <yeweihua4@huawei.com>
Hi,
The same Lukasz' comment applies here as for Qinglang's patch from
November 2020 - resume also needs fix up.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-04-09 6:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 6:11 [PATCH -next] hwrng: exynos - fix PM reference leak in exynos_trng_probe() Ye Weihua
2021-04-09 6:17 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJKOXPfvg1o1kTqm7=E6BmXe06=SwE413fqz=VDHnAGcfMW0ow@mail.gmail.com' \
--to=krzk@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=l.stelmach@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=yangjihong1@huawei.com \
--cc=yeweihua4@huawei.com \
--cc=zhangjinhao2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).