From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3E5AC433E0 for ; Mon, 29 Jun 2020 13:22:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89EAD23D68 for ; Mon, 29 Jun 2020 13:22:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VeZJGMAz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89EAD23D68 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S5qNCMUVYAVPmC73VvbvK//HVHwlmqhSf3+St7UvaNU=; b=VeZJGMAz5tLfHENsGwFApL2Ud 8LoLWtXoqX7BdBGezxayOHxJMZZqzzV6h9bTLtlz5bFl2Fi/d04TFkCPG0GVOlUBdmVn6zyjan6EX zYsEYjns2D+QwXbIOZwI9/xWp9QsL+re78GI2kEi3LjRmr6YSQj3lq6WAJY6QtRq/788aok3YMFnV Pw6eeVOD6P+1c3rtvTckOUJt4g//kbGHKxSI6jd6X3hm3LyzyGxg7ddhLweJXTxKfdoGlv3SBnPTJ PHtDc8RE3JUrloXI7yCn7qbHagM0Rul+kEkyqs8PouZgXIkDAHRZ8gkWMTlJx9N772Gw0PdhiF2Z6 TUvKGQ+MQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jptiA-0007O2-Fy; Mon, 29 Jun 2020 13:20:38 +0000 Received: from mout.kundenserver.de ([212.227.126.135]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpti6-0007Na-DN for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 13:20:35 +0000 Received: from mail-qk1-f176.google.com ([209.85.222.176]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MeknF-1jHONB1bCH-00am51 for ; Mon, 29 Jun 2020 15:20:32 +0200 Received: by mail-qk1-f176.google.com with SMTP id e11so15181276qkm.3 for ; Mon, 29 Jun 2020 06:20:31 -0700 (PDT) X-Gm-Message-State: AOAM5335oMphPnW7PbzsEVSQ4dz7eAGYCo70YDK0R4tAlneY+0CPzZzG hItENYeYuEjh56viNHMm9wnWkcXxgdVn1Zamv/w= X-Google-Smtp-Source: ABdhPJwdmyIy2DXspwln00tSJlWBM/RffskxeSD5edRyoGLfgGk7pYtSMO2AKnWt6g6WM8uCKr4sKoJigN65H2p7/FQ= X-Received: by 2002:a05:620a:1654:: with SMTP id c20mr8459703qko.138.1593436830130; Mon, 29 Jun 2020 06:20:30 -0700 (PDT) MIME-Version: 1.0 References: <1593410042-10598-1-git-send-email-Anson.Huang@nxp.com> <1593410042-10598-5-git-send-email-Anson.Huang@nxp.com> In-Reply-To: From: Arnd Bergmann Date: Mon, 29 Jun 2020 15:20:13 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V3 04/10] clk: imx: Support building SCU clock driver as module To: Anson Huang X-Provags-ID: V03:K1:Y8vtt+5Vh30b3yjBMPxnJRAXN+nTMoU3I2UUFqSNaoQvu+0OOJr pOHqhqilPQF+RhUBteQon2rA7KW1xqkRFli9jUrJcD2OMRxWoHljDw7ZphjMhhYQ+mY9hlV tGU4K8Zld73hw4ZzpNKBBSmL5tLRcM/AM8fKx5elvFhc1Cc20JKOCOQMzii0iAazdM64kWy RdBSk/psnzpWHgBj4mwEg== X-UI-Out-Filterresults: notjunk:1;V03:K0:2ZU9XIbsD2Q=:CfHzbTMfD1GE+V4HN1WjAr f1CJ1tQqI+Zad+DeINLJWO4cDcGt4Ljkr9U3osf9V9IUR++FIgeERTlQKZ/G4pguWS4yDoB8z nMHa6vkb6kqtVZub2dHnpumbwLNr1om4qhsxgCJ+8+np2kCl2tQ7kjzp7kXgKEWHBXhmB973A w354ComVccSrTdBeUGTq+XXxHrGRe4OjF3/Vu1EFLJ/DzxwPPrB7VD8ORzLVvF9oqAaeRLGiq 1twVngKkf48xqJfy8sztpWd3H/mFP3J3JddUAJr7VsZfABxAb+uluNCA/lZ/y+PJAeSoi53Sf 0vuXGEk9ng6OM7L/QJ+6qZo1K6R2PL3Yri3uFUgm++hqu7ofje76Y5LVcQNPErQ94SNOJ032X H1OHi5cY2qUJC65+ZuS2Ph61IrnHUXqhmuy4ClutFy3nLOzv1/foHxnpJ4z1LzyHP9RAy/sSA 3nqnG+eaj96oUEZheisgZ723KqmQsxRnJkzNvB6fZKhuCrS6C843i0AfHqd1992UuVSz1YL0X WTHJtLsbKfSqFOll5Ssi6+WDFimQLwEiW9GJiFUPi4xiZRGuSg7rqygphNJK0mw3t5h6pJect 9kNGA78I54f+kfPWnevnzX9HqZQ2viAAwfeqvoifowtF83wFfJukI5miKotTCuhZGw8RQOCvo +RzFpnYd9mE/TKdJobY13OUVqjy9v/t7E/4UrX/T3LG8eqNAUoYQoK0FwrPNSCXVKcc5nceIM Htn9swOcgLEqydAL057cr+ETcuzs22WgUE2Dl+sx9onQyh5BcrUhwyU110SSul8gU9nt14U8v /KwSasIsBnb8qqJqNHIk67ZCvKbcM0ZY1IgvgXtKzRLuJPyA2g= X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , Stephen Rothwell , Peng Fan , linux-clk , Andy Duan , Abel Vesa , Stefan Agner , Stephen Boyd , Shawn Guo , Sascha Hauer , YueHaibing , Russell King - ARM Linux , Daniel Baluta , "linux-kernel@vger.kernel.org" , "oleksandr.suvorov@toradex.com" , Al Viro , Sascha Hauer , Fabio Estevam , Michael Turquette , Linux ARM , dl-linux-imx Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 29, 2020 at 2:53 PM Anson Huang wrote: > > Subject: Re: [PATCH V3 04/10] clk: imx: Support building SCU clock driver as > > module > > > > On Mon, Jun 29, 2020 at 8:06 AM Anson Huang > > wrote: > > > > > --- a/drivers/clk/imx/Makefile > > > +++ b/drivers/clk/imx/Makefile > > > @@ -21,9 +21,9 @@ obj-$(CONFIG_MXC_CLK) += \ > > > clk-sscg-pll.o \ > > > clk-pll14xx.o > > > > > > -obj-$(CONFIG_MXC_CLK_SCU) += \ > > > - clk-scu.o \ > > > - clk-lpcg-scu.o > > > +mxc-clk-scu-objs += clk-lpcg-scu.o > > > +mxc-clk-scu-objs += clk-scu.o > > > +obj-$(CONFIG_MXC_CLK_SCU) += mxc-clk-scu.o > > > > It looks like the two modules are tightly connected, one is useless without the > > other. How about linking them into a combined module and dropping the > > export statement? > > > > From HW perspective, the SCU clock driver and LPCG SCU clock driver are different, > SCU clock driver is for those clocks controlled by system controller (M4 which runs a firmware), > while LPCG SCU clock is for those clock gates inside module, which means AP core can > control it directly via register access, no need to via SCU API. Sorry, I misread the patch in multiple ways. First of all, you already put clk-scu.o and clk-lpcg-scu.o files into a combined loadable module, and I had only looked at clk-scu.c. What I actually meant here was to link clk-scu.o together with clk-imx8qxp.o (and possibly future chip-specific files) into a loadable module and drop the export. > So, I think it is NOT that tightly connected, it is because they are both for i.MX8 SoCs with SCU > inside, so they are put together in the Makefile. > > If the export statement is acceptable, I think it is better to just keep it, make sense? There is nothing wrong with the export as such, this was just an idea to simplify the logic. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel