From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20588C433DF for ; Wed, 1 Jul 2020 10:15:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E183A206B6 for ; Wed, 1 Jul 2020 10:15:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xlG5dXuH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E183A206B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=maF6IfmR/EDAZLZk4WeOVMhm9QN3Alfw75CF/tY7eAo=; b=xlG5dXuHCsID3j5cke3A1nXum HQRf5OdEZhIzjXAJIPtw08r8rHdB8p6B6oI/Pc/L+5K7J9fWJ1IXD31wElBl6mKMB+QPDX1JtiLHV 7DYRfBiHBsf3eZwlCTLOamb9ZwGd9MtXMtSijoSzfsqnKjHAJmS3vjgFoonrTnf6MByJ8Vk7iP0GA ZwvSGc68J+1vnJ4UCfPZykY9bVtYFyCOWW28Fjfy91Cz4MliIBvXKHXnIaCnzYEw+ZB02WvlRzwp6 KsONKRqa6PmYAuWdc7drD/7wB9fDEoz4mwxHdHMSAiebmf0+oIq7QygrwxkH/5YeHLR2QSoA+FSmp 5QL8gUV9g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqZkl-0007iZ-I4; Wed, 01 Jul 2020 10:14:07 +0000 Received: from mout.kundenserver.de ([212.227.17.13]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqZki-0007hc-Av for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 10:14:05 +0000 Received: from mail-lj1-f172.google.com ([209.85.208.172]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MHX3X-1jddJg3jyD-00DUzN for ; Wed, 01 Jul 2020 12:14:01 +0200 Received: by mail-lj1-f172.google.com with SMTP id s1so26252333ljo.0 for ; Wed, 01 Jul 2020 03:14:00 -0700 (PDT) X-Gm-Message-State: AOAM530lVAj7okxNGTQjGT79Y/zsbg6YEpR5a04hNI02YjEyyAJglvp1 ySurY3zUpID0wh1xqNtMc9zEuVtG3kers52Fhvg= X-Google-Smtp-Source: ABdhPJxvxG0YKdQRIZLf3EEmE6+prGIuqXSwFxFbLTEkpoK2wHJFxihZY6FoRRGdIX48u3tOAqejPZ41dhROmiVpNQU= X-Received: by 2002:a2e:7f06:: with SMTP id a6mr2089791ljd.446.1593598440088; Wed, 01 Jul 2020 03:14:00 -0700 (PDT) MIME-Version: 1.0 References: <1593410042-10598-1-git-send-email-Anson.Huang@nxp.com> <1593410042-10598-3-git-send-email-Anson.Huang@nxp.com> In-Reply-To: From: Arnd Bergmann Date: Wed, 1 Jul 2020 12:13:44 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V3 02/10] init.h: Fix the __setup_param() macro for module build To: Anson Huang X-Provags-ID: V03:K1:B+XYrtFkSXoe3ACFcL1+Pkh+7pz9l8/ILi39OM0EO5GD+RL08wD czDx8vfAJFqCBmjWJHxUa0hhAZe/jA2aSeXGkTOp6FCc/xuwqaCE5MQvuwQfmiAxGRlj5oz z4x/oLP+xzv4NqtE39d143y4ZGA+iejWApcSrCCNVaTo+ZrR5K5/iSvRDryzNmR97FPBoiM Gs+k+LM386Ok7arGYtQgg== X-UI-Out-Filterresults: notjunk:1;V03:K0:A1oIR+AHWiQ=:07fqLNSVGNRmFlTjNgGRMA NH1aA+7aSqo7PqOPxi+7gC/LwbfNeURw/WF68b4CgM3xoPFrpz/YBz671OKfa1fZWE+tzLOFE P5ZaNYRS3emPWwlELtyRz4/eQE5rZSxdMXFMQRGRPvy00i9YrPSK0v7R3a0+2Xx3G2A75/Xfi k6DssW/37xWJFMyICIOXMtbh2hJRV0ljuay9jKHY8xoEhGgnUE6wCAyEeiYeTjO/SmSBbBmQh lEtPdBaCwlG99t4uWbN8wTJRCfZupD0oHKekwjG6iazrTkhnBEbiyUlj13C4AdY2fJLWMRoYH 27quqx6tBofw/83Yhk5EfbdJ4FvRbBE4+iKcbqfz/ppbxIU7eStryrPZokZPnRUEk4KH6xoLA 9/ovDGUfokfbu16ZjWgixjz00vdvd+vYutPFOGQXV480/zj3B8nyjPuTvYk3/XlYGyE+g+yVz 1HpaDxvATdjLiu78Us7F4tsDjH8XD1GZzum8nX8c0XVBwz+tnOSNEGJBUvzkaIOqnMg/o2LP1 jtibupagfkxoSJErszqtClvQU55bHTriUTRX6gItr/b56KbnT0ZM8fODSPeaI8birUNBvNU8R uehUuVxJLgXpdcHQFMFRYGZCu1Yg7FYI6HJD8YBE776PwXEVFPCUV3HRu+wVWThLI6NthZSue kkss3wX1lIvtvPv06cn1vYY1e5/lYUl5A024HxRtRwgoEdrZ8qJtNRb9ctpFST1qULKnOFeFm qQUQ0Bkxy/HeMCuGxHzZAHLEJITIpvAmzVAF/nQtmCwicpCaf7hGY8yFt7CIObZNFjqKsqDaf 4B6pW6ANpog/ripdXHmbWLcfe0rC3AC5FhsbvRgjz/CnqAmwVk= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_061404_601388_387AB597 X-CRM114-Status: GOOD ( 18.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , Stephen Rothwell , Peng Fan , linux-clk , Andy Duan , Abel Vesa , Stefan Agner , Stephen Boyd , Shawn Guo , Sascha Hauer , YueHaibing , Russell King - ARM Linux , Daniel Baluta , "linux-kernel@vger.kernel.org" , "oleksandr.suvorov@toradex.com" , Al Viro , Sascha Hauer , Fabio Estevam , Michael Turquette , Linux ARM , dl-linux-imx Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 1, 2020 at 12:02 PM Anson Huang wrote: > > Subject: Re: [PATCH V3 02/10] init.h: Fix the __setup_param() macro for > > module build > > On Wed, Jul 1, 2020 at 11:27 AM Anson Huang > > wrote: > > > > Subject: Re: [PATCH V3 02/10] init.h: Fix the __setup_param() macro > > > > for module build > > Why not move this all to a separate file then and only build it when > > CONFIG_CLK_IMX=y? > > It seems that you don't need the imx_keep_uart_clocks_param() if the clk > > driver is loaded as a module, but then you also don't need the > > imx_clk_disable_uart() and imx_register_uart_clocks() functions or the > > associated variables. > > If so, how about just adding "#ifndef MODULE" check for this part of code? I think > it should be easier/better than adding a file and build it conditionally? The #ifdef is clearly a simpler change, but I think a separate file is a cleaner way to do it. Up to you (unless one of the imx or clk maintainers has a preference -- I'm only helping out here, not making decisions). Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel