From: Arnd Bergmann <arnd@arndb.de>
To: Michal Simek <monstr@monstr.eu>
Cc: SoC Team <soc@kernel.org>, arm-soc <arm@kernel.org>,
Rajan Vaja <rajan.vaja@xilinx.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [GIT PULL] ARM: soc: Xilinx SOC changes for v5.9
Date: Fri, 31 Jul 2020 10:27:09 +0200 [thread overview]
Message-ID: <CAK8P3a2LeoV40Vyd=VYL+MFxkr_5i53NtsqADkq=Y54DEbzZkA@mail.gmail.com> (raw)
In-Reply-To: <bb8884e4-ef88-90cc-5ab6-0af639452696@monstr.eu>
On Thu, Jul 30, 2020 at 7:39 AM Michal Simek <monstr@monstr.eu> wrote:
>
> Rajan Vaja (1):
> drivers: soc: xilinx: Call InitFinalize from late_initcall_sync instead of probe
I looked at the contents and decided not to pull this one branch, as it looks
like this patch would introduce a regression on all non-zynq machines.
Rajan, please check this patch again and make sure that we do not
call a zynq specific interface without ensuring that the kernel is actually
running on zynq. That check might be there, but I could not see how it
is ensured. Generally speaking, initcall() needs be used very carefully.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-31 8:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 5:39 [GIT PULL] ARM: soc: Xilinx SOC changes for v5.9 Michal Simek
2020-07-31 8:27 ` Arnd Bergmann [this message]
2020-07-31 8:48 ` Rajan Vaja
2020-07-31 9:26 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a2LeoV40Vyd=VYL+MFxkr_5i53NtsqADkq=Y54DEbzZkA@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=arm@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=monstr@monstr.eu \
--cc=rajan.vaja@xilinx.com \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).