From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60CF0C04AB6 for ; Fri, 31 May 2019 08:54:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36A5825D30 for ; Fri, 31 May 2019 08:54:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TreFm8Nk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36A5825D30 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7r6qGSRgvLz3siB/62nsJehsiQP+yOWMjKA+rJBCPrk=; b=TreFm8NkK7K8uh OBGKH0VMbXNwodXsGwghyXS4yujuI6lC4GSS/WojhjSa1+XVt2xZ0z6MEJAYiCTBhiI2HRAbZJPAL p6k6zw36+tzuQZRMZTuczIB2SnhdPsKGyx6lJCY8PyGeVP/5xQjdmTEVfG4zsNwFNSh0ncKZQ/Sfx vgmsLHvuq27iJelsWv+IuxV5++as0ZJU1xUtBfXeaICvi4xik1UyQy5u6n7maL3WL3wS6frqBsZPK qb04DfzFJi1fE844sa4fZMYDw4IZkPtnuHnkXDfTUIIJnI5BXZwc2UQCpXVHGdZujVeCliDy30mu8 +9Qc3S/G7KlstWndY2xQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWdIV-0001Fr-Fv; Fri, 31 May 2019 08:53:59 +0000 Received: from mail-qt1-f195.google.com ([209.85.160.195]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWdIS-0001FC-Q6 for linux-arm-kernel@lists.infradead.org; Fri, 31 May 2019 08:53:58 +0000 Received: by mail-qt1-f195.google.com with SMTP id y57so10472455qtk.4 for ; Fri, 31 May 2019 01:53:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PLETH2OB3IxfKN1eggOuRioC9EOnLLXN9MFUnFFew5s=; b=nqoXu3AEWtDjhyhvDXmQQZiNePT04KNXflx7aIJ9f/4N+IeUEsMK7JHGvoQvv0EMFT Tuu64P96AFfODH+Pj/8nQ4dJwTc+m8Umkw0S4QJaiT0Yw7k0kAFhzq1W77nzQcwPPhbK MJjuFPRdWtR3aoknnBXJnrXY01pFP9vUPf6xTXr+0ahAXRmDI05sWqSpDTQE7t0gRn1Z +Ywb/VEpo1+un6kAqQElksoGVOIC+eDGNjzV2iILx9nfYdpGvK8FUv/VTzS1cHBdABB0 IjUF6mq8ZV9zct0JCol8j3ZlPpqqTfIH/egqJfdaIxhTTD68VmWRD+1TJFy+ZXNpPrkU j+Dw== X-Gm-Message-State: APjAAAU/puz6hMfEQSUVHDbmtKdccC3hOTkc/dQ+B5N768UZxoht4PSr viTaUHw4w7hNFiQ9pVbjZ8SY2FPNzg3lx7Wgrbo= X-Google-Smtp-Source: APXvYqzU7iWArqELb2azzCaYfon35mBi7acUgoO6bIp937zY6y9ykUj3bD/yvsjRGY3UDM715ORpT4Efor58s/vfKbs= X-Received: by 2002:a0c:9e0f:: with SMTP id p15mr7638581qve.176.1559292835687; Fri, 31 May 2019 01:53:55 -0700 (PDT) MIME-Version: 1.0 References: <20190530141531.43462-1-vincenzo.frascino@arm.com> <20190530141531.43462-20-vincenzo.frascino@arm.com> In-Reply-To: <20190530141531.43462-20-vincenzo.frascino@arm.com> From: Arnd Bergmann Date: Fri, 31 May 2019 10:53:39 +0200 Message-ID: Subject: Re: [PATCH v6 19/19] kselftest: Extend vDSO selftest To: Vincenzo Frascino X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190531_015356_843446_34652457 X-CRM114-Status: GOOD ( 12.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , Shuah Khan , Dmitry Safonov <0x7f454c46@gmail.com>, Huw Davies , Catalin Marinas , Daniel Lezcano , Will Deacon , Linux Kernel Mailing List , Ralf Baechle , linux-mips@vger.kernel.org, Paul Burton , "open list:KERNEL SELFTEST FRAMEWORK" , Rasmus Villemoes , Russell King , Thomas Gleixner , Mark Salyzyn , Peter Collingbourne , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 30, 2019 at 4:16 PM Vincenzo Frascino wrote: > +/* > + * ARM64's vDSO exports its vDSO implementation with different names and > + * a different version from other architectures, so we need to handle it > + * as a special case. > + */ > +#if defined(__aarch64__) > +const char *version = "LINUX_2.6.39"; > +const char *name[4] = { > + "__kernel_gettimeofday", > + "__kernel_clock_gettime", > + "__kernel_time", > + "__kernel_clock_getres", > +}; > +#else > +/* Tested on x86, arm, mips */ > +const char *version = "LINUX_2.6"; > +const char *name[4] = { > + "__vdso_gettimeofday", > + "__vdso_clock_gettime", > + "__vdso_time", > + "__vdso_clock_getres", > +}; > +#endif I see the __kernel_* name used on arm64, powerpc and s390, whiel the __vdso_* name is used on arm, mips, nds32, riscv, sparc, and x86. Also the versions have more variants: $ git ls-files arch | grep vdso | xargs grep '\(LINUX_[2345]\|VDSO_VERSION_STRING\)' arch/arm/vdso/vdso.lds.S: LINUX_2.6 { arch/arm64/kernel/vdso/vdso.lds.S: LINUX_2.6.39 { arch/mips/vdso/vdso.lds.S: LINUX_2.6 { arch/nds32/kernel/vdso/vdso.lds.S: LINUX_4 { arch/powerpc/include/asm/vdso.h:#define VDSO_VERSION_STRING LINUX_2.6.15 arch/powerpc/kernel/vdso32/vdso32.lds.S: VDSO_VERSION_STRING { arch/powerpc/kernel/vdso64/vdso64.lds.S: VDSO_VERSION_STRING { arch/riscv/kernel/vdso/vdso.lds.S: LINUX_4.15 { arch/s390/include/asm/vdso.h:#define VDSO_VERSION_STRING LINUX_2.6.29 arch/s390/kernel/vdso32/vdso32.lds.S: VDSO_VERSION_STRING { arch/s390/kernel/vdso64/vdso64.lds.S: VDSO_VERSION_STRING { arch/sparc/vdso/vdso.lds.S: LINUX_2.6 { arch/sparc/vdso/vdso32/vdso32.lds.S: LINUX_2.6 { arch/x86/entry/vdso/vdso.lds.S: LINUX_2.6 { arch/x86/entry/vdso/vdso32/vdso32.lds.S: LINUX_2.6 { arch/x86/entry/vdso/vdso32/vdso32.lds.S: LINUX_2.5 { arch/x86/entry/vdso/vdsox32.lds.S: LINUX_2.6 { arch/x86/um/vdso/vdso.lds.S: LINUX_2.6 { Maybe change the test case to just try all combinations of the above (and __vdso_clock_gettime64 as well) and stop checking the architecture? Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel