From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Tero Kristo <t-kristo@ti.com>
Cc: "open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
linux-omap@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 07/10] crypto: omap-aes-gcm: fix corner case with only auth data
Date: Sat, 26 Oct 2019 17:04:05 +0200 [thread overview]
Message-ID: <CAKv+Gu-4j3yUT7ekPukj1t50WXuNBb+XwwCqP7qHCkH_ZE9ipw@mail.gmail.com> (raw)
In-Reply-To: <20191017122549.4634-8-t-kristo@ti.com>
On Thu, 17 Oct 2019 at 14:26, Tero Kristo <t-kristo@ti.com> wrote:
>
> Fix a corner case where only authdata is generated, without any provided
> assocdata / cryptdata. Passing the empty scatterlists to OMAP AES core driver
> in this case would confuse it, failing to map DMAs.
>
So this change appears to be the culprit for causing the remaining
issue that I reported in the cover letter of the followup series that
I sent out.
The logic below does not account for the case where only assocdata is
provided, which is a valid use of an AEAD.
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> ---
> drivers/crypto/omap-aes-gcm.c | 22 ++++++++++++++--------
> 1 file changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/crypto/omap-aes-gcm.c b/drivers/crypto/omap-aes-gcm.c
> index 9bbedbccfadf..dfd4d1cac421 100644
> --- a/drivers/crypto/omap-aes-gcm.c
> +++ b/drivers/crypto/omap-aes-gcm.c
> @@ -148,12 +148,14 @@ static int omap_aes_gcm_copy_buffers(struct omap_aes_dev *dd,
> if (req->src == req->dst || dd->out_sg == sg_arr)
> flags |= OMAP_CRYPTO_FORCE_COPY;
>
> - ret = omap_crypto_align_sg(&dd->out_sg, cryptlen,
> - AES_BLOCK_SIZE, &dd->out_sgl,
> - flags,
> - FLAGS_OUT_DATA_ST_SHIFT, &dd->flags);
> - if (ret)
> - return ret;
> + if (cryptlen) {
> + ret = omap_crypto_align_sg(&dd->out_sg, cryptlen,
> + AES_BLOCK_SIZE, &dd->out_sgl,
> + flags,
> + FLAGS_OUT_DATA_ST_SHIFT, &dd->flags);
> + if (ret)
> + return ret;
> + }
>
> dd->in_sg_len = sg_nents_for_len(dd->in_sg, alen + clen);
> dd->out_sg_len = sg_nents_for_len(dd->out_sg, clen);
> @@ -287,8 +289,12 @@ static int omap_aes_gcm_handle_queue(struct omap_aes_dev *dd,
> return err;
>
> err = omap_aes_write_ctrl(dd);
> - if (!err)
> - err = omap_aes_crypt_dma_start(dd);
> + if (!err) {
> + if (dd->in_sg_len && dd->out_sg_len)
> + err = omap_aes_crypt_dma_start(dd);
> + else
> + omap_aes_gcm_dma_out_callback(dd);
> + }
>
> if (err) {
> omap_aes_gcm_finish_req(dd, err);
> --
> 2.17.1
>
> --
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-26 15:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 12:25 [PATCH 00/10] crypto: omap fixes towards 5.5 Tero Kristo
2019-10-17 12:25 ` [PATCH 01/10] crypto: omap-sham: split up data to multiple sg elements with huge data Tero Kristo
2019-10-17 12:25 ` [PATCH 02/10] crypto: omap-sham: remove the sysfs group during driver removal Tero Kristo
2019-10-17 12:25 ` [PATCH 03/10] crypto: omap-aes: " Tero Kristo
2019-10-17 12:25 ` [PATCH 04/10] crypto: omap-des: add IV output handling Tero Kristo
2019-10-17 12:25 ` [PATCH 05/10] crypto: omap-aes: " Tero Kristo
2019-10-17 12:25 ` [PATCH 06/10] crypto: omap-sham: fix buffer handling for split test cases Tero Kristo
2019-10-17 12:25 ` [PATCH 07/10] crypto: omap-aes-gcm: fix corner case with only auth data Tero Kristo
2019-10-26 15:04 ` Ard Biesheuvel [this message]
2019-10-17 12:25 ` [PATCH 08/10] crypto: omap-sham: fix split update cases with cryptomgr tests Tero Kristo
2019-10-17 12:25 ` [PATCH 09/10] crypto: add timeout to crypto_wait_req Tero Kristo
2019-11-05 17:42 ` Eric Biggers
2019-11-06 6:39 ` Gilad Ben-Yossef
2019-11-06 7:25 ` Tero Kristo
2019-11-06 7:33 ` Gilad Ben-Yossef
2019-11-08 2:27 ` Eric Biggers
2019-11-08 7:40 ` Tero Kristo
2019-11-08 9:16 ` Herbert Xu
2019-11-08 9:22 ` Tero Kristo
2019-11-09 2:27 ` Eric Biggers
2019-11-09 5:01 ` Herbert Xu
2019-10-17 12:25 ` [PATCH 10/10] crypto: omap-aes: fixup aligned data cleanup Tero Kristo
2019-10-25 11:33 ` [PATCH 00/10] crypto: omap fixes towards 5.5 Ard Biesheuvel
2019-10-25 11:55 ` Tero Kristo
2019-10-25 11:56 ` Tero Kristo
2019-10-25 12:05 ` Ard Biesheuvel
2019-10-25 12:18 ` Tero Kristo
2019-10-26 15:06 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu-4j3yUT7ekPukj1t50WXuNBb+XwwCqP7qHCkH_ZE9ipw@mail.gmail.com \
--to=ard.biesheuvel@linaro.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).