From: Peter Robinson <pbrobinson@gmail.com>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: devel@driverdev.osuosl.org, tiwai@suse.de,
gregkh@linuxfoundation.org, mikebrady@eircom.net,
Eric Anholt <eric@anholt.net>,
linux-rpi-kernel@lists.infradead.org,
Dave Stevenson <dave.stevenson@raspberrypi.org>,
nsaenzjulienne@suse.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC 02/11] staging: bcm2835-camera: fix module autoloading
Date: Wed, 19 Dec 2018 07:54:30 +0000 [thread overview]
Message-ID: <CALeDE9McktTeHDpAuQJt_rYKJuDvHRXObEd9aStm=jXWhZZp-w@mail.gmail.com> (raw)
In-Reply-To: <1540481375-15952-3-git-send-email-stefan.wahren@i2se.com>
On Thu, Oct 25, 2018 at 4:30 PM Stefan Wahren <stefan.wahren@i2se.com> wrote:
>
> In order to make the module bcm2835-camera load automatically, we need to
> add a module alias.
>
> Fixes: 4bebb0312ea9 ("staging/bcm2835-camera: Set ourselves up as a platform driver.")
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: Peter Robinson <pbrobinson@gmail.com>
Tested-by: Peter Robinson <pbrobinson@gmail.com>
Tested with a v2 camera module and kernel module loads automatically
as expected.
> ---
> drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
> index d6fbef7..7d3222c 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
> +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
> @@ -47,6 +47,7 @@ MODULE_DESCRIPTION("Broadcom 2835 MMAL video capture");
> MODULE_AUTHOR("Vincent Sanders");
> MODULE_LICENSE("GPL");
> MODULE_VERSION(BM2835_MMAL_VERSION);
> +MODULE_ALIAS("platform:bcm2835-camera");
>
> int bcm2835_v4l2_debug;
> module_param_named(debug, bcm2835_v4l2_debug, int, 0644);
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-19 7:55 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 15:29 [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload Stefan Wahren
2018-10-25 15:29 ` [PATCH RFC 01/11] staging: bcm2835-camera: Abort probe if there is no camera Stefan Wahren
2018-12-19 8:07 ` Peter Robinson
2018-10-25 15:29 ` [PATCH RFC 02/11] staging: bcm2835-camera: fix module autoloading Stefan Wahren
2018-12-19 7:54 ` Peter Robinson [this message]
2018-10-25 15:29 ` [PATCH RFC 03/11] staging: bcm2835-camera: Move module info to the end Stefan Wahren
2018-12-19 7:53 ` Peter Robinson
2018-10-25 15:29 ` [PATCH RFC 04/11] staging: vchiq_arm: Fix platform device unregistration Stefan Wahren
2018-10-26 8:07 ` Dan Carpenter
2018-10-25 15:29 ` [PATCH RFC 05/11] staging: vchiq_arm: Fix camera device registration Stefan Wahren
2018-10-25 15:29 ` [PATCH RFC 06/11] staging: vchiq_arm: Register a platform device for audio Stefan Wahren
2018-10-26 8:09 ` Dan Carpenter
2018-10-26 8:18 ` Dan Carpenter
2018-10-25 15:29 ` [PATCH RFC 07/11] staging: bcm2835-audio: Enable compile test Stefan Wahren
2018-10-25 15:29 ` [PATCH RFC 08/11] staging: bcm2835-audio: use module_platform_driver() macro Stefan Wahren
2018-10-25 15:29 ` [PATCH RFX 09/11] staging: bcm2835-audio: Drop DT dependency Stefan Wahren
2018-10-25 15:29 ` [PATCH RFC 10/11] staging: bcm2835-camera: Provide more specific probe error messages Stefan Wahren
2018-10-25 15:29 ` [PATCH RFC 11/11] staging: bcm2835-camera: Add hint about possible faulty config Stefan Wahren
2018-10-26 10:55 ` Nicolas Saenz Julienne
2018-10-26 11:06 ` [PATCH RFC 00/11] staging: vc04_services: Improve driver load/unload Nicolas Saenz Julienne
2018-10-28 20:10 ` Stefan Wahren
2019-01-08 7:21 ` Peter Robinson
2019-01-08 8:48 ` Stefan Wahren
2019-01-08 8:56 ` Peter Robinson
2019-01-08 10:20 ` Stefan Wahren
2019-01-10 5:09 ` Peter Robinson
2019-01-10 6:24 ` Stefan Wahren
2019-01-10 6:34 ` Peter Robinson
2019-01-10 18:48 ` Stefan Wahren
2019-01-11 6:10 ` Peter Robinson
2019-01-11 16:43 ` Dave Stevenson
2019-01-12 5:26 ` Peter Robinson
2019-01-10 7:05 ` Peter Robinson
2019-01-08 17:10 ` Dave Stevenson
2019-01-09 8:33 ` Stefan Wahren
2019-01-09 11:58 ` Nicolas Saenz Julienne
2019-01-10 5:22 ` Peter Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALeDE9McktTeHDpAuQJt_rYKJuDvHRXObEd9aStm=jXWhZZp-w@mail.gmail.com' \
--to=pbrobinson@gmail.com \
--cc=dave.stevenson@raspberrypi.org \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mikebrady@eircom.net \
--cc=nsaenzjulienne@suse.de \
--cc=stefan.wahren@i2se.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).