From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76CD6C43381 for ; Mon, 18 Mar 2019 16:58:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49B2820863 for ; Mon, 18 Mar 2019 16:58:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="W2ZVkZG1"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="mZdIOVyI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49B2820863 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=91mJpuKWARd1WHBQQOkCJtlPki5awLRfwfgdNY5m+mo=; b=W2ZVkZG1YWS6hS jCchQb9Ef7ST7RgvaLA9hNnBNrw4HgnN4FHFEccbpAXycdZG4tv8ooHNHPl3rp7fCjeZNiNHVJHCC Q7oplcQY18cMFZtRR7RJNqasjzpumgFe5Mj27M3ojWejxcd7GIL0Hs8TOBm2/gn1tiHfq6rBv0yQM B0KT84RcI/oYU/lIho9SY+PDTtkOThTwqqZjpOJTd5MKV8+glfMapbtImoCZH8d4FJHbibWzbutqs 7Nwzx4NfEdUN2HctYtVuiyttnA2Wpru0lNrNVpI9/CtArzKof6bK8FnPrVncnyAvgtFcbHuE6Vr9k DYOAYDyWlN5hnF1kCG4Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5val-0000Wd-2E; Mon, 18 Mar 2019 16:58:27 +0000 Received: from mail-it1-x142.google.com ([2607:f8b0:4864:20::142]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5vah-0000WC-JB for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2019 16:58:24 +0000 Received: by mail-it1-x142.google.com with SMTP id l15so22425809iti.4 for ; Mon, 18 Mar 2019 09:58:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=timxIiuZ6C5qXFE9PGZ2nUTtUi+iw25UcWJsW0Veig0=; b=mZdIOVyIRzqr8nvsAQGZKbjCIA0qKeZookwiMc+1aWtmDD/qot3TPqxL67NY653tcf JS6eJANN1oPYsvP1OzWukNP+19gLzc5pPixehx0gQJsoVxk4BlPCOsWthUu6wBEDd6aP 2B05SOS4UwEuk7D97WUsbiLuXs2K/NOjX+NOM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=timxIiuZ6C5qXFE9PGZ2nUTtUi+iw25UcWJsW0Veig0=; b=pSRrP5Wr37G47XG/hu1soNeU/pp9fpdY/khfnyW77FuM443L/t6w4qpMzSrmqZVlLD 7xJuxUEyTypiGvDN8r5TRRjhBoFUnY3ST2K5Q+AJlFsOeov8JF3x25T+fPYS5kuLgmVy Z+PY4G6tkhBZHq32GVxRYZ3PIfvaz6cgBGBWv6/vmg7E6O/vl2QEvKolVGkRKWgF5YCk kOKS9fsdpF3SBa6CUBzyYKKzwSL6mzzMfPeNPV0eRBwXh4rzSwoNUwi5wp0wszgg6h9T ZlUxAFUfrS93eEMPE5OBthmOOHsmnwEFoWesZxM0c9eTSNy8P3n5OPgcSNomCGGjaNRx 8W4w== X-Gm-Message-State: APjAAAUWyjlm3luYGphL1BM8oZ4ZzcHkTgsSIy5B2MvlGecH1cGZQ0bC MHGAuK5/x3MGK2DAePt58NNdkj3J3JbDZ13p5dfybQ== X-Google-Smtp-Source: APXvYqzOu0dIeGY9CvPAIgV/jvPre6u/O5i4VXqu/6iOchwtUidekLQTm1n2WCNK7JksE/hGLbuFl9AulVlgRy2maQY= X-Received: by 2002:a05:660c:252:: with SMTP id t18mr11519805itk.173.1552928301904; Mon, 18 Mar 2019 09:58:21 -0700 (PDT) MIME-Version: 1.0 References: <20190315130825.9005-1-jagan@amarulasolutions.com> <20190315130825.9005-5-jagan@amarulasolutions.com> <20190315133414.5zwc5qtrivrbrzow@flea> In-Reply-To: <20190315133414.5zwc5qtrivrbrzow@flea> From: Jagan Teki Date: Mon, 18 Mar 2019 22:28:10 +0530 Message-ID: Subject: Re: [PATCH 4/6] dt-bindings: display: bridge: Add ICN6211 MIPI-DSI to RGB convertor bridge To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190318_095823_634738_83A85E98 X-CRM114-Status: GOOD ( 20.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , David Airlie , linux-sunxi , linux-kernel , dri-devel , Andrzej Hajda , Chen-Yu Tsai , Rob Herring , Laurent Pinchart , Daniel Vetter , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 15, 2019 at 7:04 PM Maxime Ripard wrote: > > On Fri, Mar 15, 2019 at 06:38:23PM +0530, Jagan Teki wrote: > > ICN6211 is MIPI-DSI/RGB converter bridge from chipone. > > It has a flexible configuration of MIPI DSI signal input > > and produce RGB565, RGB666, RGB888 output format. > > > > Add dt-bingings for it. > > > > Signed-off-by: Jagan Teki > > --- > > .../display/bridge/chipone,icn6211.txt | 36 +++++++++++++++++++ > > 1 file changed, 36 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt > > new file mode 100644 > > index 000000000000..7f13efd7ee7f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.txt > > @@ -0,0 +1,36 @@ > > +Chipone ICN6211 MIPI-DSI to RGB Convertor Bridge > > + > > +ICN6211 is MIPI-DSI/RGB converter bridge from chipone. > > +It has a flexible configuration of MIPI DSI signal input > > +and produce RGB565, RGB666, RGB888 output format. > > + > > +Required properties for RGB: > > +- compatible: must be "chipone,icn6211" and one of: > > + * "bananapi,icn6211" > > Why is that compatible needed? chipone,icn6211 - generic compatible bridge controller IC bananapi,icn6211 - compatible for icn6211 bridge using on bananapi panel I hope this would be proper bindings in terms of controller IC with associate device, anything wrong? Infact I used similar reference from Ilitek Bananapi panel from here Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.txt This is what I understood based on dt-binding, correct if I'm wrong. ilitek,ili9881c - generic ilitek,ili9881c compatable bananapi,lhr050h41 - compatible for bananapi panel associated with this ilitek IC > > > +- reg: the virtual channel number of a DSI peripheral > > +- reset-gpios: a GPIO phandle for the reset pin > > + > > +The device node can contain following 'port' child nodes, > > +according to the OF graph bindings defined in [1]: > > + 0: DSI Input, not required, if the bridge is DSI controlled > > + 1: RGB Output, mandatory > > Your example doesn't have that input port Yes, I intentionally did this by referring existing bridge binding. Documentation/devicetree/bindings/display/bridge/toshiba,tc35876*.txt Do we really need? since the input port can be part of panel binding. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel