From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34AF3C31E5B for ; Mon, 17 Jun 2019 19:27:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDC9E2085A for ; Mon, 17 Jun 2019 19:27:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="p0W7PcjL"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jLrmxlt5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDC9E2085A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fugn4/wkfY2qYlpUSe8cxTu+p7vhfsTWqrN8zZYCyzk=; b=p0W7PcjLyFHD/Z fQMNXQXzRNQoxXM/8JMCN7N+ApORcn5zQmLqVcWHzYTMqdM3W1WS1FeXaZDDsOE78nNU1MbRahGaL 9G64k3iy1bwjknxBCwlOH00QifMhooejfw1rPigoMRUrI1NlDweCv0YbXSi2IS5iiAze+lbxLYhFb ras6/SVVfoNOhC9/dmwQBH+kqE/BFXnmSAC2yZTtupT4V1CmPcJ9P2/vmvrBpfkOvhapkz8Fz8guU 4ZBSbU0TmKeDUPttJsCdeBOtv1dPFlgtaDmXLSCOdgLvCnBPwYHfFHPaLqaKUYL+0rQ3atqC48DMV LNmLF5hj2Fsv2EftHH2w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hcxHy-0002Zy-U3; Mon, 17 Jun 2019 19:27:34 +0000 Received: from mail-io1-xd42.google.com ([2607:f8b0:4864:20::d42]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hcxHv-0002RL-SV for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2019 19:27:33 +0000 Received: by mail-io1-xd42.google.com with SMTP id u13so23983433iop.0 for ; Mon, 17 Jun 2019 12:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d9Oc7ZhRD3F3wXh7rQZIFZBIqOJRb70vgbqk6ZylyKs=; b=jLrmxlt5HekviTDg4h9uqSmRgH3b0TRYfXS0MLnsFWdqKx4w7TePcVbPdyGajBZ5T7 E0/MgkfLKKRFYdi4U/7cMNAC/5BD62ZV7jZDA3ZIlvdPLYG+lUq17VnbFRFmKcxBuijW b98VN0Hvx3L/bguKSJU68ZIk28pnHD1YfpnuGcqvMJVT80TFJybKvwSDGmg/WTMGyb5E MJajgGG46mMfU5JzBy1BUM19j9gCBKCe7x7XgYhEzhlzBEn1hybyqb59cTV/qpUDXiVo QB+ZGIrZuE5tY8P3wtvgueICm2JuGumEi96mvV4Ojoc6WIJs30xltebpiZh+JwiyMFDM ySEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d9Oc7ZhRD3F3wXh7rQZIFZBIqOJRb70vgbqk6ZylyKs=; b=MxqY9NmDkos1iVMWeQ+f3+nnCB8sBFi0Lq4eHc+QZ1x+VUzGag1QdGUSXTEDovUdUz 5YkzEWDVm1n+0Rh+KpIBvil0YTwpB6PoidDUvO4rKH3frGmtRKYexYLWFUuNWl5GQdwL IJWOe1bKfhQPhfY1ZVJHc3hq7WvsRIDnsYiqTk5fbZnkuS2bK4eVEsR9jWb4V6ieOsej JICzaR/zzL81WvjSZa1Py+2aFoOyIkuVs7YFLMDBfAppKXVsuR8yf1cxam3CNYmKprmM w78aIEFYthBKaIdC0FXz527C4zlApnbPiCY4jrLwZZ5poqYCnlEA1cc/Wv1FKrQ2Unmd TvbQ== X-Gm-Message-State: APjAAAXyaZTb19LW7stnUhxms9nIITUcH7d/BzC+xI4fBLQQv68M4J7W kV7ciR8XIUJeYD6uu7mctrubkkVNlkIWsm+PEBuSgA== X-Google-Smtp-Source: APXvYqwqAHJMpEIe+s+0XLSNvUalfFg//jHiamKU+Pa2/iD933a4OCsuMlXY4LBxYgwVV/deZOGHC6idGCgYYa5QioY= X-Received: by 2002:a5d:9613:: with SMTP id w19mr10341810iol.140.1560799650660; Mon, 17 Jun 2019 12:27:30 -0700 (PDT) MIME-Version: 1.0 References: <20190613065815.GF16334@mwanda> In-Reply-To: <20190613065815.GF16334@mwanda> From: Mathieu Poirier Date: Mon, 17 Jun 2019 13:27:19 -0600 Message-ID: Subject: Re: [PATCH] coresight: potential uninitialized variable in probe() To: Dan Carpenter X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190617_122731_940378_458A5EFB X-CRM114-Status: GOOD ( 14.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suzuki K Poulose , Alexander Shishkin , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List , Leo Yan , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 13 Jun 2019 at 00:59, Dan Carpenter wrote: > > The "drvdata->atclk" clock is optional, but if it gets set to an error > pointer then we're accidentally return an uninitialized variable instead > of success. > > Fixes: 78e6427b4e7b ("coresight: funnel: Support static funnel") > Signed-off-by: Dan Carpenter > --- > drivers/hwtracing/coresight/coresight-funnel.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c > index 5867fcb4503b..fa97cb9ab4f9 100644 > --- a/drivers/hwtracing/coresight/coresight-funnel.c > +++ b/drivers/hwtracing/coresight/coresight-funnel.c > @@ -244,6 +244,7 @@ static int funnel_probe(struct device *dev, struct resource *res) > } > > pm_runtime_put(dev); > + ret = 0; Applied - thanks. > > out_disable_clk: > if (ret && !IS_ERR_OR_NULL(drvdata->atclk)) > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel