From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65B0CC433E0 for ; Mon, 29 Jun 2020 13:11:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F7DB23D4D for ; Mon, 29 Jun 2020 13:11:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xCvxl0x4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pVTf/0go" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F7DB23D4D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u3lmxpPYyQw+6UYrNfpoe/iP6XMx5xamcYgHQl/XeAg=; b=xCvxl0x4ku7fhZodVOz91JpMc NqO1O5LTWfH8vHD+dWKGy0yw89fi/vwMpot7CVAgbCC/68t+UC59nHtf7e/gdnN5BCb/NAqTukQA6 iop0rRNYx070pIBIca1UrLvgdmGpqfxA7JTrInV3fEHec9T7z8YYj43DJp3rwamvqgOKjikG32Lf9 256wrp+pTSUz9tO1+SoSV0MPfMCvATFBMgDQCpNpEkk5PvM2EOt+i/kVd8j2Mj7j57GH5sAJjpf7r 72ffLO2XFl8TVbPmlqTQZfYgzRDzjTZ7D4Q9RO3iuK9Uj8RndsIla6VQSeOIPJvfNzZd2zwxzKk0F v2juX+u0g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jptYA-0006Db-FQ; Mon, 29 Jun 2020 13:10:18 +0000 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jptY6-0006Cj-Np for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 13:10:15 +0000 Received: by mail-lf1-x144.google.com with SMTP id g2so9058311lfb.0 for ; Mon, 29 Jun 2020 06:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jr1nek3J8zYrEJUnEDGgWevLtl77KOHWAeMwQjMSDdA=; b=pVTf/0go2c42RtZJAsf+7SPFbpXnMlAHaciCTkREVPwihX8fWC2JlSPaEQKBQ/aAJN 5SxsxtgI7FpQUeWLyU1wFDJ2vB0FNaxbrWABYoO26pAL5FpLYvlJE1q3MiQxgjgLGprm xlVWz43m6SWWCSyxCgCvNZtM+U813ehNZ4XALmQxInpS92F4SOVSKTjitku0R8wLOIJq LZmOqql2/CeZZsaggx9uhv7Cew+YebAMKjAeHsa31HD+lfwU9Yi037GVUJm5AVDIsuOO iyHJiCvI3ThpVB7bZlBW4QbASTz/1TVYbD7cR5AGWVM/lTuMOMvDCAt5TRzl5AcxePgW wUmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jr1nek3J8zYrEJUnEDGgWevLtl77KOHWAeMwQjMSDdA=; b=tK0dpxNPN6cqkMAysxkzr+KfsPmh0JJN3l5HonaXcNE1yUczhor0ZnRR9L2e+TawYD uyWFaR53fqIkmmpvcb6tjQWBJryJnEVRFzGdEPqvOmvI0iIsp4rZBXs5y/uuNVtVZzNI OAHGypTx5ezImZExDUJUW2MVct/HCaRfBkwkVv1ceJ6ljg5ldA4RmnDB0Go/vucTpZfv hpWOGlCb6lyLLY+CjIytsKCY5X4S9EVVCAE6h/lMkmrtEao8aYR4UUHLm/Ahp2Qb6x/5 66VEcZBG/dn1tD0DfsogtU033xkWGxtXcHnFm+V7BqgnKzlzVB+pTnSoiqtC3nck/FYi mNDQ== X-Gm-Message-State: AOAM533qgR9b9i2WTLMhCQGJ971mywbGVuy9Wm3T0gI+9ColSJ2kvclI Xj7bCHn1EUMF7wB6nVBkTOSRNXiMUdY9Xg1JRZY= X-Google-Smtp-Source: ABdhPJyKMYwlzKGDBLGeTXdwuk1wi968jDSKqlLN+LMTU4fHTuq8QJ42iNtJ48JBSb8Ib4KKwpybB4wm3thHbkt4iFU= X-Received: by 2002:ac2:5f04:: with SMTP id 4mr9051681lfq.140.1593436211359; Mon, 29 Jun 2020 06:10:11 -0700 (PDT) MIME-Version: 1.0 References: <20200625140105.14999-1-TheSven73@gmail.com> <20200625140105.14999-2-TheSven73@gmail.com> In-Reply-To: <20200625140105.14999-2-TheSven73@gmail.com> From: Fabio Estevam Date: Mon, 29 Jun 2020 10:09:59 -0300 Message-ID: Subject: Re: [PATCH v4 2/2] ARM: imx6plus: enable internal routing of clk_enet_ref where possible To: Sven Van Asbroeck X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fugang Duan , Sascha Hauer , linux-kernel , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sven, On Thu, Jun 25, 2020 at 11:01 AM Sven Van Asbroeck wrote: > > On imx6, the ethernet reference clock (clk_enet_ref) can be generated > by either the imx6, or an external source (e.g. an oscillator or the > PHY). When generated by the imx6, the clock source (from ANATOP) > must be routed to the input of clk_enet_ref via two pads on the SoC, > typically via a dedicated track on the PCB. > > On an imx6 plus however, there is a new setting which enables this > clock to be routed internally on the SoC, from its ANATOP clock > source, straight to clk_enet_ref, without having to go through > the SoC pads. > > Board designs where the clock is generated by the imx6 should not > be affected by routing the clock internally. Therefore on a plus, > we can enable internal routing by default. > > Signed-off-by: Sven Van Asbroeck I have tested this series on an imx6qp sabresd and unfortunately, it breaks Ethernet as I can no longer get an IP address from the DHCP server. Without this series, IP address can normally be retrieved. Therefore I suggest to create a device tree property for this feature and only enable it when such device tree property is present. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel