From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25075C4338F for ; Wed, 4 Aug 2021 11:27:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B180A60F6F for ; Wed, 4 Aug 2021 11:27:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B180A60F6F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i0NHnrhEn0vTsvtU156Iypsw75oYLxaKig2HWnL26PI=; b=XgRoi/F6UfHWvF EztmPDvLeQuOPuH8BLPxOdVAOvpkFj+0KtFG5+0nLvltRRIPCCQNv+HlOd3qpP/4c+pj812QeUxyS 7Fe5cFvG1Oufoqbv+RN9s1cLLiicxZAoVsHg8tNPTOi5JFnXwdN5d6iGmSrrAcbQ+jgm0VVlo5KwD OtTzIPGtIlKdQsweb4Go95vqL+GuL4lrKybhc13wssBjfsysWHPh76/HP+32M//XKFWpMrTctBY/z Lj+f4aPhLuQsNULz8WTHYHewW4QF2ZivwLoCvJVQQ63bTU13gXwLoZdiTFns223OjLa+pV9EUEF6L +BGsWjHYJ6GUvBufahvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBF1m-005srq-Vp; Wed, 04 Aug 2021 11:25:39 +0000 Received: from mail-vs1-xe2b.google.com ([2607:f8b0:4864:20::e2b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBF1i-005srM-U6 for linux-arm-kernel@lists.infradead.org; Wed, 04 Aug 2021 11:25:36 +0000 Received: by mail-vs1-xe2b.google.com with SMTP id e4so789845vsr.13 for ; Wed, 04 Aug 2021 04:25:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BRcASZ3r4m78SiEn9llZCC+xHa2OVesqEZ2kZNcyF+0=; b=R5Z8/Oydbv1DFgn8j2y86z75E7K0sgshC0AiuLpz/gXjctZZXH98alk93grLkC+3Yb ArE5iD44erF8OU1rN9zUSUYjtOV1CxMzrnO9UBK560P43Y0I5+vAv7wS6fn0Q25NLDHn XE98JEAWNsXf9e0jyyDj8c4kXptlXMPdmnABFMIT7kC1ZklVQ3x6ENHmzoLi+eok3rKA ChUJtFlanWvI4SGnSdBxpEOJIZuwCjgLtbaRTYIN6At0Eb65aVArjqMN0gW/3LAoeQIv Vu+6cBjo+nTXivlzHoACFPmbjg3ToMlHmDiaeAZHbJbW+xK123H+r+XWI12WZ23bmOcx b82Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BRcASZ3r4m78SiEn9llZCC+xHa2OVesqEZ2kZNcyF+0=; b=IIEpSlmRb2u5lSnARU6HnJsn3jsdVsIQ20ZyOUJudQ1dPA9/JoKnactMh/UbaF8qx0 GOmAaz2U/og94VJUA8qrxdNbPzc84MGw8lUAaLVWOqHYVc2ml16PqzWFbha7WZUIoVgG JOFSJf5ZRWZko3JNj8/KuQz2bMi4/Xy7xURcCAqxexbcB46dEPmphM1fEb1h2KzMzLVd Cc+s+6bHnYPCIRUHgNAyTwUeBBp1k7c0t23KUOQ84nmLb4fW21lBF3+SprT/7qL2jcw0 F+kEofZSwe0z3FjGkSHrWLuFbjHS2pVAwPZE+7NeHekIz8LKT2BFKs3dcUf95rcXm5rO ajjQ== X-Gm-Message-State: AOAM531TXnLytPGVPtk/Ljj1JjnLKrViyce9t0ioPFeBR3SvDB3r8VSn yZqO3MNS2IyRm7dxPWC7cnKfCxoBYRxAXHN5C80z+g== X-Google-Smtp-Source: ABdhPJwig6I24W8HDdZeZnOfWowvG1PB4luybcJODAJTfb7WUf1LZR2JsC2EWkttRkxulCzH4iNjnoVBAiBF7Gz/a58= X-Received: by 2002:a67:f6d8:: with SMTP id v24mr18645111vso.48.1628076333900; Wed, 04 Aug 2021 04:25:33 -0700 (PDT) MIME-Version: 1.0 References: <20210721140424.725744-1-maxime@cerno.tech> <20210721140424.725744-26-maxime@cerno.tech> <20210723215724.GA2661499@robh.at.kernel.org> In-Reply-To: <20210723215724.GA2661499@robh.at.kernel.org> From: Ulf Hansson Date: Wed, 4 Aug 2021 13:24:57 +0200 Message-ID: Subject: Re: [PATCH 25/54] dt-bindings: mmc: Convert MMC Card binding to a schema To: Rob Herring , Maxime Ripard Cc: Chen-Yu Tsai , Jernej Skrabec , DTML , Frank Rowand , Linux ARM , linux-sunxi , linux-mmc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210804_042535_023749_98930AED X-CRM114-Status: GOOD ( 30.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 23 Jul 2021 at 23:57, Rob Herring wrote: > > On Wed, Jul 21, 2021 at 04:03:55PM +0200, Maxime Ripard wrote: > > MMC Cards can have an optional Device Tree binding to add > > non-discoverable properties. > > > > Now that we have the DT validation in place, let's convert the device > > tree bindings for that driver over to a YAML schema. > > > > Some of these properties were already described in the MMC controller > > binding, even though they are not generic and do not apply to any > > device, so we took the occasion to fix this. > > > > Cc: linux-mmc@vger.kernel.org > > Cc: Ulf Hansson > > Signed-off-by: Maxime Ripard > > --- > > .../devicetree/bindings/mmc/mmc-card.txt | 30 ------------ > > .../devicetree/bindings/mmc/mmc-card.yaml | 48 +++++++++++++++++++ > > .../bindings/mmc/mmc-controller.yaml | 6 --- > > 3 files changed, 48 insertions(+), 36 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/mmc/mmc-card.txt > > create mode 100644 Documentation/devicetree/bindings/mmc/mmc-card.yaml > > > > diff --git a/Documentation/devicetree/bindings/mmc/mmc-card.txt b/Documentation/devicetree/bindings/mmc/mmc-card.txt > > deleted file mode 100644 > > index 8d2d71758907..000000000000 > > --- a/Documentation/devicetree/bindings/mmc/mmc-card.txt > > +++ /dev/null > > @@ -1,30 +0,0 @@ > > -mmc-card / eMMC bindings > > ------------------------- > > - > > -This documents describes the devicetree bindings for a mmc-host controller > > -child node describing a mmc-card / an eMMC, see "Use of Function subnodes" > > -in mmc.txt > > - > > -Required properties: > > --compatible : Must be "mmc-card" > > --reg : Must be <0> > > - > > -Optional properties: > > --broken-hpi : Use this to indicate that the mmc-card has a broken hpi > > - implementation, and that hpi should not be used > > - > > -Example: > > - > > -&mmc2 { > > - pinctrl-names = "default"; > > - pinctrl-0 = <&mmc2_pins_a>; > > - vmmc-supply = <®_vcc3v3>; > > - bus-width = <8>; > > - non-removable; > > - > > - mmccard: mmccard@0 { > > - reg = <0>; > > - compatible = "mmc-card"; > > - broken-hpi; > > - }; > > -}; > > diff --git a/Documentation/devicetree/bindings/mmc/mmc-card.yaml b/Documentation/devicetree/bindings/mmc/mmc-card.yaml > > new file mode 100644 > > index 000000000000..aefdd8748b72 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mmc/mmc-card.yaml > > @@ -0,0 +1,48 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/mmc/mmc-card.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: MMC Card / eMMC Generic Device Tree Bindings > > + > > +maintainers: > > + - Ulf Hansson > > + > > +description: | > > + This documents describes the devicetree bindings for a mmc-host controller > > + child node describing a mmc-card / an eMMC. > > + > > +properties: > > + compatible: > > + const: mmc-card > > + > > + reg: > > + const: 0 > > + > > + broken-hpi: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + Use this to indicate that the mmc-card has a broken hpi > > + implementation, and that hpi should not be used. > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: true > > Like what? If there's other properties, then there should really be a > specific compatible. I agree. Maxime, thanks for working on this. I assume you will be sending a new version that I can pick up? [...] Kind regards Uffe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel