From: Avri Altman <Avri.Altman@wdc.com>
To: Alim Akhtar <alim.akhtar@samsung.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Cc: "linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"krzk@kernel.org" <krzk@kernel.org>,
"kwmad.kim@samsung.com" <kwmad.kim@samsung.com>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v3 4/5] scsi: ufs-exynos: add UFS host support for Exynos SoCs
Date: Sun, 22 Mar 2020 12:24:17 +0000 [thread overview]
Message-ID: <SN6PR04MB46404847C78F62BA2D5CD2A0FCF30@SN6PR04MB4640.namprd04.prod.outlook.com> (raw)
In-Reply-To: <20200319150031.11024-5-alim.akhtar@samsung.com>
> +static int exynos7_ufs_pre_link(struct exynos_ufs *ufs)
> +{
> + struct ufs_hba *hba = ufs->hba;
> + u32 val = ufs->drv_data->uic_attr->pa_dbg_option_suite;
Can pa_dbg_option_suite be replaced by a macro?
> + exynos_ufs_disable_ov_tm(hba);
> +
> + ufshcd_dme_set(hba, UIC_ARG_MIB(PA_DBG_OPTION_SUITE_DYN),
> 0xf);
> + ufshcd_dme_set(hba, UIC_ARG_MIB(PA_DBG_OPTION_SUITE_DYN),
> 0xf);
A typo? Set PA_DBG_OPTION_SUITE_DYN twice?
> +#define PWR_MODE_STR_LEN 64
> +static int exynos_ufs_post_pwr_mode(struct ufs_hba *hba,
> + struct ufs_pa_layer_attr *pwr_max,
> + struct ufs_pa_layer_attr *pwr_req)
> +{
> + struct exynos_ufs *ufs = ufshcd_get_variant(hba);
> + struct phy *generic_phy = ufs->phy;
> + struct uic_pwr_mode *pwr = &ufs->pwr_act;
> + char pwr_str[PWR_MODE_STR_LEN] = "";
Un-needed complication IMO - all those snprintf that is.
> +
> +static void exynos_ufs_fit_aggr_timeout(struct exynos_ufs *ufs)
> +{
> + const u8 cntr_div = 40;
Can be replaced by a macro?
> +struct exynos_ufs_drv_data exynos_ufs_drvs = {
> +
> + .compatible = "samsung,exynos7-ufs",
> + .uic_attr = &exynos7_uic_attr,
> + .quirks = UFSHCD_QUIRK_PRDT_BYTE_GRAN |
> + UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR |
> + UFSHCI_QUIRK_BROKEN_HCE |
> + UFSHCI_QUIRK_SKIP_RESET_INTR_AGGR,
> + .opts = EXYNOS_UFS_OPT_HAS_APB_CLK_CTRL |
> + EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL |
> + EXYNOS_UFS_OPT_BROKEN_RX_SEL_IDX,
In what way opts are different from quirks?
Thanks,
Avri
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-22 12:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200319150701epcas5p4bb4365de0a0f4a4a6c7bc533e16d66ec@epcas5p4.samsung.com>
2020-03-19 15:00 ` [PATCH v3 0/5] exynos-ufs: Add support for UFS HCI Alim Akhtar
[not found] ` <CGME20200319150703epcas5p2d917898f6f1e0554cb978a70a34ee507@epcas5p2.samsung.com>
2020-03-19 15:00 ` [PATCH v3 1/5] dt-bindings: phy: Document Samsung UFS PHY bindings Alim Akhtar
2020-03-20 0:21 ` Rob Herring
2020-03-20 0:38 ` Alim Akhtar
[not found] ` <CGME20200319150705epcas5p4fd8301d8edf95454a3234a12a835d7ec@epcas5p4.samsung.com>
2020-03-19 15:00 ` [PATCH v3 2/5] phy: samsung-ufs: add UFS PHY driver for samsung SoC Alim Akhtar
2020-03-20 5:40 ` Kishon Vijay Abraham I
2020-03-20 11:46 ` Alim Akhtar
[not found] ` <CGME20200319150707epcas5p12cd31988fe8d11357519ddaee1b98ef9@epcas5p1.samsung.com>
2020-03-19 15:00 ` [PATCH v3 3/5] Documentation: devicetree: ufs: Add DT bindings for exynos UFS host controller Alim Akhtar
[not found] ` <CGME20200319150710epcas5p11411da0ec2d56b403b80a206ce38a92b@epcas5p1.samsung.com>
2020-03-19 15:00 ` [PATCH v3 4/5] scsi: ufs-exynos: add UFS host support for Exynos SoCs Alim Akhtar
2020-03-22 12:24 ` Avri Altman [this message]
2020-03-25 16:30 ` Alim Akhtar
[not found] ` <CGME20200319150712epcas5p24e99ea681e65e14cd2ca815b78ad0957@epcas5p2.samsung.com>
2020-03-19 15:00 ` [PATCH v3 5/5] arm64: dts: Add node for ufs exynos7 Alim Akhtar
2020-03-19 19:42 ` [PATCH v3 0/5] exynos-ufs: Add support for UFS HCI Paweł Chmiel
2020-03-20 14:10 ` Alim Akhtar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR04MB46404847C78F62BA2D5CD2A0FCF30@SN6PR04MB4640.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=cang@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=kwmad.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=robh+dt@kernel.org \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).