From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CEA4C433B4 for ; Fri, 14 May 2021 15:00:05 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 902FE61166 for ; Fri, 14 May 2021 15:00:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 902FE61166 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KMvniooRDIL8naUO2leVnEi1MknS4ZhWd11EQhVQHZs=; b=MrZ2nROZjMNJldj/DvCWmLZ8X SQwBmpdB2pvdY+qkp5/er1jw7kyXljTbgMc6ix/1ggHv5tPctGrZ77gHBisYdrcv2Ku5iVyOKjTAi MWayadKJbZ/dAJoBjD98VyVLrDkzSm6fx5Pi3/QuWWf3MuDwV9oIr0PWgpJsl4DQHuU4xwQiyednm 0kfgARlc2lW7jyO3CC1xer80uFZxbthIVuFP3VvUE7NCpuUmTuE4clpOPL61i94BZpvDyGlB1FC0w Rg9mijgMKKshumeJaf157fMRDFEPmu1yGJTEwrbkOpMQEfXjpkfYodPYaSanfhPKp8ipffK/I89sP JEPjrZZ2w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lhZFt-008Lp8-2D; Fri, 14 May 2021 14:57:33 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhZFr-008Loz-88 for linux-arm-kernel@desiato.infradead.org; Fri, 14 May 2021 14:57:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Message-ID:Date :Subject:CC:To:From:Sender:Reply-To:Content-ID:Content-Description; bh=85EbY+MRf/ys2Z1Vh3n5q3mh8vhCVgf6459Zo1NbUjU=; b=uPnWLcymHQ2RemXrhByAc1ODAZ 9CQs9PLxbJ07j5HSahsKsl/NxSiQncjutdnVIFA5HH/AcMzusI4qCW4iC5P2UEFxpoEe7ZFZsYqRO BWaQC9bew30c0HmR1dcIHgXHsAcDmuq/1obHFbXb7u/i7yAFRz6YCN37lc5Q9hK5K+w8KyV3w+YPv 5qb6u/KI2a3E9f8j6J5VkHFNGvSOkeog+Bbw0F0Y0S1NIOmSJjquRPmZLwNZvODCf1flxWpTnGoeb lzZJJXZfvmjEEYac1SzI6rwDQsK4JBtrzlTBcGSdKde4tZdojhuDjcCmRLJy9gJVSxpbPkuPt4HdQ T72dQrvw==; Received: from mail-eopbgr10053.outbound.protection.outlook.com ([40.107.1.53] helo=EUR02-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhZFo-00C40E-6h for linux-arm-kernel@lists.infradead.org; Fri, 14 May 2021 14:57:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k3OvmEJyj8h7jUCgnrq51Fc4mSiNIlS77zHH5nfU+08a1Jmlh/F3y8Zw3wbkKlXFsUN/+JjX2kUzWyHIp3rXIHb800k/gYh8JW92iRnomPVLa+BVvcovJc6XLIBq78kv0j9ISlzNKBwMkEpOUL2ki0iqQF3K8WDf44eqpDN7fy2v9/WQe8RK4XWQU000jFHWVgCYMMM1ub/WUTJWDmX+ftD5QSdk362EoKNE9H6TNnCNH/F9gWLG1Wu1vqKFhcUh0n0Z7+XHQhexTj6aLxT7LPdIm0sIqL2oZgMXrS/KreE2geuXYaifvH0ZvoO0ktBXtDPc4H2l7UBfHV3fW6mCcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=85EbY+MRf/ys2Z1Vh3n5q3mh8vhCVgf6459Zo1NbUjU=; b=I5d9TZkLaQDnE6gPjtay+ZqxBoEOzhfXox1ZPj2WQq1k1cQHmC9neLNbTU5akn11bfKFeFuhQ4VTJP0UDYS1PTQg5N/7p8Tfqo6b+d+aEBtXC7bpOfLiRxV9erjqE/HXzn1xcJYWBpF2DNt2azOFWilneVrTv7ABGbluQZClDWkT4bEcVPhwohwrQHuhhigUzirv1OYE+Wvwzj4cqo8tlqjpSR/1PwxbFrOciQit8EvTBujm2To5YnvsY/XEvkFe0+2/pRR9ZXH8d5Xlwl1v/A4UCTD3jEri9LKABZOdoUwDRzLZRz+hW4hHLY0Z8KxchqDeKEC2GKnl6ol1O4p0bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=85EbY+MRf/ys2Z1Vh3n5q3mh8vhCVgf6459Zo1NbUjU=; b=h9xlymgr4W5X8dHCD7pPBBiynx4/Ka91iUak2Dq7HDzieCvYgi5iU5+x02AmyvMaIvoxUi7+vDyRZPL9LmmkWPm4EpVIx9MOqmNE6G9/XtmOjP3lnkwQRko230TdzIW0+UjMi3IkBacUwlrYre6PF1AJqDuSwedqRwyBhBDvKnc= Received: from VE1PR04MB6688.eurprd04.prod.outlook.com (2603:10a6:803:127::25) by VI1PR04MB7022.eurprd04.prod.outlook.com (2603:10a6:800:126::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.28; Fri, 14 May 2021 14:57:24 +0000 Received: from VE1PR04MB6688.eurprd04.prod.outlook.com ([fe80::bcfe:215c:1b66:6011]) by VE1PR04MB6688.eurprd04.prod.outlook.com ([fe80::bcfe:215c:1b66:6011%4]) with mapi id 15.20.4129.026; Fri, 14 May 2021 14:57:24 +0000 From: Robin Gong To: Adam Ford CC: Shawn Guo , arm-soc , Rob Herring , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , dl-linux-imx , devicetree , Linux Kernel Mailing List Subject: RE: [PATCH 1/2] arm64: dts: imx8mn: Add spba1 bus Thread-Topic: [PATCH 1/2] arm64: dts: imx8mn: Add spba1 bus Thread-Index: AQHXKoTrm+1dEO4gCEi87d5cyZOFDqrdyocAgACF5YCAABIPoIAAMe4AgASmRGA= Date: Fri, 14 May 2021 14:57:24 +0000 Message-ID: References: <20210406013344.124255-1-aford173@gmail.com> <20210511024604.GE3425@dragon> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [183.192.233.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 61e158f9-06da-4464-c65c-08d916e8956b x-ms-traffictypediagnostic: VI1PR04MB7022: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SQ0bgI0P4+GMbj30d2LYoWLZO6oWuDETAblQtGts1YufZNarQNAucrkKP2SOPd94i/aRW30K+/Ci5Fqvk1YtcxoOxvhbeVe30P+SVxpgmtisLkILOptptRx86GxINqb53SKWy/59/HMA/UDy38bYaIb9+KO/sA2Y2w6SE0qIvyEddTUqRA7l3Ge2wY4XJjMV6JHqIliFNm9S2aTm+T4wCUqFftU+0vEmeS7/BmoefbegFMhzScGHNPqKVa08jZoBXj3boWlxv2s29/u/t2MNr3Aqy8x+3MkDj0ghULRSv6wUhYPdNAoEbhe+RbPqU96BrYhopLEj0UqDkSxe4KZegD1XOjF5ayJnoTfw6xUBqSIDv50zq9Opc9IQ9M0umZRq2yusJ+4dBOWqVxO8ZTDp0fDdWEPEHzoTNSD96cFgSsrFjEzcOEgK+3ERvA03L3OSP6yFM7nocx4wJNc7vN8Jiy/JZDSXgva0fEU+kXWUvjAdB9o8r8aJFGk+uU39qXW75D5BQOfFRWkk0YTfVeU531cAiXPd8LBBVt09xvb3ofmo2MxfAs9KDuxorDpQG8/R37ANhpkGlR/WH7OseV3ENBzouBeZoF41XffMecRALXP5BFtVXsDnrfwK0ptlui/T4pyAqNr++qnQPFWPJxPe9DNd2vCXojFZeYgaJHRqvgOtSxMY0AXctgphwJFt+hqKNJo9JQRQTg5QWIOoNqXC9Y1hCkJijdHH3I2Pp/kcFyQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6688.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(136003)(376002)(39850400004)(396003)(55016002)(54906003)(76116006)(4326008)(5660300002)(9686003)(71200400001)(316002)(6916009)(83380400001)(52536014)(8936002)(66446008)(64756008)(38100700002)(6506007)(53546011)(122000001)(8676002)(966005)(2906002)(478600001)(66556008)(66476007)(186003)(26005)(86362001)(66946007)(33656002)(7696005)(32563001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?SnhyRWQ5TCsxZS9MNHl4OGpnQmMxUmE0STFXNlBsTzNoT1Y1UXFxNFFERzhq?= =?utf-8?B?QVkzR2dNMnZ1LzhPL1BCNmlNc3l2M01MclQyenFSN1IwWEs2NzB2bFpSUjNW?= =?utf-8?B?VWQzRVkwSGxzMGxIV29IRUMvTmZmM2JlRFV4WFFQOTI1M1hRWTNVb3c1SUo1?= =?utf-8?B?SUdweW5sSVROTkd2aUtvVU04ME9kQTVHVzJhanBtWmRYSWFHS0VkRXVlbFZa?= =?utf-8?B?OTQvVlZMTFU1eUZQRE1Qc1hBemFuODlKQU9aakI3SEJpVUJPekNSSUZGWFJx?= =?utf-8?B?SlAyVFFDUCtRQU9wV24rMSszL3JEUzVmRHJrTDhWajVhaFRUcjZUSGUyZ3hj?= =?utf-8?B?Vy9qWjNvQjJud3RzdUNwSmJ3T2Nvdm5WTXlNS1JxQkIxWC9RdVR1Tm1iVnpn?= =?utf-8?B?eTFCUmdic1czejlJWHJmbzBoVTZoODVVTGVwRlNMSXd4d0o5TGVUYTJwZDlt?= =?utf-8?B?TUI5UllFVDFneENPaDUzT21BY0haQ2pGQy9LN3NoaFA3MUkyZWRJMEJWeWV2?= =?utf-8?B?UllGbHRmZGloZU00TmdzN2VWd21MSTZUVnZNSTNoYzJlOHdxV296K0ZsMDFh?= =?utf-8?B?dWt0VVY1UWNFSjA3U2V6UmFya0lNUXB6ZGxiUGtmVmlRUXVKQWJ2LytaVTZq?= =?utf-8?B?b0psakdvaFdueVNTTkcycTBIN0FNZUNlL2FUTDZJOGxHNFNwMUdjYVkvS1RP?= =?utf-8?B?S05SUms1dzBVTDQrcERYbHBMd1RvTFBWdWZTVUYvTXh1aXR1RDI1bVcxeWty?= =?utf-8?B?Y0pzVlJBSlNScFhVYmpic2hzWFk2eXB0U2dVM085U0RhQ3Z1N2p0OFFDeUNt?= =?utf-8?B?ZU1sRWRpU2h3WnBMaUplaGd3b0xYR0FwZFo2ZllqTlhycHJ5NFdIMWo3Vm05?= =?utf-8?B?dWNjZllsdjlNRjlTTUt1U21JSkFsYXJhbnJ2b1gzdnZSelIza1lZSU1tVEtj?= =?utf-8?B?d3ZhUHdwbFVpN2xxZndNZzdmYnB4OTZBWFFyeGFva2duU0VUVEpMcDVJQlJv?= =?utf-8?B?cFBtbHo4SDRXNS9iTHZqTEdhNkVtK0ttMTdnMVhLU3BEQ1JCektZdGErOHJD?= =?utf-8?B?V0JjZzQ0eVBZV0d1a3lOTUViSWYvU3VObmFMY0hySU5HNk5SSUp3cVVrNHBr?= =?utf-8?B?REtoOExTdkNFUEsyOE4vb1VXdHZhcXNCZi9CR3ZFV0pCYks0WHdWV285TG9J?= =?utf-8?B?RURJdW1CYTB2djc0MklUcGRWT3NNTlVvRHlXRnRxTm5hcytHU2Y5NGt4aXVC?= =?utf-8?B?NWo1cnJvMU1YLzl1VDdvbDdEQXZRNEtrZnFHUEM2N2dJMnVHWmhmeWJBbjJ0?= =?utf-8?B?Zk95TGtJcEFBS2Z4N3JWS3hZbHI4cU83SVd5UFRZbzNqU3RUb3FsV1dxei9j?= =?utf-8?B?eXVhZHRacjdVNXpDZU9KcHE1eEpvcXY1Ykl1ZjRUa0JISTZ1UzJtVm9nd043?= =?utf-8?B?ZTZKV0h6Y0d0NDhxYnRyZ3N2V01FM3YxbEVZU2ZBcDlST3VsNkZFRmFLNXRr?= =?utf-8?B?b1FPTHF4bFkwNTFNR0VyVTRDVGpXUDZYV0hicTJVeWlBaVdBM2k5WUZQM3NQ?= =?utf-8?B?b2NKWmE5cVZBMWMxZkZTTXlBVVFVcTZzN1lZczBYdXBnenhQWVUzbXZXTGtR?= =?utf-8?B?USt3UHhxUVprVGxZK1VMVU5GcDdrM3BhU2Z2ajRWZWQwWlFUdjEvSXpxR3I4?= =?utf-8?B?U3JiQ09VYklHVHBKd0RRR1NnQi9wOFZVYTJleHZiM3pjdjdRbG1WODJxM3ZV?= =?utf-8?Q?YayhSxxttU+3BCJql3Q/Hbn3poZDFOujeZ7jzmc?= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6688.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61e158f9-06da-4464-c65c-08d916e8956b X-MS-Exchange-CrossTenant-originalarrivaltime: 14 May 2021 14:57:24.3408 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oRLC73OIzyMiHxvfS0wbDsip9GEdsOLrcoJ6PwrOTi2IYcKPShf56tNnbco9NqEz5gQa66k4Rahr+1oXx2rvOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7022 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210514_075728_343716_B99C7300 X-CRM114-Status: GOOD ( 24.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/11/21 22:49 Adam Ford wrote: > > Compare PIO with DMA on UART, but not w/o this 'spba bus node ' patch? > > > > > In fact, if the DMA firmware isn't loaded, I often get transfer errors. > > UART use SDMA ROM firmware instead of RAM firmware, so it should work > > even without sdma RAM firmware loaded. Still curious what really > > happen in your board without this patch. > > What I am seeing is that at times, the HCI UART loading before the DMA > firmware is loaded. > > [ 10.582037] Bluetooth: HCI UART driver ver 2.3 > [ 10.586867] Bluetooth: HCI UART protocol H4 registered > [ 10.593566] imx-sdma 30bd0000.dma-controller: sdma firmware not > ready! Seems you apply my patch set ' add ecspi ERR009165 for i.mx6/7 soc family' https://www.spinics.net/lists/linux-spi/msg26728.html where 'sdma firmware not ready' added? > [ 10.594548] Bluetooth: HCI UART protocol Broadcom registered > [ 10.600108] imx-uart 30860000.serial: We cannot prepare for the RX slave > dma! Why not use ROM script for UART as mailine linux-next did (even the above patch set)? If so, I don't think you could such issue on your board. What script(peripheral types) you set in uart dts such as below is 4-- MCU domain UART-> IMX_DMATYPE_UART->app_2_mcu: dmas = <&sdma1 22 4 0>, <&sdma1 23 4 0>; > > When I get the above message, the bluetooth chip I have throws timeouts and > does not function. > > [ 10.615090] imx-sdma 302c0000.dma-controller: loaded firmware 4.5 > > Once the firmware is loaded, I can unload the HCI Uart driver and re-load > Bluetooth works again. > > Based on that, I've been having my system delay the loading of the Bluetooth > modules until after the firmware is loaded, but this tells me there is a > relationship between the DMA and UART. If you use ram script, of course you should use it after firmware loaded. Actually Spba bus in dts is only used for per_2_per script judging if the peripheral address could be accessed directly by SDMA over SPBA, if yes, set SDMA_WATERMARK_LEVEL_SP to let per_2_per script access peripheral over SPBA, otherwise, access peripheral by AIPS instead like ARM side did. Please check with below commit for more. Besides, per_2_per script is used for audio data sample rate convert between ASRC and various audio input. So audio peripherals include ASRC should be in register scope of 'spba-bus' . But with your patch, there are two 'spba-bus' device node in dts, so the first Spba-bus should contain audio peripheral, otherwise, 'of_find_compatible_node (NULL, NULL, "fsl,spba-bus")' may find the wrong one so that SDMA_WATERMARK_LEVEL_SP Never be set. BTW, do you mean the above firmware load issue you met is gone if this patch applied? If yes, that really surprised me... commit 8391ecf465ec5c8ccef547267df6d40beb8999a4 Author: Shengjiu Wang Date: Fri Jul 10 17:08:16 2015 +0800 dmaengine: imx-sdma: Add device to device support _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel