From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D895FC433B4 for ; Tue, 18 May 2021 10:50:30 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 663B96124C for ; Tue, 18 May 2021 10:50:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 663B96124C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=r/o59FwbASFjnpp0POeMqZZsr01GbLLMZIHkZC67IOE=; b=aV7fuK0hVNc4gKYA/RBQjvd83 evJg53F7Q36JaNHztCSZY+XkcPspzvpudLigjAph5gdndwoQJBSkQfBB1ao4yU+P17NsO5XHeUqp9 oglo6vv0FABvL7F9hLcp0yJ/GHSrNyjjnvLgILMrk1zF7KHaFezEO65skmIc6tFNTd+udENM5YfWY Wpca3yrUBqwkBQiK6Xl2fA1NFZqHy6GykvngelTi4whdB/smr8cfMSjSz+Cxt0lbDY061D5MRWCjI oFoXdgECO8oCxH2qBrxZOT3RvA9hhV7OekDDwTF6D0TpyhaksDOUguEh3CU4plBLzLwILXgCkrevK lY6Y5NwZg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lixGu-000RPH-Mp; Tue, 18 May 2021 10:48:20 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lixGs-000RP0-Gc for linux-arm-kernel@desiato.infradead.org; Tue, 18 May 2021 10:48:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lw//WQHU1n8Lr/SxhTfcfyc8tvk7S4lAFPEm1TkdCHc=; b=e5ZX+BbS+hdDg/wmz/SvnmxrVt LhbChoKJ6Gt5ne7mbT6IgCFaVJKfoXJEh1GkEisrGn/CV+q7nQD7EyXIgPZn2ms9ohrVKP7e9+LPJ emsW6xnReczxQexuQcWgmkE4EaOD5R3ZGJ2CvOslwKz0NWfB8q+IVK3lk2tONRuHQeL39L+Svsbif 9ebFPWpN89F/je/ameqirNsXM5QsN5EGbK0vQOMUXlj80QFesSa385ZOTAVflvlUILbhgW5JN8L1o gZRT49x+Dhk9jg9ZGaspMCy3KxM6qRnZ9s5Ot/ymQh5leMbRXbTvsN4YfF/mcLGcN/FslHj50S9Wc sWIJ1PPg==; Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lixGp-00EZwd-Ml for linux-arm-kernel@lists.infradead.org; Tue, 18 May 2021 10:48:17 +0000 Received: by mail-wm1-x32e.google.com with SMTP id h3-20020a05600c3503b0290176f13c7715so1201858wmq.5 for ; Tue, 18 May 2021 03:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lw//WQHU1n8Lr/SxhTfcfyc8tvk7S4lAFPEm1TkdCHc=; b=jX9kX3Vod+I5rJUyU3cakHfzGdz5a5bQTSWVHWoUF68aLrBioufVUMrdLrwYA7KVgN eKLuTdcWsE8cCeK881ntTFN7BxBmqSs8GrQ/4HsJs4QkmOMvCgz57xB8py6JNHZ4q55u Syqwk3o+fLHz7otqXclL6PhUe3qxkOwcm1ATA400g++22qFMB7cbUis1J8LekpDIOc2R dfbFFYZgyi3zDX4ERYVsMsF2OIDcKpVMwV2LRogtiLE/CZxdfD+0uLOzGk5EfdJeji// k8PWHbpBHjh8fgP//HMPG5rhN5IUcWeHyw6BUcgC4gLyrIOuwXBTuUUZwfVBxsmVaVIQ Te1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lw//WQHU1n8Lr/SxhTfcfyc8tvk7S4lAFPEm1TkdCHc=; b=B10vEghB9CkmxovpODRbFk1VwDdTRju4O12LOZ/i37X+9RccVMHZVPf+VX1e5GS32b CMsDYIhmzBycRkbyomWhR33v5tT6YvgC3s+hCtffPu6QV9ItDdvRm6Z4XbUAhGKHptC9 BHo026AilSLHN0U/Fxh8fOl0rgLwxpzCllD0x3iHK/L37X7p2DsX+sp9Qc8jJFEfynDi dm6NF+x5kY54RXCf+aA70UDqmN21EMbAh2HJ9gzthCwcbmFBnlCiEmaNKy76mNDZYT0i KNiSiyn9ww+xoE5lupyvr3UyKBeBpzPNsJBfC+ac8xmB91wPC4tO10v2QfZKj7P9pX0A p2JA== X-Gm-Message-State: AOAM5315XgyNvb3TKUva6UanyWg1DRSFR24V18jIGdIqHDV2iTtIJv7H nBnscnXOIfY6apXrts5YwmqMIw== X-Google-Smtp-Source: ABdhPJzRiT7qtOCBDsKWLZ6LPMj4QiYCEg9Nduj8NBMDuCXcB7+XAdn7gCxXdilFj6ofUcHz4C743g== X-Received: by 2002:a1c:b646:: with SMTP id g67mr207192wmf.117.1621334890798; Tue, 18 May 2021 03:48:10 -0700 (PDT) Received: from google.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id h14sm2930154wmb.1.2021.05.18.03.48.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 May 2021 03:48:10 -0700 (PDT) Date: Tue, 18 May 2021 10:48:07 +0000 From: Quentin Perret To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Marc Zyngier , Greg Kroah-Hartman , Peter Zijlstra , Morten Rasmussen , Qais Yousef , Suren Baghdasaryan , Tejun Heo , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , "Rafael J. Wysocki" , kernel-team@android.com Subject: Re: [PATCH v6 13/21] sched: Admit forcefully-affined tasks into SCHED_DEADLINE Message-ID: References: <20210518094725.7701-1-will@kernel.org> <20210518094725.7701-14-will@kernel.org> <20210518102833.GA7770@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210518102833.GA7770@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_034815_791135_89A61B8F X-CRM114-Status: GOOD ( 16.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tuesday 18 May 2021 at 11:28:34 (+0100), Will Deacon wrote: > I don't have strong opinions on this, but I _do_ want the admission via > sched_setattr() to be consistent with execve(). What you're suggesting > ticks that box, but how many applications are prepared to handle a failed > execve()? I suspect it will be fatal. Yep, probably. > Probably also worth pointing out that the approach here will at least > warn in the execve() case when the affinity is overridden for a deadline > task. Right so I think either way will be imperfect, so I agree with the above. Maybe one thing though is that, IIRC, userspace _can_ disable admission control if it wants to. In this case I'd have no problem with allowing this weird behaviour when admission control is off -- the kernel won't provide any guarantees. But if it's left on, then it's a different story. So what about we say, if admission control is off, we allow execve() and sched_setattr() with appropriate warnings as you suggest, but if admission control is on then we fail both? We might still see random failures in the wild if admission control is left enabled on those devices but then I think these could qualify as a device misconfiguration, not as a kernel bug. Thoughts? Thanks, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel