From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: Eric Auger <eric.auger@redhat.com>
Cc: rjw@rjwysocki.net, lenb@kernel.org, joro@8bytes.org,
mst@redhat.com, will@kernel.org, catalin.marinas@arm.com,
baolu.lu@linux.intel.com, dwmw2@infradead.org,
linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org,
virtualization@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org, sebastien.boeuf@intel.com,
robin.murphy@arm.com, kevin.tian@intel.com,
lorenzo.pieralisi@arm.com, guohanjun@huawei.com,
sudeep.holla@arm.com
Subject: Re: [PATCH v4 4/6] iommu/dma: Pass address limit rather than size to iommu_setup_dma_ops()
Date: Fri, 18 Jun 2021 11:18:08 +0200 [thread overview]
Message-ID: <YMxk0Na2yuRNwPT7@myrica> (raw)
In-Reply-To: <6d139529-9539-fbe4-8f85-da39461047ba@redhat.com>
On Wed, Jun 16, 2021 at 05:28:59PM +0200, Eric Auger wrote:
> Hi Jean,
>
> On 6/10/21 9:51 AM, Jean-Philippe Brucker wrote:
> > diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c
> > index 4bf1dd3eb041..7bd1d2199141 100644
> > --- a/arch/arm64/mm/dma-mapping.c
> > +++ b/arch/arm64/mm/dma-mapping.c
> > @@ -50,7 +50,7 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
> >
> > dev->dma_coherent = coherent;
> > if (iommu)
> > - iommu_setup_dma_ops(dev, dma_base, size);
> > + iommu_setup_dma_ops(dev, dma_base, size - dma_base - 1);
> I don't get size - dma_base - 1?
Because it's wrong, should be dma_base + size - 1. Thanks for catching it!
Thanks,
Jean
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-18 9:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 7:51 [PATCH v4 0/6] Add support for ACPI VIOT Jean-Philippe Brucker
2021-06-10 7:51 ` [PATCH v4 1/6] ACPI: arm64: Move DMA setup operations out of IORT Jean-Philippe Brucker
2021-06-16 9:35 ` Eric Auger
2021-06-10 7:51 ` [PATCH v4 2/6] ACPI: Move IOMMU setup code " Jean-Philippe Brucker
2021-06-16 9:35 ` Eric Auger
2021-06-18 7:41 ` Jean-Philippe Brucker
2021-06-18 9:16 ` Robin Murphy
2021-06-10 7:51 ` [PATCH v4 3/6] ACPI: Add driver for the VIOT table Jean-Philippe Brucker
2021-06-16 13:26 ` Eric Auger
2021-06-18 7:43 ` Jean-Philippe Brucker
2021-06-17 11:50 ` Rafael J. Wysocki
2021-06-18 7:54 ` Jean-Philippe Brucker
2021-06-10 7:51 ` [PATCH v4 4/6] iommu/dma: Pass address limit rather than size to iommu_setup_dma_ops() Jean-Philippe Brucker
2021-06-16 15:28 ` Eric Auger
2021-06-18 9:18 ` Jean-Philippe Brucker [this message]
2021-06-10 7:51 ` [PATCH v4 5/6] iommu/dma: Simplify calls " Jean-Philippe Brucker
2021-06-16 15:50 ` Eric Auger
2021-06-16 17:02 ` Robin Murphy
2021-06-18 10:50 ` Jean-Philippe Brucker
2021-06-18 11:19 ` Robin Murphy
2021-06-10 7:51 ` [PATCH v4 6/6] iommu/virtio: Enable x86 support Jean-Philippe Brucker
2021-06-16 15:52 ` Eric Auger
2021-06-16 6:34 ` [PATCH v4 0/6] Add support for ACPI VIOT Jean-Philippe Brucker
2021-06-16 12:40 ` Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMxk0Na2yuRNwPT7@myrica \
--to=jean-philippe@linaro.org \
--cc=baolu.lu@linux.intel.com \
--cc=catalin.marinas@arm.com \
--cc=dwmw2@infradead.org \
--cc=eric.auger@redhat.com \
--cc=guohanjun@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mst@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=robin.murphy@arm.com \
--cc=sebastien.boeuf@intel.com \
--cc=sudeep.holla@arm.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).