From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE683C4338F for ; Fri, 6 Aug 2021 18:38:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63FCE61050 for ; Fri, 6 Aug 2021 18:38:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 63FCE61050 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FstXMGEYsLaoBOUfh5YxB9e8b8OBHgBSd82n8DObVoM=; b=wqWO9YJklkHzLu sZsk6uU9dHbN9vnbh9YguknZMOIRb/2do42Iz54CrZdE5UIwqYdt0miSPO9tTkrr+zN6dk4oJHCvK 9JEERYDxQ+GCvFiNAmJJCzV2g/4jGNfOXPuBnRy2Wpyt5ZuKR2L0hfHEyVAPXKHJfBdFP8Hm6dJpe wcuGuOV/YUh8T1anVtLA2I3X96Hd966qrUnw0iy0l/IltAuBp5J4xgdLH/ldQePvhapNNXJqbjG4d psdgfvrw5O5DLscWZ0CtX2h2mniQXgeVuyfazxeUMCTWoNRRoQZmblu5OIpb1py/4L3+e/Z7krLWm 5QznMFOX5tNdLaAUzDtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mC4iL-00D9bN-3a; Fri, 06 Aug 2021 18:37:01 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mC4iI-00D9ax-9g for linux-arm-kernel@bombadil.infradead.org; Fri, 06 Aug 2021 18:36:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VdApc292+AxEwIerFHCStlTOS1wabsJkQOWiwG4B1v4=; b=OBgdCCeWtkpw+UaGUAaAjHmNZ4 0IczEP/Fa/VEvkdLLPJ4KKIH2O2yks5s30e+Nufp0OY9KtyDr/+x6bM4EwwevtZ4gX3hn+EmYOLGC 91VOVqQOvUI8g6KupBt550fEO17CQRQxJ1nV+onmRBGv3iV/yVZt/bOX30P4PcH1w9+wZOdF6Zfwg z2w0iEzATOQVViAiGnwWvUKdlW4O6kl3GKRr0qJkS9b3KaQrvanEVtJQKFxvjmZBlmqzWTVu0E52E 3wpqgYtwH5nsU6KVUe647z4QxWejx8z4Lzi6G5zI8CMBlJVK48kxQazxOqgdo4CowZJevwcmmf8Kr Opus7y8g==; Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mC4hz-008Tr2-AK for linux-arm-kernel@lists.infradead.org; Fri, 06 Aug 2021 18:36:43 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 44EE9403F2; Fri, 6 Aug 2021 15:36:37 -0300 (-03) Date: Fri, 6 Aug 2021 15:36:37 -0300 From: Arnaldo Carvalho de Melo To: James Clark Cc: Leo Yan , mathieu.poirier@linaro.org, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, suzuki.poulose@arm.com, mike.leach@linaro.org, Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , John Garry , Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 6/6] perf cs-etm: Add warnings for missing DSOs Message-ID: References: <20210729155805.2830-1-james.clark@arm.com> <20210729155805.2830-7-james.clark@arm.com> <20210802154145.GC148327@leoy-ThinkPad-X240s> <20210803140122.GC247709@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Thu, Aug 05, 2021 at 01:59:49PM +0100, James Clark escreveu: > > > On 03/08/2021 15:01, Leo Yan wrote: > >> one can also use debuginfod-client, which, as time passes, probably will > >> be the main way of finding DSOs now that we have build-ids in > >> PERF_RECORD_MMAP2 and debuginfod servers such as: > >> > >> export DEBUGINFOD_URLS=https://debuginfod.fedoraproject.org/ > > If so, maybe should use more general description for missing DSO. > > > >> https://fedoraproject.org/wiki/Debuginfod > >> > >>> With this improvement, the patch looks good to me: > >>> > >>> Reviewed-by: Leo Yan > >> Does this apply to the other 5 patches in this series? > > I finished to reivew patches 01, 04, 05, 06/06, so my review tag can > > apply on these patches. Current patch 06/06 needs James to improve for > > the comments. > > Thanks for the reviews, I've submitted v2. > > I also had a play around with debuginfod, it looks promising. > Especially if it's integrated with perf report, which I assume is the plan? Yeah, code is needed for that in the underlying symbols library so that we can tune its usage, i.e. the threshold of samples to trigger asking for the auto-download of debuginfo files. - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel