From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1FD4C4338F for ; Tue, 3 Aug 2021 13:37:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1FFC6023E for ; Tue, 3 Aug 2021 13:37:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B1FFC6023E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mDZygqk0RNC4kBDk60m0lalJBpElGzolrNVDON6UKVQ=; b=4YPBdWB7RZFOfy pbIG9MNesREVt8gUFPe55qSCTWKgpudp7yJQjVp9hwyvMJUxddwXe7t/f3qrImgqHq0gJMDVH57Ez /YOXZ63Ncn1Rcvgt9MbIQr29i+OV64cqUYAtJKIbvn60oJINeslAS8idTJioBbLxA5HcVqoW/cNZE iN+tJ0fkbwXqPXXs7th28JJycHNoSk0t2usWPtkZRp4/zNh8OiIe8VxGkdF5SthyC0Uxd4HD7CJOj bJWpNUxQBTiM+SUATafqDzCx7+wtk9/liv+i3Y1Ies464PY9+NWMDTebJEYRE7/0A24T/pv+RUL5Z jFWGhIXAIBYmE113HjOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAua5-00346W-Vl; Tue, 03 Aug 2021 13:35:42 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAuQS-00304J-Kw for linux-arm-kernel@bombadil.infradead.org; Tue, 03 Aug 2021 13:25:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EkH1ydZLiUxC1K/DvYw7qyt81sQTeic+RHJevpwQIr4=; b=Xn76waZcNmqlAoaIdNdBCln8TW TZG1FhrswYrPiMhK6cCwksWM3re+ljV4YRNOsRh1q5PJcRLFqxeQx5JOsDhVNCt02rW2kVLNCuxhn MHhN9h60CUaGBH5uOZlKsadQk/C9SbQkVWr3Lzq+G2bCpZ9iMY2NXbXNdnb5WD6ISwPyc990242gr FMs+zW8g/OtcA6J/0C+8LXYLsb1sbYx5k8KpwDjXmI92nslibV1ed/Ehax9dUNPzc2yTT7wGse7IC KiE4UnGDhp+3afhvbdOaUApj+4M7FjkGUfxFEAYxDvGsfbJGG544pB0m7i2W3w0Eoa2uQlKqf17hM 2iez0bRg==; Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAuQQ-005QDG-Rs for linux-arm-kernel@lists.infradead.org; Tue, 03 Aug 2021 13:25:43 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 0593F403F2; Tue, 3 Aug 2021 10:25:40 -0300 (-03) Date: Tue, 3 Aug 2021 10:25:39 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: James Clark , mathieu.poirier@linaro.org, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, suzuki.poulose@arm.com, mike.leach@linaro.org, Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , John Garry , Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 5/6] perf cs-etm: Improve Coresight zero timestamp warning Message-ID: References: <20210729155805.2830-1-james.clark@arm.com> <20210729155805.2830-6-james.clark@arm.com> <20210802151710.GB148327@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210802151710.GB148327@leoy-ThinkPad-X240s> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Mon, Aug 02, 2021 at 11:17:10PM +0800, Leo Yan escreveu: > On Thu, Jul 29, 2021 at 04:58:04PM +0100, James Clark wrote: > > Only show the warning if the user hasn't already set timeless mode and > > improve the text because there was ambiguity around the meaning of '...' > > > > Change the warning to a UI warning instead of printing straight to > > stderr because this corrupts the UI when perf report TUI is used. The UI > > warning function also handles printing to stderr when in perf script > > mode. > > > > Suggested-by: Leo Yan > > Signed-off-by: James Clark > > Reviewed-by: Leo Yan Thanks, applied. - Arnaldo > > --- > > tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > > index 3e1a05bc82cc..5084bd2ca6eb 100644 > > --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > > +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > > @@ -324,8 +324,11 @@ cs_etm_decoder__do_hard_timestamp(struct cs_etm_queue *etmq, > > * underflow. > > */ > > packet_queue->cs_timestamp = 0; > > - WARN_ONCE(true, "Zero Coresight timestamp found at Idx:%" OCSD_TRC_IDX_STR > > - ". Decoding may be improved with --itrace=Z...\n", indx); > > + if (!cs_etm__etmq_is_timeless(etmq)) > > + pr_warning_once("Zero Coresight timestamp found at Idx:%" OCSD_TRC_IDX_STR > > + ". Decoding may be improved by prepending 'Z' to your current --itrace arguments.\n", > > + indx); > > + > > } else if (packet_queue->instr_count > elem->timestamp) { > > /* > > * Sanity check that the elem->timestamp - packet_queue->instr_count would not > > -- > > 2.28.0 > > -- - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel