Re: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy

From: Sam Ravnborg <sam@ravnborg.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: airlied@linux.ie, tomi.valkeinen@ideasonboard.com,
	liviu.dudau@arm.com, stefan@agner.ch,
	amd-gfx@lists.freedesktop.org, anitha.chrisanthus@intel.com,
	Dan.Sneddon@microchip.com, patrik.r.jakobsson@gmail.com,
	linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
	daniel@ffwll.ch, edmund.j.dea@intel.com, s.hauer@pengutronix.de,
	alison.wang@nxp.com, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org, dri-devel@lists.freedesktop.org,
	sean@poorly.run, linux-arm-kernel@lists.infradead.org,
	tomba@kernel.org, bbrezillon@kernel.org, jyri.sarha@iki.fi,
	christian.koenig@amd.com, robdclark@gmail.com,
	kernel@pengutronix.de, alexander.deucher@amd.com,
	shawnguo@kernel.org, brian.starkey@arm.com
Subject: Re: [PATCH v2 00/14] drm: Make DRM's IRQ helpers legacy
Date: Tue, 3 Aug 2021 17:04:54 +0200	[thread overview]
Message-ID: <YQlbFjbrnyeWv7QP@ravnborg.org> (raw)
In-Reply-To: <20210803090704.32152-1-tzimmermann@suse.de>

Hi Thomas,

On Tue, Aug 03, 2021 at 11:06:50AM +0200, Thomas Zimmermann wrote:
> DRM's IRQ helpers are only helpful for old, non-KMS drivers. Move
> the code behind CONFIG_DRM_LEGACY. Convert KMS drivers to Linux
> IRQ interfaces.
> 
> DRM provides IRQ helpers for setting up, receiving and removing IRQ
> handlers. It's an abstraction over plain Linux functions. The code
> is mid-layerish with several callbacks to hook into the rsp drivers.
> Old UMS driver have their interrupts enabled via ioctl, so these
> abstractions makes some sense. Modern KMS manage all their interrupts
> internally. Using the DRM helpers adds indirection without benefits.
> 
> Most KMS drivers already use Linux IRQ functions instead of DRM's
> abstraction layer. Patches 1 to 12 convert the remaining ones.
> The patches also resolve a bug for devices without assigned interrupt
> number. DRM helpers don't test for IRQ_NOTCONNECTED, so drivers do
> not detect if the device has no interrupt assigned.
> 
> Patch 13 removes an unused function.
> 
> Patch 14 moves the DRM IRQ helpers behind CONFIG_DRM_LEGACY. Only
> the old non-KMS drivers still use the functionality.
> 
> v2:
> 	* drop IRQ_NOTCONNECTED test from atmel-hlcdc (Sam)
> 	* use devm_request_irq() in atmel-hlcdc (Sam)
> 	* unify variable names in arm/hlcdc (Sam)
> 
> Thomas Zimmermann (14):

The following patches are all:
Acked-by: Sam Ravnborg <sam@ravnborg.org>

>   drm/fsl-dcu: Convert to Linux IRQ interfaces
>   drm/gma500: Convert to Linux IRQ interfaces
>   drm/kmb: Convert to Linux IRQ interfaces
>   drm/msm: Convert to Linux IRQ interfaces
>   drm/mxsfb: Convert to Linux IRQ interfaces
>   drm/tidss: Convert to Linux IRQ interfaces
>   drm/vc4: Convert to Linux IRQ interfaces
>   drm: Remove unused devm_drm_irq_install()

The remaining patches I either skipped or already had a feedback from
me or I asked a question.

	Sam

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel