Re: [PATCH] dt-bindings: soc: ti: pruss: Add dma-coherent property

From: Rob Herring <robh@kernel.org>
To: Suman Anna <s-anna@ti.com>
Cc: Santosh Shilimkar <ssantosh@kernel.org>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Lokesh Vutla <lokeshvutla@ti.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: soc: ti: pruss: Add dma-coherent property
Date: Tue, 3 Aug 2021 13:28:47 -0600	[thread overview]
Message-ID: <YQmY7/OSHJxRkM5m@robh.at.kernel.org> (raw)
In-Reply-To: <20210730031901.26243-1-s-anna@ti.com>

On Thu, Jul 29, 2021 at 10:19:01PM -0500, Suman Anna wrote:
> Update the PRUSS schema file to include the dma-coherent property
> that indicates the coherency of the IP. The PRUSS IPs on 66AK2G
> SoCs do use this property.
> 
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> Hi Santosh,
> 
> This patch updates the PRUSS binding in preparation for adding the
> PRUSS nodes for 66AK2G SoCs. Without this, the dtbs_check would
> complain about the undefined dma-coherent property. Patch is top
> of the AM64 ICSSG binding update patch [1].

New required properties are not backwards compatible. You are kind of 
saying that here (not used yet?), but make that clear in the commit msg.

With that fixed,

Reviewed-by: Rob Herring <robh@kernel.org>

> 
> regards
> Suman
> 
> [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210623165032.31223-2-s-anna@ti.com/
> 
>  .../devicetree/bindings/soc/ti/ti,pruss.yaml  | 37 +++++++++++++------
>  1 file changed, 25 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> index 47d7fd24bc56..9d128b9e7deb 100644
> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> @@ -85,6 +85,8 @@ properties:
>    dma-ranges:
>      maxItems: 1
>  
> +  dma-coherent: true
> +
>    power-domains:
>      description: |
>        This property is as per sci-pm-domain.txt.
> @@ -324,18 +326,29 @@ additionalProperties: false
>  # - interrupt-controller
>  # - pru
>  
> -if:
> -  properties:
> -    compatible:
> -      contains:
> -        enum:
> -          - ti,k2g-pruss
> -          - ti,am654-icssg
> -          - ti,j721e-icssg
> -          - ti,am642-icssg
> -then:
> -  required:
> -    - power-domains
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - ti,k2g-pruss
> +              - ti,am654-icssg
> +              - ti,j721e-icssg
> +              - ti,am642-icssg
> +    then:
> +      required:
> +        - power-domains
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - ti,k2g-pruss
> +    then:
> +      required:
> +        - dma-coherent
>  
>  examples:
>    - |
> -- 
> 2.32.0
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel