From: Vlastimil Babka <vbabka@suse.cz>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>,
Walter Wu <walter-zh.wu@mediatek.com>
Cc: wsd_upstream@mediatek.com, Arnd Bergmann <arnd@arndb.de>,
linux-mm@kvack.org, Andrey Konovalov <andreyknvl@google.com>,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
kasan-dev@googlegroups.com,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Alexander Potapenko <glider@google.com>,
linux-arm-kernel@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>, Qian Cai <cai@lca.pw>,
Andrew Morton <akpm@linux-foundation.org>,
Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH v3] mm/kasan: dump alloc and free stack for page allocator
Date: Tue, 17 Sep 2019 10:19:15 +0200 [thread overview]
Message-ID: <a5103bf0-245e-5894-0486-3e92fa830e41@suse.cz> (raw)
In-Reply-To: <4e76e7ce-1d61-524a-622b-663c01d19707@virtuozzo.com>
On 9/16/19 5:57 PM, Andrey Ryabinin wrote:
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -710,8 +710,12 @@ static int __init early_debug_pagealloc(char *buf)
>> if (kstrtobool(buf, &enable))
>> return -EINVAL;
>>
>> - if (enable)
>> + if (enable) {
>> static_branch_enable(&_debug_pagealloc_enabled);
>> +#ifdef CONFIG_PAGE_OWNER
>> + page_owner_free_stack_disabled = false;
>
> I think this won't work with CONFIG_DEBUG_PAGEALLOC_ENABLE_DEFAULT=y
Good point, thanks.
>> +#endif
>> + }
>>
>> return 0;
>> }
>> diff --git a/mm/page_owner.c b/mm/page_owner.c
>> index dee931184788..b589bfbc4795 100644
>> --- a/mm/page_owner.c
>> +++ b/mm/page_owner.c
>> @@ -24,13 +24,15 @@ struct page_owner {
>> short last_migrate_reason;
>> gfp_t gfp_mask;
>> depot_stack_handle_t handle;
>> -#ifdef CONFIG_DEBUG_PAGEALLOC
>> +#ifdef CONFIG_PAGE_OWNER_FREE_STACK
>> depot_stack_handle_t free_handle;
>> #endif
>> };
>>
>> static bool page_owner_disabled = true;
>> +bool page_owner_free_stack_disabled = true;
>> DEFINE_STATIC_KEY_FALSE(page_owner_inited);
>> +static DEFINE_STATIC_KEY_FALSE(page_owner_free_stack);
>>
>> static depot_stack_handle_t dummy_handle;
>> static depot_stack_handle_t failure_handle;
>> @@ -46,6 +48,9 @@ static int __init early_page_owner_param(char *buf)
>> if (strcmp(buf, "on") == 0)
>> page_owner_disabled = false;
>>
>> + if (!page_owner_disabled && IS_ENABLED(CONFIG_KASAN))
>
> I'd rather keep all logic in one place, i.e. "if (!page_owner_disabled && (IS_ENABLED(CONFIG_KASAN) || debug_pagealloc_enabled())"
> With this no changes in early_debug_pagealloc() required and CONFIG_DEBUG_PAGEALLOC_ENABLE_DEFAULT=y should also work correctly.
In this function it would not work if the debug_pagealloc param gets
processed later than page_owner, but should be doable in
init_page_owner(), I'll try, thanks.
>
>> + page_owner_free_stack_disabled = false;
>> +
>> return 0;
>> }
>> early_param("page_owner", early_page_owner_param);
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-17 8:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 8:39 [PATCH v3] mm/kasan: dump alloc and free stack for page allocator Walter Wu
2019-09-11 15:19 ` Qian Cai
2019-09-12 13:53 ` Vlastimil Babka
2019-09-12 14:08 ` Andrey Ryabinin
2019-09-12 14:08 ` Walter Wu
2019-09-12 14:31 ` Vlastimil Babka
2019-09-12 15:13 ` Walter Wu
2019-09-12 17:05 ` Andrey Ryabinin
2019-09-16 9:42 ` Vlastimil Babka
2019-09-16 15:57 ` Andrey Ryabinin
2019-09-17 8:19 ` Vlastimil Babka [this message]
2019-09-23 8:20 ` [PATCH] mm, debug, kasan: save and dump freeing stack trace for kasan Vlastimil Babka
2019-09-25 9:41 ` Andrey Ryabinin
2019-09-12 14:10 ` [PATCH v3] mm/kasan: dump alloc and free stack for page allocator Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5103bf0-245e-5894-0486-3e92fa830e41@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=cai@lca.pw \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=matthias.bgg@gmail.com \
--cc=schwidefsky@de.ibm.com \
--cc=walter-zh.wu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).