From: Jiri Slaby <jirislaby@kernel.org>
To: Andrew Jeffery <andrew@aj.id.au>, linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joel Stanley <joel@jms.id.au>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,
jenmin_yuan@aspeedtech.com, Ryan Chen <ryan_chen@aspeedtech.com>,
Milton Miller II <miltonm@us.ibm.com>
Subject: Re: [PATCH v2 2/2] serial: 8250: Use BIT(x) for UART_{CAP,BUG}_*
Date: Wed, 19 May 2021 08:32:13 +0200 [thread overview]
Message-ID: <a67f0c95-7708-569f-099b-db9e2ad9616d@kernel.org> (raw)
In-Reply-To: <2bb7dfc4-a20e-4e3e-8fa5-74ff264c4e44@www.fastmail.com>
On 19. 05. 21, 8:27, Andrew Jeffery wrote:
>
>
> On Wed, 19 May 2021, at 15:44, Jiri Slaby wrote:
>> On 19. 05. 21, 2:07, Andrew Jeffery wrote:
>>> BIT(x) improves readability and safety with respect to shifts.
>>>
>>> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
>>> ---
>>> drivers/tty/serial/8250/8250.h | 33 +++++++++++++++++----------------
>>> 1 file changed, 17 insertions(+), 16 deletions(-)
>>>
>>> diff --git a/drivers/tty/serial/8250/8250.h b/drivers/tty/serial/8250/8250.h
>>> index 34aa2714f3c9..4fbf1088fad8 100644
>>> --- a/drivers/tty/serial/8250/8250.h
>>> +++ b/drivers/tty/serial/8250/8250.h
>>> @@ -7,6 +7,7 @@
>>> * Copyright (C) 2001 Russell King.
>>> */
>>>
>>> +#include <linux/bitops.h>
>>> #include <linux/serial_8250.h>
>>> #include <linux/serial_reg.h>
>>> #include <linux/dmaengine.h>
>>> @@ -70,25 +71,25 @@ struct serial8250_config {
>>> unsigned int flags;
>>> };
>>>
>>> -#define UART_CAP_FIFO (1 << 8) /* UART has FIFO */
>>> -#define UART_CAP_EFR (1 << 9) /* UART has EFR */
>>> -#define UART_CAP_SLEEP (1 << 10) /* UART has IER sleep */
>>> -#define UART_CAP_AFE (1 << 11) /* MCR-based hw flow control */
>>> -#define UART_CAP_UUE (1 << 12) /* UART needs IER bit 6 set (Xscale) */
>>> -#define UART_CAP_RTOIE (1 << 13) /* UART needs IER bit 4 set (Xscale, Tegra) */
>>> -#define UART_CAP_HFIFO (1 << 14) /* UART has a "hidden" FIFO */
>>> -#define UART_CAP_RPM (1 << 15) /* Runtime PM is active while idle */
>>> -#define UART_CAP_IRDA (1 << 16) /* UART supports IrDA line discipline */
>>> -#define UART_CAP_MINI (1 << 17) /* Mini UART on BCM283X family lacks:
>>> +#define UART_CAP_FIFO BIT(8) /* UART has FIFO */
>>> +#define UART_CAP_EFR BIT(9) /* UART has EFR */
>>> +#define UART_CAP_SLEEP BIT(10) /* UART has IER sleep */
>>
>>
>> Perfect, except the include: BIT is not defined in bitops.h, but in
>> bits.h (which includes vdso/bits.h). In fact, bitops.h includes bits.h
>> too, but it's superfluous to include all those bitops.
>
> Maybe the recommendation in the checkpatch documentation should be
> fixed then?
+1 since:
commit 8bd9cb51daac89337295b6f037b0486911e1b408
Author: Will Deacon <will@kernel.org>
Date: Tue Jun 19 13:53:08 2018 +0100
locking/atomics, asm-generic: Move some macros from
<linux/bitops.h> to a new <linux/bits.h> file
So care to fix checkpatch too :)?
thanks,
--
js
suse labs
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-19 6:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 0:07 [PATCH v2 0/2] serial: 8250: Mitigate Tx stall risk for Aspeed VUARTs Andrew Jeffery
2021-05-19 0:07 ` [PATCH v2 1/2] serial: 8250: Add UART_BUG_TXRACE workaround for Aspeed VUART Andrew Jeffery
2021-05-19 0:58 ` Joel Stanley
2021-05-19 4:58 ` Andrew Jeffery
2021-05-19 6:10 ` Jiri Slaby
2021-05-19 6:20 ` Andrew Jeffery
2021-05-19 0:07 ` [PATCH v2 2/2] serial: 8250: Use BIT(x) for UART_{CAP,BUG}_* Andrew Jeffery
2021-05-19 6:14 ` Jiri Slaby
2021-05-19 6:27 ` Andrew Jeffery
2021-05-19 6:32 ` Jiri Slaby [this message]
2021-05-19 6:35 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a67f0c95-7708-569f-099b-db9e2ad9616d@kernel.org \
--to=jirislaby@kernel.org \
--cc=andrew@aj.id.au \
--cc=gregkh@linuxfoundation.org \
--cc=jenmin_yuan@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=miltonm@us.ibm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).