From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE7F1C4338F for ; Thu, 5 Aug 2021 13:01:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6803060EE4 for ; Thu, 5 Aug 2021 13:01:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6803060EE4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=63twNf0R2gWY1y9cooRvtfbVUU6E6gh1usefhS8vtZw=; b=SopKoMvnAbvRhIfPWjNLmG4vmD W78FOvGcEk6OP+HVyjlFxGkWIXMsfbquwNE3o1NYQf1tC4yHdLJqWz32U8XbqnEdj3A45u10F6M7M UPkl8mwoYYQSuw7KBY0xOuS3acFNFT+PUXOBFSfwenkShy3YJuWC99u5Nsf4ePNdZ89AlVjQ5UUq0 17XtPrfE+89Kh2IEu3i+5T43pixTszmz4n9ikmyiJLif+Pd9WsIFnRAAqR40ASIFX9q9iHPoB8KT2 LFD18cYmmbnir0qkU5Z17wWcSdTQJJzozaNegVAMUSyWj0Urs791d4daijNDNFM9c9+rAA94KfUDt EqsQ5+YQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBcyd-009acY-F3; Thu, 05 Aug 2021 12:59:59 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBcyZ-009abE-HO for linux-arm-kernel@lists.infradead.org; Thu, 05 Aug 2021 12:59:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0E5211042; Thu, 5 Aug 2021 05:59:53 -0700 (PDT) Received: from [10.57.40.41] (unknown [10.57.40.41]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 04AB73F719; Thu, 5 Aug 2021 05:59:50 -0700 (PDT) Subject: Re: [RFC PATCH 6/6] perf cs-etm: Add warnings for missing DSOs To: Leo Yan , Arnaldo Carvalho de Melo Cc: mathieu.poirier@linaro.org, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, suzuki.poulose@arm.com, mike.leach@linaro.org, Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , John Garry , Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210729155805.2830-1-james.clark@arm.com> <20210729155805.2830-7-james.clark@arm.com> <20210802154145.GC148327@leoy-ThinkPad-X240s> <20210803140122.GC247709@leoy-ThinkPad-X240s> From: James Clark Message-ID: Date: Thu, 5 Aug 2021 13:59:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210803140122.GC247709@leoy-ThinkPad-X240s> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_055955_683010_3EE8E3EE X-CRM114-Status: GOOD ( 14.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/08/2021 15:01, Leo Yan wrote: >> one can also use debuginfod-client, which, as time passes, probably will >> be the main way of finding DSOs now that we have build-ids in >> PERF_RECORD_MMAP2 and debuginfod servers such as: >> >> export DEBUGINFOD_URLS=https://debuginfod.fedoraproject.org/ > If so, maybe should use more general description for missing DSO. > >> https://fedoraproject.org/wiki/Debuginfod >> >>> With this improvement, the patch looks good to me: >>> >>> Reviewed-by: Leo Yan >> Does this apply to the other 5 patches in this series? > I finished to reivew patches 01, 04, 05, 06/06, so my review tag can > apply on these patches. Current patch 06/06 needs James to improve for > the comments. Thanks for the reviews, I've submitted v2. I also had a play around with debuginfod, it looks promising. Especially if it's integrated with perf report, which I assume is the plan? Thanks James _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel