From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABE5CC4363A for ; Mon, 26 Oct 2020 17:01:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E32922450 for ; Mon, 26 Oct 2020 17:01:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YBDnhMCh"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="gdSIPYRy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E32922450 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yE9JQbiRbEnKKHff+98qRHIdIabYfDqTil+VrKuSMUo=; b=YBDnhMChwD1LuW3cjJLO9Bh5r hJ5zy3v0eODHupXXKGL+TpK76C1N+QQA1POMI1X6/kDi7IXiqel6KVeovsZFMKygkwmkTBvgnGmv8 XHHNoGv+c+tE0K625PllZAdD4qNssOA563oxti+PJ6WR8WG5HYFQ0M+WlJ34yJGUTk50v4rUSMtLf /vcIrElYlz/ibZappZtWz60SUW02duAF7adbiMKWkK6cvqN7z2rCmDxyTQHwgJe3pbpDxaRhDaHk1 iZlDKKEzOzlHMFgk5gN4HDyNDZziFNeZbCswQJ8nIgGb1wvzLepsKOkX0UxzEEzN7n1KphJS8hOnI szJ3Tkm/Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kX5rD-0006X9-JK; Mon, 26 Oct 2020 17:00:31 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kX5r9-0006Vp-EW; Mon, 26 Oct 2020 17:00:28 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7ADDF223B0; Mon, 26 Oct 2020 17:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603731626; bh=Wk5C6AUNf5Rr1fEwHl+3seiMfHFBEAh2bYObiBXLLX8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gdSIPYRyIpe/ZiMe9+II8R3w/Q5DiXCBun6pAQDRIAwQw8M+JPaVNaxoVmwuXDu6F ZGxBvlO2AiSwjUnczyLL8j/XuVhZWATASl4r1ZZQKUsQDStM9ly9RnTTPNe6B/8CuU LtmytiLl0WgVhtcG6POJPHmyUoecnSNtC2CKceyY= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kX5r6-004OVS-Jc; Mon, 26 Oct 2020 17:00:24 +0000 MIME-Version: 1.0 Date: Mon, 26 Oct 2020 17:00:24 +0000 From: Marc Zyngier To: Kevin Hilman Subject: Re: [PATCH 0/2] irq-meson-gpio: make it possible to build as a module In-Reply-To: <7ha6w9hsfm.fsf@baylibre.com> References: <20201020072532.949137-1-narmstrong@baylibre.com> <87v9eyo75s.wl-maz@kernel.org> <7ha6w9hsfm.fsf@baylibre.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: khilman@baylibre.com, narmstrong@baylibre.com, jbrunet@baylibre.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201026_130027_647829_07D6923C X-CRM114-Status: GOOD ( 24.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, jbrunet@baylibre.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Neil Armstrong Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-10-26 16:18, Kevin Hilman wrote: > Marc Zyngier writes: > >> On Tue, 20 Oct 2020 08:25:30 +0100, >> Neil Armstrong wrote: >>> >>> In order to reduce the kernel Image size on multi-platform >>> distributions, >>> make it possible to build the Amlogic GPIO IRQ controller as a module >>> by switching it to a platform driver. >>> >>> The second patch removes MESON_IRQ_GPIO selection from ARCH_MESON to >>> allow >>> building the driver as module. >>> >>> Neil Armstrong (2): >>> irqchip: irq-meson-gpio: make it possible to build as a module >>> arm64: meson: remove MESON_IRQ_GPIO selection >>> >>> arch/arm64/Kconfig.platforms | 1 - >>> drivers/irqchip/Kconfig | 5 +- >>> drivers/irqchip/irq-meson-gpio.c | 89 >>> ++++++++++++++++++++------------ >>> 3 files changed, 59 insertions(+), 36 deletions(-) >> >> I've tried this series on my vim3l with the this driver compiled as a >> module, and lost the Ethernet interface in the process, as the phy >> wasn't able to resolve its interrupt and things fail later on: >> >> [ 72.238291] meson8b-dwmac ff3f0000.ethernet eth1: no phy at addr -1 >> [ 72.238917] meson8b-dwmac ff3f0000.ethernet eth1: stmmac_open: >> Cannot attach to PHY (error: -19) >> >> This is a generic problem with making DT-based interrupt controllers >> modular when not *all* the drivers can deal with probing deferral. > > Yes, but this series still keeps the default as built-in. > > If you build as a module, and you add `fw_devlink=on` to the kernel > command-line, device-links will be created based on DT dependencies > which will ensure the right module load order. It doesn't work here. I get the exact same error (well, with eth0 instead of eth1). In my experience, fw_devlink isn't reliable yet. Config on request. > I've tested this series with `fw_devlink=on` on several Amlogic > platforms and it works just fine, but since it requires the extra > cmdline option, I think the default should remain built-in. > > So, I'd still like to see this series merged so that at least it's an > option to enable this as a module. I have taken similar patches in 5.9 for other SoC families (qcomm, mtk), and ended up reverting them in -rc2, because there is simply too much breakage. Even keeping it as built in changes the init order, which tons of drivers depend on. I proposed a middle-of-the-road approach (modules can break, built-in stays the same) which Rob pushed back on. So either we fix fw_devlink to work for everything and be on by default, or we keep the current setup. > Also, another reason to make it optional is that not all platforms need > this feature at all, but right now we select it for all Amlogic SoCs. I understand that, but I don't want another episode of widespread breakages, and this series definitely breaks things. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel