From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 533A4C433F5 for ; Tue, 7 Dec 2021 19:44:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=x/HRLbggNiFdchqwkolEwseTJqFy3zj3xnBZVrnMURU=; b=rJmax1OQT7F2c+ZRu7PTF6c+qb iWk47HG1Q2m1Zt/zOCqNnSYXsefIwdW9hV7f5VOi7v/d5E6cOYWcrgJYr+NB0vSPlVzNK7pmygzSD KxKJg5dSM5bx4eWmFGxhxAbM8EfoVI2LHGAU0Y8yI0eeU95dzCkYWrHki5c3Qp1CM3b6jEjW4TUNI VZigyRlREKg7iSbEqv/YDbHRRD7lPvVFwCPPVsNGx6gOTVtoQfyilzjuTYbz1dggCr+SqBoN0+t6b MS3z9ewC9fywS5eXHEL47hnqh+tm93l/X8xrH+bJ19vckR69B1VxONdlsmROX661A0xqC4NJH15TW A9zzpWjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mugMH-009v2H-7y; Tue, 07 Dec 2021 19:42:37 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mugMD-009v1a-MX for linux-arm-kernel@lists.infradead.org; Tue, 07 Dec 2021 19:42:35 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 0BDBACE1B8B; Tue, 7 Dec 2021 19:42:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39AA7C341C3; Tue, 7 Dec 2021 19:42:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638906150; bh=XVX9o3VWrtvyVxiDPrxlrr7aFHBobyjCRBFZ0nPdMxo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DYv9u6HVviK0Smafd1q+EzWY9bH9ejahYC7E05S2eATigMcvoxljcEVfx7Ab4eo5q fvctc8Qq9KphJ3AubOca5WhDu5emB/gB3hzSvy2v85qhDMOlGc3pXkYCAGPMOLFiEx lARO9om7j1QKkkMl1Xe7PTWxvupKcTFN+EEj9unffQ+obZyLNcC6TvMPSLJHpExlRl B2TaBSOxKdY4Szym0GIbcBl29q8VQcky3CoRb+3MJxHoLv3fUN9T0pkbvXN2gHCDNy c+m+hq6CkW+2kZlcrqzWt9xpTDjs4WKcA3JGgDJM361IVZMjaAZv8kUyN+veD3+VAN 6t+ZNB9vXPTSw== Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mugM7-00AarY-Tn; Tue, 07 Dec 2021 19:42:28 +0000 MIME-Version: 1.0 Date: Tue, 07 Dec 2021 19:42:27 +0000 From: Marc Zyngier To: David Virag Cc: Sam Protsenko , Krzysztof Kozlowski , Rob Herring , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v4 7/7] arm64: dts: exynos: Add initial device tree support for Exynos7885 SoC In-Reply-To: <20211206153124.427102-8-virag.david003@gmail.com> References: <20211206153124.427102-1-virag.david003@gmail.com> <20211206153124.427102-8-virag.david003@gmail.com> User-Agent: Roundcube Webmail/1.4.12 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: virag.david003@gmail.com, semen.protsenko@linaro.org, krzysztof.kozlowski@canonical.com, robh+dt@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211207_114234_115165_303D249D X-CRM114-Status: GOOD ( 13.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-12-06 15:31, David Virag wrote: > Add initial Exynos7885 device tree nodes with dts for the Samsung > Galaxy > A8 (2018), a.k.a. "jackpotlte", with model number "SM-A530F". > Currently this includes some clock support, UART support, and I2C > nodes. > > Signed-off-by: David Virag [...] > + psci { > + compatible = "arm,psci"; > + method = "smc"; > + cpu_suspend = <0xc4000001>; > + cpu_off = <0x84000002>; > + cpu_on = <0xc4000003>; Aren't these the standard PSCI 0.2 function numbers? Can't you make the compatible "arm,psci-0.2" instead? > + }; > + > + timer { > + compatible = "arm,armv8-timer"; > + /* Hypervisor Virtual Timer interrupt is not wired to GIC */ I don't understand this comment. You seem to have a bunch of ARMv8.0 cores, for which there is no such thing as a hypervisor virtual timer (this is an ARMv8.1 addition). > + interrupts = IRQ_TYPE_LEVEL_LOW)>, > + , > + , > + ; > + }; Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel