From: Amelie DELAUNAY <amelie.delaunay@st.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Alexandre TORGUE <alexandre.torgue@st.com>,
Linus Walleij <linus.walleij@linaro.org>,
Randy Dunlap <rdunlap@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"kbuild-all@01.org" <kbuild-all@01.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined
Date: Wed, 22 May 2019 09:20:17 +0000 [thread overview]
Message-ID: <bc1b5f1d-23b0-141d-f58f-b54ac303fe20@st.com> (raw)
In-Reply-To: <20190522084133.GF4574@dell>
On 5/22/19 10:41 AM, Lee Jones wrote:
> On Wed, 22 May 2019, Amelie DELAUNAY wrote:
>> On 5/22/19 7:48 AM, Lee Jones wrote:
>>> On Mon, 20 May 2019, Amelie Delaunay wrote:
>>>
>>>> When CONFIG_GPIO_OF is not defined, struct gpio_chip 'of_node' member does
>>>> not exist:
>>>> drivers/pinctrl/pinctrl-stmfx.c: In function 'stmfx_pinctrl_probe':
>>>> drivers/pinctrl/pinctrl-stmfx.c:652:17: error: 'struct gpio_chip' has no member named 'of_node'
>>>> pctl->gpio_chip.of_node = np;
>>>>
>>>> Fixes: 1490d9f841b1 ("pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver")
>>>> Reported-by: kbuild test robot <lkp@intel.com>
>>>> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
>>>> ---
>>>> drivers/pinctrl/pinctrl-stmfx.c | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c
>>>> index eba872c..bb64aa0 100644
>>>> --- a/drivers/pinctrl/pinctrl-stmfx.c
>>>> +++ b/drivers/pinctrl/pinctrl-stmfx.c
>>>> @@ -648,7 +648,9 @@ static int stmfx_pinctrl_probe(struct platform_device *pdev)
>>>> pctl->gpio_chip.base = -1;
>>>> pctl->gpio_chip.ngpio = pctl->pctl_desc.npins;
>>>> pctl->gpio_chip.can_sleep = true;
>>>> +#ifdef CONFIG_OF_GPIO
>>>> pctl->gpio_chip.of_node = np;
>>>> +#endif
>>>
>>> This is pretty ugly. Will STMFX ever be used without OF support? If
>>> not, it might be better to place this restriction on the driver as a
>>> whole.
>>>
>>> Incidentally, why is this blanked out in the structure definition?
>>> Even 'struct device' doesn't do this.
>>>
>> config PINCTRL_STMFX
>> tristate "STMicroelectronics STMFX GPIO expander pinctrl driver"
>> depends on I2C
>> depends on OF || COMPILE_TEST
>> select GENERIC_PINCONF
>> select GPIOLIB_IRQCHIP
>> select MFD_STMFX
>>
>> The issue is due to COMPILE_TEST: would "depends on OF || (OF &&
>> COMPILE_TEST)" be better ?
>
> Linus would be in a better position to respond, but from what I can
> see, maybe:
>
> depends on OF || (OF_GPIO && COMPILE_TEST)
>
> Although, I'm unsure why other COMPILE_TESTs haven't highlighted this
> issue. Perhaps because they have all been locked down to a particular
> arch:
>
> $ grep COMPILE_TEST -- drivers/pinctrl/Kconfig
> bool "Support pin multiplexing controllers" if COMPILE_TEST
> bool "Support pin configuration controllers" if COMPILE_TEST
> depends on OF && (ARCH_DAVINCI_DA850 || COMPILE_TEST)
> depends on OF && (ARCH_DIGICOLOR || COMPILE_TEST)
> depends on OF && (ARCH_LPC18XX || COMPILE_TEST)
> depends on ARCH_R7S72100 || COMPILE_TEST
> depends on ARCH_R7S9210 || COMPILE_TEST
> depends on ARCH_RZN1 || COMPILE_TEST
> depends on MIPS || COMPILE_TEST
>
> What about adding this to your Kconfig entry:
>
> select OF_GPIO
>
Yes COMPILE_TEST is combined with arch when depending on OF. But STMFX
isn't arch dependent, it is just OF and I2C dependent.
Randy also see a build error in pinctrl-stmfx.c when CONFIG_OF is not
set/enabled (randconfig):
../drivers/pinctrl/pinctrl-stmfx.c:409:20: error:
‘pinconf_generic_dt_node_to_map_pin’ undeclared here (not in a function)
.dt_node_to_map = pinconf_generic_dt_node_to_map_pin,
OF_GPIO depends on OF.
So either
depends on OF || (OF && COMPILE_TEST)
or
depends on OF || (OF_GPIO && COMPILE_TEST)
and
select OF_GPIO
What is the prettiest way ?
>>>> pctl->gpio_chip.need_valid_mask = true;
>>>>
>>>> ret = devm_gpiochip_add_data(pctl->dev, &pctl->gpio_chip, pctl);
>>>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-22 9:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 7:52 [PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined Amelie Delaunay
2019-05-22 0:22 ` Randy Dunlap
2019-05-22 5:48 ` Lee Jones
2019-05-22 8:08 ` Amelie DELAUNAY
2019-05-22 8:41 ` Lee Jones
2019-05-22 9:20 ` Amelie DELAUNAY [this message]
2019-05-22 9:30 ` Lee Jones
2019-05-22 21:48 ` Linus Walleij
2019-05-23 14:11 ` Amelie DELAUNAY
2019-05-23 19:18 ` Linus Walleij
2019-05-24 7:27 ` Amelie DELAUNAY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc1b5f1d-23b0-141d-f58f-b54ac303fe20@st.com \
--to=amelie.delaunay@st.com \
--cc=alexandre.torgue@st.com \
--cc=kbuild-all@01.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).