From: Philipp Zabel <p.zabel@pengutronix.de>
To: Brad Bishop <bradleyb@fuzziesquirrel.com>
Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
Andrew Jeffery <andrew@aj.id.au>,
Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] reset: simple: Add AST2600 compatibility string
Date: Thu, 12 Dec 2019 16:17:42 +0100 [thread overview]
Message-ID: <ccc48df65e340c52218fd45549c26174a10f410c.camel@pengutronix.de> (raw)
In-Reply-To: <EFF7E049-08C0-40A0-946A-18822C7AEEE3@fuzziesquirrel.com>
Hi Brad,
On Thu, 2019-12-12 at 09:51 -0500, Brad Bishop wrote:
> Hi Philipp. Thanks for your time.
>
> > On Dec 2, 2019, at 7:53 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> >
> > On Fri, 2019-11-29 at 10:38 +1030, Joel Stanley wrote:
> > > From: Brad Bishop <bradleyb@fuzziesquirrel.com>
> > >
> > > The AST2600 SoC contains the same LPC register set as the AST2500.
> >
> > If the LPC register set is exactly the same, shouldn't AST2600 reuse the
> > AST2500 compatible, i.e.:
> > compatible = "aspeed,ast2600-lpc-reset", "aspeed,ast2500-lpc-reset";
> > ?
>
> I’m not sure. I let what was already there be my guide - the ast2500
> LPC registers are the same as the ast2400 as well and those got their
> own compatibles. Is there a guideline written down somewhere that
> backs your thinking up?
I read section 2.3.1 "compatible" of the DeviceTree Specification [1] as
supporting that view. If all three LPC reset controllers are in fact
identical, I would argue that both ast2500 and ast2600 are compatible to
ast2400 and should be specified as:
compatible = "aspeed,ast2500-lpc-reset", "aspeed,ast2400-lpc-reset";
and:
compatible = "aspeed,ast2600-lpc-reset", "aspeed,ast2400-lpc-reset";
respectively.
[1] https://github.com/devicetree-org/devicetree-specification/releases/download/v0.2/devicetree-specification-v0.2.pdf
regards
Philipp
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-12-12 15:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 0:08 [PATCH v2 0/2] reset: Add ast2600 support Joel Stanley
2019-11-29 0:08 ` [PATCH v2 1/2] dt-bindings: mfd: Add ast2600 to ASPEED LPC Joel Stanley
2019-12-01 23:29 ` Andrew Jeffery
2019-12-13 21:42 ` Rob Herring
2019-11-29 0:08 ` [PATCH v2 2/2] reset: simple: Add AST2600 compatibility string Joel Stanley
2019-12-02 12:53 ` Philipp Zabel
2019-12-12 14:51 ` Brad Bishop
2019-12-12 15:17 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccc48df65e340c52218fd45549c26174a10f410c.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=andrew@aj.id.au \
--cc=bradleyb@fuzziesquirrel.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).