From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Saravana Kannan <saravanak@google.com>,
Maxim Kochetkov <fido_max@inbox.ru>
Cc: kernel test robot <lkp@intel.com>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
leoyang.li@nxp.com, Dan Carpenter <dan.carpenter@oracle.com>,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, qiang.zhao@nxp.com
Subject: Re: [PATCH v4] soc: fsl: qe: convert QE interrupt controller to platform_device
Date: Fri, 6 Aug 2021 06:53:47 +0200 [thread overview]
Message-ID: <dc3411e9-d1e0-8a23-5d9b-1aee3880b4f7@csgroup.eu> (raw)
In-Reply-To: <CAGETcx-evuv-A+A5v3-ubFZNvn_i+QSvg+tSW0OOgAd82-pytg@mail.gmail.com>
Le 06/08/2021 à 06:39, Saravana Kannan a écrit :
> On Thu, Aug 5, 2021 at 9:35 PM Maxim Kochetkov <fido_max@inbox.ru> wrote:
>>
>> 03.08.2021 20:51, Saravana Kannan wrote:
>>>> So lets convert this driver to simple platform_device with probe().
>>>> Also use platform_get_ and devm_ family function to get/allocate
>>>> resources and drop unused .compatible = "qeic".
>>> Yes, please!
>>
>> Should I totally drop { .type = "qeic"}, or keep?
>
> Sorry for the confusion. My "Yes, please"!" was a show of support for
> switching this to a proper platform driver. Not a response to that
> specific question.
>
> I didn't look at the code/DT close enough to know/care about the "type" part.
>
As far as I understand, Leo told it needs to remain, based on his answer below:
"From the original code, this should be type = "qeic". It is not
defined in current binding but probably needed for backward
compatibility."
Christophe
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-06 4:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 11:35 [PATCH v4] soc: fsl: qe: convert QE interrupt controller to platform_device Maxim Kochetkov
2021-08-03 17:51 ` Saravana Kannan
2021-08-06 4:37 ` Maxim Kochetkov
2021-08-06 4:39 ` Saravana Kannan
2021-08-06 4:53 ` Christophe Leroy [this message]
2021-08-06 23:42 ` Leo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc3411e9-d1e0-8a23-5d9b-1aee3880b4f7@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=dan.carpenter@oracle.com \
--cc=fido_max@inbox.ru \
--cc=gregkh@linuxfoundation.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=qiang.zhao@nxp.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).