From: zajec5@gmail.com (Rafał Miłecki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/2] thermal: broadcom: add Northstar thermal driver
Date: Fri, 31 Mar 2017 09:08:44 +0200 [thread overview]
Message-ID: <e5958192-1ea9-3269-0576-e114231c21a0@gmail.com> (raw)
In-Reply-To: <20170331031554.GA3161@localhost.localdomain>
Thanks for your review!
On 03/31/2017 05:15 AM, Eduardo Valentin wrote:
> On Thu, Mar 23, 2017 at 11:30:45PM +0100, Rafa? Mi?ecki wrote:
>> From: Rafa? Mi?ecki <rafal@milecki.pl>
>>
>> Northstar is a SoC family commonly used in home routers. This commit
>> adds a driver for checking CPU temperature. As Northstar Plus seems to
>> also have this IP block this new symbol gets ARCH_BCM_IPROC dependency.
>>
>
> Can you please educate me on how different this driver is from
> https://patchwork.kernel.org/patch/9619579/
>
> ?
This is a different hardware block. Northstar and BCM283x are totally different
SoCs. Northstar is mostly used in home routers, BCM283x mostly in Rasperry Pi.
>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
>> index 776b34396144..008e173ec825 100644
>> --- a/drivers/thermal/Kconfig
>> +++ b/drivers/thermal/Kconfig
>> @@ -392,6 +392,11 @@ config MTK_THERMAL
>> Enable this option if you want to have support for thermal management
>> controller present in Mediatek SoCs
>>
>> +menu "Broadcom thermal drivers"
>> +depends on ARCH_BCM || COMPILE_TEST
>
> Does the above dependency also work for other BCM chips?
I believe so. If there ever appears a driver in drivers/thermal/broadcom/ that
can't be freely compiled with COMPILE_TEST, it can just have a proper
dependency.
next prev parent reply other threads:[~2017-03-31 7:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170318155632.18099-1-zajec5@gmail.com>
2017-03-23 22:30 ` [PATCH V2 1/2] dt-bindings: thermal: add support for Broadcom's Northstar thermal Rafał Miłecki
2017-03-23 22:30 ` [PATCH V2 2/2] thermal: broadcom: add Northstar thermal driver Rafał Miłecki
2017-03-24 14:35 ` Jon Mason
2017-03-31 7:03 ` Rafał Miłecki
2017-03-31 14:23 ` Jon Mason
2017-03-31 14:49 ` Rafał Miłecki
2017-03-31 17:29 ` Jon Mason
2017-03-31 3:15 ` Eduardo Valentin
2017-03-31 7:08 ` Rafał Miłecki [this message]
2017-03-31 3:17 ` [PATCH V2 1/2] dt-bindings: thermal: add support for Broadcom's Northstar thermal Eduardo Valentin
2017-03-31 7:31 ` [PATCH V3 " Rafał Miłecki
2017-03-31 7:31 ` [PATCH V3 2/2] thermal: broadcom: add Northstar thermal driver Rafał Miłecki
2017-03-31 20:11 ` [PATCH V4 1/2] dt-bindings: thermal: add support for Broadcom's Northstar thermal Rafał Miłecki
2017-03-31 20:11 ` [PATCH V4 2/2] thermal: broadcom: add Northstar thermal driver Rafał Miłecki
2017-04-01 19:54 ` Eduardo Valentin
2017-04-01 20:20 ` Florian Fainelli
2017-04-01 21:41 ` Rafał Miłecki
2017-04-01 19:51 ` [PATCH V4 1/2] dt-bindings: thermal: add support for Broadcom's Northstar thermal Eduardo Valentin
2017-04-01 21:50 ` Rafał Miłecki
2017-04-02 4:13 ` Eduardo Valentin
2017-04-03 3:07 ` Jon Mason
2017-04-03 14:54 ` Jon Mason
2017-04-03 14:57 ` Rafał Miłecki
2017-04-03 15:48 ` [PATCH V5 " Rafał Miłecki
2017-04-03 15:48 ` [PATCH V5 2/2] thermal: broadcom: add Northstar thermal driver Rafał Miłecki
2017-04-07 4:42 ` Eduardo Valentin
2017-04-14 12:16 ` Rafał Miłecki
2017-04-14 15:16 ` Eduardo Valentin
2017-04-14 15:19 ` Rafał Miłecki
2017-04-17 20:09 ` Stefan Wahren
2017-04-10 15:00 ` [PATCH V5 1/2] dt-bindings: thermal: add support for Broadcom's Northstar thermal Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5958192-1ea9-3269-0576-e114231c21a0@gmail.com \
--to=zajec5@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).