From: Markus Elfring <Markus.Elfring@web.de>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <maz@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
linux-arm-kernel@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 14/14] irqchip/xilinx-intc: Fix potential resource leak
Date: Wed, 1 Jul 2020 11:42:47 +0200 [thread overview]
Message-ID: <e9aaa867-bb11-a469-a4b9-03fb68a18c56@web.de> (raw)
In-Reply-To: <1593569786-11500-15-git-send-email-yangtiezhu@loongson.cn>
> In the function xilinx_intc_of_init(), system resource "irqc->root_domain"
> was not released in the error case. Thus add jump target for the completion
> of the desired exception handling.
Another small wording adjustment:
… Thus add a jump target …
…
> +++ b/drivers/irqchip/irq-xilinx-intc.c
…
> @@ -250,6 +250,8 @@ static int __init xilinx_intc_of_init(struct device_node *intc,
>
> return 0;
>
> +error_domain_remove:
> + irq_domain_remove(irqc->root_domain);
> error:
> iounmap(irqc->base);
…
Can labels like “remove_irq_domain” and “unmap_io” be nicer?
Regards,
Markus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next parent reply other threads:[~2020-07-01 9:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1593569786-11500-1-git-send-email-yangtiezhu@loongson.cn>
[not found] ` <1593569786-11500-15-git-send-email-yangtiezhu@loongson.cn>
2020-07-01 9:42 ` Markus Elfring [this message]
2020-07-01 9:58 ` [PATCH v4 14/14] irqchip/xilinx-intc: Fix potential resource leak Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9aaa867-bb11-a469-a4b9-03fb68a18c56@web.de \
--to=markus.elfring@web.de \
--cc=jason@lakedaemon.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=tglx@linutronix.de \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).