From: Florian Fainelli <f.fainelli@gmail.com>
To: Rob Herring <robh@kernel.org>, Vinod Koul <vkoul@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Niklas Cassel <niklas.cassel@linaro.org>,
"David S . Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/7] dt-bindings: net: stmmac: Add the bindings documentation for delays
Date: Mon, 14 Jan 2019 15:34:57 -0800 [thread overview]
Message-ID: <eb51e1de-5090-b441-ea33-f5e67358f53c@gmail.com> (raw)
In-Reply-To: <20190111150104.GA1465@bogus>
On 1/11/19 7:01 AM, Rob Herring wrote:
> On Wed, Jan 02, 2019 at 02:47:25PM +0530, Vinod Koul wrote:
>> Some controllers require that phy delay should be disabled. So add
>
> If the MAC requires it, then the compatible string should imply this. If
> it depends on the PHY, then okay.
>
>> optional properties rx-disable-delay and tx-disable-delay for it.
>>
>> Signed-off-by: Vinod Koul <vkoul@kernel.org>
>> ---
>> Documentation/devicetree/bindings/net/stmmac.txt | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt
>> index cb694062afff..ec18897e22c8 100644
>> --- a/Documentation/devicetree/bindings/net/stmmac.txt
>> +++ b/Documentation/devicetree/bindings/net/stmmac.txt
>> @@ -74,6 +74,8 @@ Optional properties:
>> - snps,mb: mixed-burst
>> - snps,rb: rebuild INCRx Burst
>> - mdio: with compatible = "snps,dwmac-mdio", create and register mdio bus.
>> +- rx-delay-disable: bool, when present disable the rx delay
>> +- tx-delay-disable: bool, when present disable the tx delay
>
> Needs a vendor prefix.
Indeed, and it would actually be nicer to allow specifying delays
directly in ps units, see:
Documentation/devicetree/bindings/net/dwmac-sun8i.txt
Documentation/devicetree/bindings/net/mediatek-dwmac.txt
for examples.
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-01-14 23:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190102091729.18582-1-vkoul@kernel.org>
[not found] ` <20190102091729.18582-7-vkoul@kernel.org>
2019-01-02 13:40 ` [PATCH 6/7] net: phy: at803x: Add support to disable tx/rx delays Andrew Lunn
2019-01-02 14:36 ` Vinod Koul
[not found] ` <20190102091729.18582-2-vkoul@kernel.org>
2019-01-02 14:07 ` [PATCH 1/7] dt-bindings: net: Add Qualcomm ethqos binding Andrew Lunn
2019-01-02 14:37 ` Vinod Koul
[not found] ` <20190102091729.18582-4-vkoul@kernel.org>
2019-01-11 15:01 ` [PATCH 3/7] dt-bindings: net: stmmac: Add the bindings documentation for delays Rob Herring
2019-01-14 15:26 ` Vinod Koul
2019-01-14 23:34 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb51e1de-5090-b441-ea33-f5e67358f53c@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).