From: John Garry <john.garry@huawei.com>
To: Hanjun Guo <guohanjun@huawei.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Pankaj Bansal <pankaj.bansal@nxp.com>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1] ACPI/IORT: Workaround for IORT ID count "minus one" issue
Date: Tue, 14 Jan 2020 09:47:06 +0000 [thread overview]
Message-ID: <eef4fe19-5813-ab8d-6249-906dbb3dbbcd@huawei.com> (raw)
In-Reply-To: <b67fa77a-af21-9013-9162-1cfbd946e648@huawei.com>
On 14/01/2020 07:19, Hanjun Guo wrote:
> On 2020/1/13 17:34, John Garry wrote:
>> On 30/12/2019 12:27, Guohanjun (Hanjun Guo) wrote:
>>> +};
>>> +
>>> +static bool apply_id_count_workaround;
>>> +
>>> +static struct iort_workaround_oem_info wa_info[] __initdata = {
>>> + {
>>> + .oem_id = "HISI ",
>>> + .oem_table_id = "HIP07 ",
>>> + .oem_revision = 0,
>>> + }, {
>>> + .oem_id = "HISI ",
>>> + .oem_table_id = "HIP08 ",
>>> + .oem_revision = 0,
>>> + }
>>> +};
>>
>> Am I right in saying that any future BIOS for these chipsets will have to continue to have buggy firmware? If so, it's unfortunate.
>
> For better compatibility, I would say yes :(
>
> For example, if you fix that in the firmware, and update
> the IORT revision number, then it will run pretty good
> on new version of the kernel, but not on old version of
> kernel without the backporting of this patch.
ok, so that seems to be a trade off then. Having to backport introduces
a risk.
So then it might be good to add a comment to ID count members in
open-source edk2-platforms hip07 and hip08 IORTs to mention it is buggy,
so not to be copied as a reference.
Cheers,
John
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-01-14 9:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 12:27 [PATCH v1] ACPI/IORT: Workaround for IORT ID count "minus one" issue Hanjun Guo
2020-01-02 11:18 ` John Garry
2020-01-03 10:20 ` Hanjun Guo
2020-01-06 17:19 ` Robin Murphy
2020-01-07 12:03 ` Hanjun Guo
2020-01-09 16:02 ` Lorenzo Pieralisi
2020-01-10 6:22 ` Hanjun Guo
2020-01-10 10:39 ` Lorenzo Pieralisi
2020-01-10 10:51 ` Robin Murphy
2020-01-10 12:11 ` Lorenzo Pieralisi
2020-01-13 7:04 ` Hanjun Guo
2020-01-13 9:34 ` John Garry
2020-01-14 7:19 ` Hanjun Guo
2020-01-14 9:47 ` John Garry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eef4fe19-5813-ab8d-6249-906dbb3dbbcd@huawei.com \
--to=john.garry@huawei.com \
--cc=guohanjun@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=pankaj.bansal@nxp.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).