linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: <Claudiu.Beznea@microchip.com>
To: <alexandre.belloni@bootlin.com>
Cc: mark.rutland@arm.com, a.zummo@towertech.it,
	devicetree@vger.kernel.org, richard.genoud@gmail.com,
	radu_nicolae.pirea@upb.ro, linux-kernel@vger.kernel.org,
	Ludovic.Desroches@microchip.com, robh+dt@kernel.org,
	linux-spi@vger.kernel.org, lee.jones@linaro.org,
	linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org
Subject: Re: [PATCH v3 4/7] dt-bindings: atmel-usart: remove wildcard
Date: Tue, 14 Jan 2020 11:10:14 +0000	[thread overview]
Message-ID: <f3c4d460-cff6-2e14-428a-a732a6bffe38@microchip.com> (raw)
In-Reply-To: <20200114104237.GM3137@piout.net>



On 14.01.2020 12:42, Alexandre Belloni wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 14/01/2020 12:23:14+0200, Claudiu Beznea wrote:
>> Remove chip whildcard and introduce the list of compatibles instead.
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>> ---
>>  Documentation/devicetree/bindings/mfd/atmel-usart.txt | 7 +++----
>>  1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/atmel-usart.txt b/Documentation/devicetree/bindings/mfd/atmel-usart.txt
>> index 699fd3c9ace8..778e8310606a 100644
>> --- a/Documentation/devicetree/bindings/mfd/atmel-usart.txt
>> +++ b/Documentation/devicetree/bindings/mfd/atmel-usart.txt
>> @@ -1,10 +1,9 @@
>>  * Atmel Universal Synchronous Asynchronous Receiver/Transmitter (USART)
>>
>>  Required properties for USART:
>> -- compatible: Should be "atmel,<chip>-usart" or "atmel,<chip>-dbgu"
>> -  The compatible <chip> indicated will be the first SoC to support an
>> -  additional mode or an USART new feature.
>> -  For the dbgu UART, use "atmel,<chip>-dbgu", "atmel,<chip>-usart"
>> +- compatible: Should be one of the following:
>> +     - "atmel,at91rm9200-dbgu", "atmel,at91rm9200-usart"
>> +     - "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"
> 
> All the uarts are not dbgus, so this need to be:
> 
>  - "atmel,at91rm9200-usart"
>  - "atmel,at91sam9260-usart"
>  - "atmel,at91rm9200-dbgu", "atmel,at91rm9200-usart"
>  - "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"

Ok!

> 
> Also, you need to update drivers/soc/atmel/soc.c

OK. Did you refer to CIDR, EXID registers? They are at the same offsets as
for the old products. So we can rely on old compatible for them. Is this OK?

Thank you,
Claudiu Beznea

> 
>>  - reg: Should contain registers location and length
>>  - interrupts: Should contain interrupt
>>  - clock-names: tuple listing input clock names.
>> --
>> 2.7.4
>>
> 
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> 
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-01-14 11:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14 10:23 [PATCH v3 0/7] add device tree for SAM9X60 SoC and SAM9X60-EK board Claudiu Beznea
2020-01-14 10:23 ` [PATCH v3 1/7] dt-bindings: atmel-tcb: remove wildcard Claudiu Beznea
2020-01-14 23:26   ` Rob Herring
2020-01-15 10:29   ` Alexandre Belloni
2020-01-16 13:30   ` Lee Jones
2020-01-14 10:23 ` [PATCH v3 2/7] dt-bindings: atmel-tcb: add microchip,sam9x60-tcb Claudiu Beznea
2020-01-14 23:26   ` Rob Herring
2020-01-15 10:29   ` Alexandre Belloni
2020-01-16 13:30   ` Lee Jones
2020-01-14 10:23 ` [PATCH v3 3/7] dt-bindings: atmel, at91rm9200-rtc: add microchip, sam9x60-rtc Claudiu Beznea
2020-01-14 10:23 ` [PATCH v3 4/7] dt-bindings: atmel-usart: remove wildcard Claudiu Beznea
2020-01-14 10:42   ` Alexandre Belloni
2020-01-14 11:10     ` Claudiu.Beznea [this message]
2020-01-14 11:17       ` Alexandre Belloni
2020-01-14 14:58         ` Claudiu.Beznea
2020-01-14 15:03           ` Alexandre Belloni
2020-01-14 10:23 ` [PATCH v3 5/7] dt-bindings: atmel-usart: add microchip, sam9x60-{usart, dbgu} Claudiu Beznea
2020-01-16 13:32   ` [PATCH v3 5/7] dt-bindings: atmel-usart: add microchip,sam9x60-{usart, dbgu} Lee Jones
2020-01-14 10:23 ` [PATCH v3 6/7] ARM: at91/defconfig: enable MMC_SDHCI_OF_AT91 and MICROCHIP_PIT64B Claudiu Beznea
2020-01-14 10:23 ` [PATCH v3 7/7] ARM: dts: at91: sam9x60: add device tree for soc and board Claudiu Beznea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3c4d460-cff6-2e14-428a-a732a6bffe38@microchip.com \
    --to=claudiu.beznea@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=radu_nicolae.pirea@upb.ro \
    --cc=richard.genoud@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).