From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: khilman@baylibre.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v3 3/3] arm64: dts: meson: Add minimal support for Odroid-N2
Date: Wed, 22 May 2019 10:19:20 +0200 [thread overview]
Message-ID: <f7020818-5824-f998-6ebd-303014abd34d@baylibre.com> (raw)
In-Reply-To: <CAFBinCDzvroNfzhZHhDdvc+VR1eQNg5JMJ7F9=++hdWKcEXSOw@mail.gmail.com>
On 21/05/2019 20:01, Martin Blumenstingl wrote:
> Hi Neil,
>
> On Tue, May 21, 2019 at 5:20 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
> [...]
>> + hub_5v: regulator-hub_5v {
>> + compatible = "regulator-fixed";
>> + regulator-name = "HUB_5V";
>> + regulator-min-microvolt = <5000000>;
>> + regulator-max-microvolt = <5000000>;
>> + vin-supply = <&vcc_5v>;
>> +
>> + gpio = <&gpio GPIOH_5 GPIO_ACTIVE_HIGH>;
> I missed this in the review of v1:
> according to the schematics GPIOH_5 is routed to GL3523 (soldered down
> USB hub) CHIP_EN signal.
> The datasheet [0] mentions that this will "Disable whole chip and keep
> hub in lowest power state (standby mode)"
In the v1, we didn't have the schematics, so it was all a wild guess.
>
> do you know if this is a similar case as GPIOH_4 (USB hub reset line,
> we configure this using a gpio-hog)?
We have 3 signals for USB :
- GPIOH_5: goes to CHIP_EN to CHIPENABLE to the Hub
- GPIOH_4: goes to RST_N to RESETJ to the Hub
- GPIOH_6: goes to PWREN for the OTG connector PWREN
As you said, the datasheet mentions : "
Disable whole chip and keep hub in lowest power state (standby mode
"
I modeled it as a regulator since when enabled it actually enables the
power on the USB3 ports using the post-Hub VBUSCTRL signal.
Since I can't model these post-hub power enable signals, I can only
model the hub CHIPENABLE as a regulator to handle power.
I can't model the hub as a device subnode inside the dwc3 since
when CHIPENABLE is low, it won't appear...
We could model it as a Hog, but we won't be able to power down
the usb3 ports.
>
> [...]
>> +&ext_mdio {
>> + external_phy: ethernet-phy@0 {
>> + /* Realtek RTL8211F (0x001cc916) */
>> + reg = <0>;
>> + max-speed = <1000>;
>> + eee-broken-1000t;
> are we in the same situation that we have on the X96 Max where network
> dies without eee-broken-1000t?
I assume, let me run more tests to be sure.
>
> [...]
>> +&usb2_phy0 {
>> + phy-supply = <&usb_pwr_en>;
> is usb_pwr_en really the phy-supply or is it the vbus-supply of the
> USB top control block (&usb node)?
You're right, now we have the schematics, it's not the phy supply.
I'll move it to vbus-supply since it's connected to the pwrenable
of the otg port.
>
> if these three questions are answered then you can add my:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
I'll ask you to review the next version before !!!
Thanks.
Neil
>
>
> Regards
> Martin
>
>
> [0] https://datasheet.lcsc.com/szlcsc/GL3523-OV3S1_C157363.pdf
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-05-22 8:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 15:19 [PATCH v3 0/3] arm64: Add initial support for Odroid-N2 Neil Armstrong
2019-05-21 15:19 ` [PATCH v3 1/3] dt-bindings: arm: amlogic: add G12B bindings Neil Armstrong
2019-05-21 17:27 ` Martin Blumenstingl
2019-05-21 15:19 ` [PATCH v3 2/3] dt-bindings: arm: amlogic: add Odroid-N2 binding Neil Armstrong
2019-05-21 15:26 ` Rob Herring
2019-05-21 17:26 ` Martin Blumenstingl
2019-05-21 15:19 ` [PATCH v3 3/3] arm64: dts: meson: Add minimal support for Odroid-N2 Neil Armstrong
2019-05-21 16:11 ` Robin Murphy
2019-05-22 7:59 ` Neil Armstrong
2019-05-21 18:01 ` Martin Blumenstingl
2019-05-22 8:19 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7020818-5824-f998-6ebd-303014abd34d@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).