From: Valentin Schneider <valentin.schneider@arm.com>
To: Vanshidhar Konda <vanshikonda@os.amperecomputing.com>
Cc: patches@amperecomputing.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Anshuman.Khandual@arm.com
Subject: Re: [PATCH] arm64: NUMA: Kconfig: Increase max number of nodes
Date: Tue, 20 Oct 2020 19:09:36 +0100 [thread overview]
Message-ID: <jhj7drkrcpr.mognet@arm.com> (raw)
In-Reply-To: <20201020173409.1266576-1-vanshikonda@os.amperecomputing.com>
Hi,
Nit on the subject: this only increases the default, the max is still 2¹⁰.
On 20/10/20 18:34, Vanshidhar Konda wrote:
> The current arm64 max NUMA nodes default to 4. Today's arm64 systems can
> reach or exceed 16. Increase the number to 64 (matching x86_64).
>
> Signed-off-by: Vanshidhar Konda <vanshikonda@os.amperecomputing.com>
> ---
> arch/arm64/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 893130ce1626..3e69d3c981be 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -980,7 +980,7 @@ config NUMA
> config NODES_SHIFT
> int "Maximum NUMA Nodes (as a power of 2)"
> range 1 10
> - default "2"
> + default "6"
This leads to more statically allocated memory for things like node to CPU
maps (see uses of MAX_NUMNODES), but that shouldn't be too much of an
issue.
AIUI this also directly correlates to how many more page->flags bits are
required: are we sure the max 10 works on any aarch64 platform? I'm
genuinely asking here, given that I'm mostly a stranger to the mm
world. The default should be something we're somewhat confident works
everywhere.
> depends on NEED_MULTIPLE_NODES
> help
> Specify the maximum number of NUMA Nodes available on the target
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-20 18:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 17:34 [PATCH] arm64: NUMA: Kconfig: Increase max number of nodes Vanshidhar Konda
2020-10-20 18:09 ` Valentin Schneider [this message]
2020-10-21 4:13 ` Anshuman Khandual
2020-10-21 11:02 ` Jonathan Cameron
2020-10-21 22:29 ` Valentin Schneider
2020-10-29 13:37 ` Catalin Marinas
2020-10-29 19:48 ` Vanshidhar Konda
2020-10-30 10:21 ` Catalin Marinas
2020-10-21 23:44 ` Robin Murphy
2020-10-22 1:07 ` Vanshi Konda
2020-10-22 11:21 ` Robin Murphy
2020-10-22 16:25 ` Vanshi Konda
2020-10-27 22:46 ` Dave Kleikamp
2020-10-27 23:13 ` Vanshidhar Konda
2020-10-27 23:14 ` Vanshidhar Konda
2020-10-21 16:02 ` Vanshi Konda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jhj7drkrcpr.mognet@arm.com \
--to=valentin.schneider@arm.com \
--cc=Anshuman.Khandual@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@amperecomputing.com \
--cc=vanshikonda@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).