From: Stephen Boyd <swboyd@chromium.org>
To: skakit@codeaurora.org
Cc: gregkh@linuxfoundation.org, mgautam@codeaurora.org,
linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
akashast@codeaurora.org, rojay@codeaurora.org,
msavaliy@qti.qualcomm.com
Subject: Re: [PATCH V2 1/2] tty: serial: qcom_geni_serial: Allocate port->rx_fifo buffer in probe
Date: Wed, 04 Mar 2020 09:48:08 -0800 [thread overview]
Message-ID: <158334408852.7173.11568704753978099578@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <f7cfe1e4101af5133cc8b70753d20beb@codeaurora.org>
Quoting skakit@codeaurora.org (2020-03-04 05:34:20)
> As we mentioned in the V1 patch, we are passing drop="true" to handle_rx
> function so it will read and discard whatever data present in RX FIFO,
> it won't send to upper layers.
> static int handle_rx_uart(struct uart_port *uport, u32 bytes, bool drop)
> {
> ....
> ioread32_rep(uport->membase + SE_GENI_RX_FIFOn, port->rx_fifo,
> words);
> if (drop)
> return 0;
> ....
> }
> In general uart_startup() is called before set_termios() ,but as per the
> crash logs shared, it seems RX engine is active(which can only happen
> from set_termios) before startup() is called.So, if we allocate
> port->rx_fifo in probe we can overcome this crash.
Ok. Thanks for clarifying. Can you please mention in the commit text
that the fifo contents are read into rx_fifo but then dropped?
next prev parent reply other threads:[~2020-03-04 17:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 13:54 [PATCH V2 0/2] Fix RX cancel command failure satya priya
2020-02-25 13:54 ` [PATCH V2 1/2] tty: serial: qcom_geni_serial: Allocate port->rx_fifo buffer in probe satya priya
2020-02-28 22:54 ` Stephen Boyd
2020-03-04 13:38 ` skakit
2020-02-28 23:01 ` Stephen Boyd
2020-03-04 13:34 ` skakit
2020-03-04 17:48 ` Stephen Boyd [this message]
2020-02-25 13:54 ` [PATCH V2 2/2] tty: serial: qcom_geni_serial: Fix RX cancel command failure satya priya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158334408852.7173.11568704753978099578@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=akashast@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mgautam@codeaurora.org \
--cc=msavaliy@qti.qualcomm.com \
--cc=rojay@codeaurora.org \
--cc=skakit@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).