From: Hemant Kumar <hemantk@codeaurora.org>
To: Paul Davey <paul.davey@alliedtelesis.co.nz>,
Manivannan Sadhasivam <mani@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] bus: mhi: Fix pm_state conversion to string
Date: Fri, 18 Jun 2021 14:41:29 -0700 [thread overview]
Message-ID: <1624052489.10055.12.camel@codeaurora.org> (raw)
In-Reply-To: <20210618033132.24839-2-paul.davey@alliedtelesis.co.nz>
Hi Paul,
On Fri, 2021-06-18 at 15:31 +1200, Paul Davey wrote:
> On big endian architectures the mhi debugfs files which report pm
> state
> give "Invalid State" for all states.
>
> Fix to_mhi_pm_state_str by using a local unsigned long as an
> intemediate
> to pass the state to find_last_bit to avoid endianness issues with
> cast
> from enum mhi_pm_state * to unsigned long *.
>
> Signed-off-by: Paul Davey <paul.davey@alliedtelesis.co.nz>
> ---
> drivers/bus/mhi/core/init.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/core/init.c
> b/drivers/bus/mhi/core/init.c
> index c81b377fca8f..87cc0c449078 100644
> --- a/drivers/bus/mhi/core/init.c
> +++ b/drivers/bus/mhi/core/init.c
> @@ -79,7 +79,8 @@ static const char * const mhi_pm_state_str[] = {
>
> const char *to_mhi_pm_state_str(enum mhi_pm_state state)
> {
> - int index = find_last_bit((unsigned long *)&state, 32);
> + unsigned long tmp = state;
> + int index = find_last_bit((unsigned long *)&tmp, 32);
>
> if (index >= ARRAY_SIZE(mhi_pm_state_str))
> return "Invalid State";
Considering KASAN bugs reported in the past related to find_next_bit
https://www.spinics.net/lists/alsa-devel/msg110946.html
Since you are addressing the BE arch issue, would you please
use this solution instead :-
diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
index 8f4cd4d..744b617 100644
--- a/drivers/bus/mhi/core/init.c
+++ b/drivers/bus/mhi/core/init.c
@@ -77,9 +77,12 @@ static const char * const mhi_pm_state_str[] = {
const char *to_mhi_pm_state_str(enum mhi_pm_state state)
{
+ int index;
- if (index >= ARRAY_SIZE(mhi_pm_state_str))
+ if (state)
+ index = __fls(state);
+
+ if (!state || index >= ARRAY_SIZE(mhi_pm_state_str))
return "Invalid State";
return mhi_pm_state_str[index];
Thanks,
Hemant
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2021-06-18 21:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 3:31 [PATCH 0/2] bus: mhi: Fix MHI on big endian architectures Paul Davey
2021-06-18 3:31 ` [PATCH 1/2] bus: mhi: Fix pm_state conversion to string Paul Davey
2021-06-18 6:12 ` Manivannan Sadhasivam
2021-06-18 21:41 ` Hemant Kumar [this message]
2021-06-18 3:31 ` [PATCH 2/2] bus: mhi: Fix MHI DMA structure endianness Paul Davey
2021-06-18 6:29 ` Manivannan Sadhasivam
2021-06-18 6:32 ` Manivannan Sadhasivam
2021-06-22 1:31 ` Bhaumik Bhatt
2021-06-18 5:44 ` [PATCH 0/2] bus: mhi: Fix MHI on big endian architectures Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1624052489.10055.12.camel@codeaurora.org \
--to=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=paul.davey@alliedtelesis.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).