From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Hemant Kumar <hemantk@codeaurora.org>,
manivannan.sadhasivam@linaro.org, gregkh@linuxfoundation.org
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
bbhatt@codeaurora.org, loic.poulain@linaro.org
Subject: Re: [PATCH v7 3/4] docs: Add documentation for userspace client interface
Date: Wed, 21 Oct 2020 21:04:50 -0600 [thread overview]
Message-ID: <198e5431-756c-38b1-2426-eb4ab8074b60@codeaurora.org> (raw)
In-Reply-To: <b0209674-8dcb-c994-c0ef-0d2caefd28ff@codeaurora.org>
On 10/21/2020 11:46 AM, Hemant Kumar wrote:
> Hi Jeff,
>
> On 10/21/20 8:28 AM, Jeffrey Hugo wrote:
>> On 10/16/2020 10:04 PM, Hemant Kumar wrote:
>>> +release
>>
>> Should this be "close" since close() is the actual function userspace
>> would call?
> I was keeping kernel driver in mind while writing this, i can change it
> to close() if release() is confusing here.
I guess I was considering the client perspective, but this is kernel
documentation so I can see your perspective. I don't have a strong
preference. I suppose keep it as is.
>>
>>> +-------
>>> +
>>> +Decrements UCI device reference count and UCI channel reference
>>> count upon last
>>> +release(). UCI channel clean up is performed. MHI channel moves to
>>> disabled
>>> +state and inbound buffers are freed.
>>> +
>>
>>
> Thanks,
> Hemant
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-10-22 3:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-17 4:04 [PATCH v7 0/4] userspace MHI client interface driver Hemant Kumar
2020-10-17 4:04 ` [PATCH v7 1/4] bus: mhi: core: Add helper API to return number of free TREs Hemant Kumar
2020-10-21 15:27 ` Manivannan Sadhasivam
[not found] ` <CAMZdPi8xcsrKx2eV5da98fsGt2zO3f6ARMz7WJsyDSb3CnM0FA@mail.gmail.com>
2020-10-21 16:25 ` Manivannan Sadhasivam
2020-10-21 16:51 ` Loic Poulain
2020-10-21 17:55 ` Hemant Kumar
2020-10-17 4:04 ` [PATCH v7 2/4] bus: mhi: core: Move MHI_MAX_MTU to external header file Hemant Kumar
2020-10-21 15:23 ` Manivannan Sadhasivam
2020-10-17 4:04 ` [PATCH v7 3/4] docs: Add documentation for userspace client interface Hemant Kumar
2020-10-21 15:28 ` Jeffrey Hugo
2020-10-21 17:46 ` Hemant Kumar
2020-10-22 3:04 ` Jeffrey Hugo [this message]
2020-10-17 4:04 ` [PATCH v7 4/4] bus: mhi: Add userspace client interface driver Hemant Kumar
2020-10-17 7:32 ` kernel test robot
2020-10-21 16:11 ` Manivannan Sadhasivam
2020-10-21 17:43 ` Hemant Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=198e5431-756c-38b1-2426-eb4ab8074b60@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=bbhatt@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).