From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>,
stephan@gerhold.net, mathieu.poirier@linaro.org
Cc: david.brown@linaro.org, sibis@codeaurora.org,
rnayak@codeaurora.org, vivek.gautam@codeaurora.org,
agross@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, mike.leach@linaro.org
Subject: Re: Coresight causes synchronous external abort on msm8916
Date: Thu, 20 Jun 2019 15:40:24 +0530 [thread overview]
Message-ID: <1e9b470e-64e2-b4af-1a96-4907497ad950@codeaurora.org> (raw)
In-Reply-To: <8742555a-e39e-6e10-6c4b-d0d1f271d158@arm.com>
On 6/20/2019 3:38 PM, Suzuki K Poulose wrote:
> Hi Sai,
>
> On 20/06/2019 10:51, Sai Prakash Ranjan wrote:
>
> ...
>
>>>> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c
>>>> b/drivers/hwtracing/coresight/coresight-etm4x.c
>>>> index 8bb0092c7ec2..660432acbac0 100644
>>>> --- a/drivers/hwtracing/coresight/coresight-etm4x.c
>>>> +++ b/drivers/hwtracing/coresight/coresight-etm4x.c
>>>> @@ -1107,7 +1107,10 @@ static int etm4_probe(struct amba_device *adev,
>>>> const struct amba_id *id)
>>>>
>>>> spin_lock_init(&drvdata->spinlock);
>>>>
>>>> - drvdata->cpu = pdata ? pdata->cpu : 0;
>>>
>>> I believe, we should simply abort when we don't have pdata. There is no
>>> point
>>> in registering this ETM unless we know where this is connected to.
>>>
>>
>> I did not understand this comment since I am returning with ENODEV here
>> and not registering this ETM.
>
> I meant,
>
> /* fail the probe, as we don't know where this is connected to */
> if (pdata)
> return -ENOENT;
>
>
> Cheers
> Suzuki
Thanks Suzuki, got it :)
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2019-06-20 10:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 20:26 Coresight causes synchronous external abort on msm8916 Stephan Gerhold
2019-06-18 20:40 ` Mathieu Poirier
2019-06-19 17:39 ` Stephan Gerhold
2019-06-19 8:49 ` Suzuki K Poulose
2019-06-19 18:39 ` Stephan Gerhold
2019-06-19 20:16 ` Mathieu Poirier
2019-06-20 8:53 ` Suzuki K Poulose
2019-06-20 9:38 ` Sudeep Holla
2019-06-21 16:06 ` Stephan Gerhold
2019-06-21 16:16 ` Suzuki K Poulose
2019-06-21 16:30 ` Sudeep Holla
2019-06-20 6:29 ` Sai Prakash Ranjan
2019-06-20 9:06 ` Suzuki K Poulose
2019-06-20 9:51 ` Sai Prakash Ranjan
2019-06-20 10:08 ` Suzuki K Poulose
2019-06-20 10:10 ` Sai Prakash Ranjan [this message]
2019-06-20 15:00 ` Mathieu Poirier
2019-06-20 9:35 ` Sudeep Holla
2019-06-21 16:10 ` Stephan Gerhold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e9b470e-64e2-b4af-1a96-4907497ad950@codeaurora.org \
--to=saiprakash.ranjan@codeaurora.org \
--cc=agross@kernel.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=rnayak@codeaurora.org \
--cc=sibis@codeaurora.org \
--cc=stephan@gerhold.net \
--cc=suzuki.poulose@arm.com \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).