From: Lee Jones <lee.jones@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: alokc@codeaurora.org, kramasub@codeaurora.org,
andy.gross@linaro.org, david.brown@linaro.org,
wsa+renesas@sang-engineering.com, linus.walleij@linaro.org,
balbi@kernel.org, gregkh@linuxfoundation.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, jlhugo@gmail.com,
linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 6/8] usb: dwc3: qcom: Add support for booting with ACPI
Date: Wed, 5 Jun 2019 08:09:28 +0100 [thread overview]
Message-ID: <20190605070928.GJ4797@dell> (raw)
In-Reply-To: <20190605063507.GM22737@tuxbook-pro>
On Tue, 04 Jun 2019, Bjorn Andersson wrote:
> On Tue 04 Jun 03:44 PDT 2019, Lee Jones wrote:
> > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> [..]
> > @@ -373,7 +416,7 @@ static int dwc3_qcom_clk_init(struct dwc3_qcom *qcom, int count)
> >
> > qcom->num_clocks = count;
> >
> > - if (!count)
> > + if (!count || ACPI_HANDLE(dev))
> > return 0;
>
> Afaict you call this with count = of_count_phandle_with_args(), which
> should be 0. But why not skip calling this at all?
Actually count can be <0, which is why I must have needed it at the
beginning. There is another patch in this set which checks for
errors, thus the ACPI_HANDLE() call should now be superfluous. I
will test and remove it.
> > qcom->clks = devm_kcalloc(dev, qcom->num_clocks,
> > @@ -409,12 +452,28 @@ static int dwc3_qcom_clk_init(struct dwc3_qcom *qcom, int count)
> > return 0;
> > }
> >
> > +static const struct dwc3_acpi_pdata sdm845_acpi_pdata = {
> > + .qscratch_base_offset = SDM845_QSCRATCH_BASE_OFFSET,
> > + .qscratch_base_size = SDM845_QSCRATCH_SIZE,
> > + .dwc3_core_base_size = SDM845_DWC3_CORE_SIZE,
> > + .hs_phy_irq_index = 1,
> > + .dp_hs_phy_irq_index = 4,
> > + .dm_hs_phy_irq_index = 3,
> > + .ss_phy_irq_index = 2
> > +};
> > +
> > +static const struct acpi_device_id dwc3_qcom_acpi_match[] = {
> > + { "QCOM2430", (unsigned long)&sdm845_acpi_pdata },
> > + { },
> > +};
> > +MODULE_DEVICE_TABLE(acpi, dwc3_qcom_acpi_match);
>
> Analog to of_device_get_match_data() there seems to be a
> acpi_device_get_match_data(), if you use this you should be able to
> have you acpi_device_id array next to the of_device_id.
Do you mean "Analogous"?
I will try to group them, thanks.
> > +
> > static int dwc3_qcom_probe(struct platform_device *pdev)
>
> It seems that all that's left unconditional on ACPI_HANDLE() in this
> function are the optional pieces and the tail. Wouldn't it be cleaner to
> split it out in different functions?
There are ~50 lines of shared code in dwc3_qcom_probe(), most of it is
interspersed between the configuration table (DT, ACPI) pieces, which
is why it's formatted in the current way.
I can split a few things out into separate functions if you think
it'll help.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-06-05 7:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 10:44 [PATCH 1/8] i2c: i2c-qcom-geni: Provide support for ACPI Lee Jones
2019-06-04 10:44 ` [PATCH 2/8] i2c: i2c-qcom-geni: Signify successful driver probe Lee Jones
2019-06-05 6:20 ` Bjorn Andersson
2019-06-05 7:16 ` Lee Jones
2019-06-05 7:22 ` Ard Biesheuvel
2019-06-05 8:23 ` Lee Jones
2019-06-05 7:56 ` Johan Hovold
2019-06-05 8:20 ` Lee Jones
2019-06-05 8:33 ` Johan Hovold
2019-06-05 8:49 ` Lee Jones
2019-06-05 8:55 ` Johan Hovold
2019-06-05 14:18 ` Wolfram Sang
2019-06-05 18:49 ` Lee Jones
2019-06-12 14:54 ` Johan Hovold
2019-06-04 10:44 ` [PATCH 3/8] pinctrl: msm: Add ability for drivers to supply a reserved GPIO list Lee Jones
2019-06-04 10:44 ` [PATCH 4/8] pinctrl: qcom: sdm845: Provide ACPI support Lee Jones
2019-06-05 6:17 ` Bjorn Andersson
2019-06-05 7:31 ` Lee Jones
2019-06-05 19:06 ` Bjorn Andersson
2019-06-05 19:35 ` Lee Jones
2019-06-04 10:44 ` [PATCH 5/8] soc: qcom: geni: Add support for ACPI Lee Jones
2019-06-04 10:44 ` [PATCH 6/8] usb: dwc3: qcom: Add support for booting with ACPI Lee Jones
2019-06-05 6:35 ` Bjorn Andersson
2019-06-05 7:09 ` Lee Jones [this message]
2019-06-05 9:55 ` Lee Jones
2019-06-04 10:44 ` [PATCH 7/8] usb: dwc3: qcom: Start USB in 'host mode' on the SDM845 Lee Jones
2019-06-05 7:00 ` Bjorn Andersson
2019-06-05 8:34 ` Lee Jones
2019-06-05 14:07 ` Jeffrey Hugo
2019-06-05 18:50 ` Lee Jones
2019-06-05 19:14 ` Bjorn Andersson
2019-06-05 19:29 ` Lee Jones
2019-06-04 10:44 ` [PATCH 8/8] usb: dwc3: qcom: Improve error handling Lee Jones
2019-06-05 7:03 ` Bjorn Andersson
2019-06-05 11:42 [PATCH 1/8] i2c: i2c-qcom-geni: Provide support for ACPI Lee Jones
2019-06-05 11:43 ` [PATCH 6/8] usb: dwc3: qcom: Add support for booting with ACPI Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605070928.GJ4797@dell \
--to=lee.jones@linaro.org \
--cc=alokc@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jlhugo@gmail.com \
--cc=kramasub@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).