From: Vinod Koul <vkoul@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
David Brown <david.brown@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 3/5] clk: qcom: gcc-qcs404: Add MODULE_ALIAS
Date: Mon, 24 Jun 2019 13:25:09 +0530 [thread overview]
Message-ID: <20190624075509.GY2962@vkoul-mobl> (raw)
In-Reply-To: <20190617042649.GF750@tuxbook-pro>
On 16-06-19, 21:26, Bjorn Andersson wrote:
> On Wed 12 Jun 02:17 PDT 2019, Vinod Koul wrote:
>
> > MODULE_ALIAS was missing for this driver which can be built as a
> > module, so add the MODULE_ALIAS.
> >
>
> MODULE_ALIAS() serves the purpose of providing an module alias for the
> driver, which allows the automatic kernel module loader to insmod the
> driver as a device needing it is being registered.
>
> When the device is instantiated through the OF code path the compatible
> will be matched against the MODULE_DEVICE_TABLE(of, ) and if the device
> is programmatically registered (through platform_device_register_*())
> then the alias "platform:XYZ" will be used.
Thanks for the explanation Bjorn :)
>
> So, unless we're going to support module autoloading of this driver from
> a board file no alias should be needed.
Nope we dont, so will drop this one and as well as from SM8150 driver
--
~Vinod
next prev parent reply other threads:[~2019-06-24 7:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 9:17 [PATCH v2 0/5] clk: qcom: Add support for SM8150 GCC Vinod Koul
2019-06-12 9:17 ` [PATCH v2 1/5] clk: qcom: clk-alpha-pll: Remove unnecessary cast Vinod Koul
2019-06-17 4:37 ` Bjorn Andersson
2019-06-24 7:46 ` Vinod Koul
2019-06-12 9:17 ` [PATCH v2 2/5] clk: qcom: clk-alpha-pll: Remove post_div_table checks Vinod Koul
2019-06-17 4:28 ` Bjorn Andersson
2019-06-12 9:17 ` [PATCH v2 3/5] clk: qcom: gcc-qcs404: Add MODULE_ALIAS Vinod Koul
2019-06-17 4:26 ` Bjorn Andersson
2019-06-24 7:55 ` Vinod Koul [this message]
2019-06-12 9:17 ` [PATCH v2 4/5] clk: qcom: clk-alpha-pll: Add support for Trion PLLs Vinod Koul
2019-06-13 3:04 ` Taniya Das
2019-06-14 5:42 ` Vinod Koul
2019-06-17 6:10 ` Taniya Das
2019-06-17 6:16 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190624075509.GY2962@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).